You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2018/12/11 10:01:33 UTC

[GitHub] viirya opened a new pull request #23284: [SPARK-26337][SQL][TEST] Add benchmark for LongToUnsafeRowMap

viirya opened a new pull request #23284: [SPARK-26337][SQL][TEST] Add benchmark for LongToUnsafeRowMap
URL: https://github.com/apache/spark/pull/23284
 
 
   ## What changes were proposed in this pull request?
   
   Regarding the performance issue of SPARK-26155, it reports the issue on TPC-DS. I think it is better to add a benchmark for `LongToUnsafeRowMap` which is the root cause of performance regression.
   
   It can be easier to show performance difference between different metric implementations in `LongToUnsafeRowMap`.
   
   ## How was this patch tested?
   
   Added test.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org