You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/27 14:08:38 UTC
[GitHub] [flink] tillrohrmann commented on a change in pull request #10946:
[FLINK-15763][Runtime] Running TM checks only necessary resource config,
set to default for local execution
tillrohrmann commented on a change in pull request #10946: [FLINK-15763][Runtime] Running TM checks only necessary resource config, set to default for local execution
URL: https://github.com/apache/flink/pull/10946#discussion_r371257686
##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/TaskExecutorResourceUtilsTest.java
##########
@@ -78,8 +78,9 @@ private static Configuration setAllRequiredOptionsExceptOne(ConfigOption<?> opti
//noinspection unchecked
TaskExecutorResourceUtils.CONFIG_OPTIONS
.stream()
- .filter(option -> option.equals(TaskManagerOptions.CPU_CORES))
- .filter(option -> option.equals(optionToNotSet))
+ .filter(option -> !option.equals(TaskManagerOptions.CPU_CORES))
+ .filter(ConfigOption::hasDefaultValue)
Review comment:
I guess this should go to the call site where we filter out `CONFIG_OPTIONS` which have a default value.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services