You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/11/10 08:16:23 UTC
[GitHub] [camel-kafka-connector] apupier opened a new pull request #698: Avoid NPE on Windows for Catalog initialization #697
apupier opened a new pull request #698:
URL: https://github.com/apache/camel-kafka-connector/pull/698
path inside bundles are always using "/", it is a resource path, not a
file path. i tis then not using a file separator.
Signed-off-by: Aurélien Pupier <ap...@redhat.com>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kafka-connector] oscerd merged pull request #698: Avoid NPE on Windows for Catalog initialization #697
Posted by GitBox <gi...@apache.org>.
oscerd merged pull request #698:
URL: https://github.com/apache/camel-kafka-connector/pull/698
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kafka-connector] oscerd commented on pull request #698: Avoid NPE on Windows for Catalog initialization #697
Posted by GitBox <gi...@apache.org>.
oscerd commented on pull request #698:
URL: https://github.com/apache/camel-kafka-connector/pull/698#issuecomment-724540680
This was introduced here: https://github.com/apache/camel-kafka-connector/commit/0c6871f86a9d71d47bd7144c2e636509d0a80fac
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kafka-connector] apupier commented on pull request #698: Avoid NPE on Windows for Catalog initialization #697
Posted by GitBox <gi...@apache.org>.
apupier commented on pull request #698:
URL: https://github.com/apache/camel-kafka-connector/pull/698#issuecomment-724547875
> In the beginning this was just a PoC to provide something, it wasn't developed to be a jar,
it is consumed as a jar. It must work as a jar.
Having the Proof of concept, even if not working as a jar, was a great start. Now, we can incrementally improve it to support more cases.
> Also Windows is not really our main focus.
for the catalog, it is an important target given that it is used during development.
I do not have figures of OS usage for VS Code side but for Eclipse Fuse Tooling, where it is also used, 80% is Windows.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kafka-connector] apupier commented on pull request #698: Avoid NPE on Windows for Catalog initialization #697
Posted by GitBox <gi...@apache.org>.
apupier commented on pull request #698:
URL: https://github.com/apache/camel-kafka-connector/pull/698#issuecomment-724543113
> This was introduced here: [0c6871f](https://github.com/apache/camel-kafka-connector/commit/0c6871f86a9d71d47bd7144c2e636509d0a80fac)
not exactly as it was not working at all with a built jar before this commit. It has never worked on Windows with a built jar.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kafka-connector] oscerd commented on pull request #698: Avoid NPE on Windows for Catalog initialization #697
Posted by GitBox <gi...@apache.org>.
oscerd commented on pull request #698:
URL: https://github.com/apache/camel-kafka-connector/pull/698#issuecomment-724543907
In the beginning this was just a PoC to provide something, it wasn't developed to be a jar, but just to return something to consume. Also Windows is not really our main focus.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org