You are viewing a plain text version of this content. The canonical link for it is here.
Posted to scm@geronimo.apache.org by gn...@apache.org on 2009/07/03 07:16:06 UTC

svn commit: r790792 - in /geronimo/sandbox/blueprint: blueprint-cm/src/main/java/org/apache/geronimo/blueprint/compendium/cm/ blueprint-core/src/main/java/org/apache/geronimo/blueprint/container/ blueprint-core/src/main/java/org/apache/geronimo/bluepri...

Author: gnodet
Date: Fri Jul  3 05:16:05 2009
New Revision: 790792

URL: http://svn.apache.org/viewvc?rev=790792&view=rev
Log:
Fix some logging statements

Modified:
    geronimo/sandbox/blueprint/blueprint-cm/src/main/java/org/apache/geronimo/blueprint/compendium/cm/CmNamespaceHandler.java
    geronimo/sandbox/blueprint/blueprint-core/src/main/java/org/apache/geronimo/blueprint/container/BlueprintContainerImpl.java
    geronimo/sandbox/blueprint/blueprint-core/src/main/java/org/apache/geronimo/blueprint/container/ServiceListener.java
    geronimo/sandbox/blueprint/blueprint-core/src/main/java/org/apache/geronimo/blueprint/container/ServiceRecipe.java
    geronimo/sandbox/blueprint/blueprint-core/src/main/java/org/apache/geronimo/blueprint/ext/ExtNamespaceHandler.java

Modified: geronimo/sandbox/blueprint/blueprint-cm/src/main/java/org/apache/geronimo/blueprint/compendium/cm/CmNamespaceHandler.java
URL: http://svn.apache.org/viewvc/geronimo/sandbox/blueprint/blueprint-cm/src/main/java/org/apache/geronimo/blueprint/compendium/cm/CmNamespaceHandler.java?rev=790792&r1=790791&r2=790792&view=diff
==============================================================================
--- geronimo/sandbox/blueprint/blueprint-cm/src/main/java/org/apache/geronimo/blueprint/compendium/cm/CmNamespaceHandler.java (original)
+++ geronimo/sandbox/blueprint/blueprint-cm/src/main/java/org/apache/geronimo/blueprint/compendium/cm/CmNamespaceHandler.java Fri Jul  3 05:16:05 2009
@@ -140,7 +140,7 @@
     }
 
     public Metadata parse(Element element, ParserContext context) {
-        LOGGER.debug("Parsing element {" + element.getNamespaceURI() + "}" + element.getLocalName());
+        LOGGER.debug("Parsing element {{}}{}", element.getNamespaceURI(), element.getLocalName());
         ComponentDefinitionRegistry registry = context.getComponentDefinitionRegistry();
         registerManagedObjectManager(context, registry);
         if (nodeNameEquals(element, PROPERTY_PLACEHOLDER_ELEMENT)) {
@@ -153,7 +153,7 @@
     }
 
     public ComponentMetadata decorate(Node node, ComponentMetadata component, ParserContext context) {
-        LOGGER.debug("Decorating node {" + node.getNamespaceURI() + "}" + node.getLocalName());
+        LOGGER.debug("Decorating node {{}}{}", node.getNamespaceURI(), node.getLocalName());
         ComponentDefinitionRegistry registry = context.getComponentDefinitionRegistry();
         registerManagedObjectManager(context, registry);
         if (node instanceof Element) {

Modified: geronimo/sandbox/blueprint/blueprint-core/src/main/java/org/apache/geronimo/blueprint/container/BlueprintContainerImpl.java
URL: http://svn.apache.org/viewvc/geronimo/sandbox/blueprint/blueprint-core/src/main/java/org/apache/geronimo/blueprint/container/BlueprintContainerImpl.java?rev=790792&r1=790791&r2=790792&view=diff
==============================================================================
--- geronimo/sandbox/blueprint/blueprint-core/src/main/java/org/apache/geronimo/blueprint/container/BlueprintContainerImpl.java (original)
+++ geronimo/sandbox/blueprint/blueprint-core/src/main/java/org/apache/geronimo/blueprint/container/BlueprintContainerImpl.java Fri Jul  3 05:16:05 2009
@@ -167,19 +167,19 @@
 
         String timeoutDirective = paths.get(0).getDirective(BlueprintConstants.TIMEOUT_DIRECTIVE);
         if (timeoutDirective != null) {
-            LOGGER.debug("Timeout directive: " + timeoutDirective);
+            LOGGER.debug("Timeout directive: {}", timeoutDirective);
             timeout = Integer.parseInt(timeoutDirective);
         }
 
         String graceperiod = paths.get(0).getDirective(BlueprintConstants.GRACE_PERIOD);
         if (graceperiod != null) {
-            LOGGER.debug("Grace-period directive: " + graceperiod);
+            LOGGER.debug("Grace-period directive: {}", graceperiod);
             waitForDependencies = Boolean.parseBoolean(graceperiod);
         }
 
         String xmlValidationDirective = paths.get(0).getDirective(BlueprintConstants.XML_VALIDATION);
         if (xmlValidationDirective != null) {
-            LOGGER.debug("Xml-validation directive: " + xmlValidationDirective);
+            LOGGER.debug("Xml-validation directive: {}", xmlValidationDirective);
             xmlValidation = Boolean.parseBoolean(xmlValidationDirective);
         }
     }
@@ -697,7 +697,7 @@
         destroyComponents();
         
         eventDispatcher.blueprintEvent(new BlueprintEvent(BlueprintEvent.DESTROYED, getBundleContext().getBundle(), getExtenderBundle()));
-        LOGGER.debug("Blueprint container destroyed: " + this.bundleContext);
+        LOGGER.debug("Blueprint container destroyed: {}", this.bundleContext);
     }
 
     public void namespaceHandlerRegistered(URI uri) {

Modified: geronimo/sandbox/blueprint/blueprint-core/src/main/java/org/apache/geronimo/blueprint/container/ServiceListener.java
URL: http://svn.apache.org/viewvc/geronimo/sandbox/blueprint/blueprint-core/src/main/java/org/apache/geronimo/blueprint/container/ServiceListener.java?rev=790792&r1=790791&r2=790792&view=diff
==============================================================================
--- geronimo/sandbox/blueprint/blueprint-core/src/main/java/org/apache/geronimo/blueprint/container/ServiceListener.java (original)
+++ geronimo/sandbox/blueprint/blueprint-core/src/main/java/org/apache/geronimo/blueprint/container/ServiceListener.java Fri Jul  3 05:16:05 2009
@@ -71,12 +71,14 @@
             if (registerMethods.size() == 0) {
                 throw new ComponentDefinitionException("No matching methods found for listener registration method: " + registerMethod);
             }
+            LOGGER.debug("Found register methods: {}", registerMethods);
         }
         if (unregisterMethod != null) {
             unregisterMethods = ReflectionUtils.findCompatibleMethods(listenerClass, unregisterMethod, paramTypes);
             if (unregisterMethods.size() == 0) {
                 throw new ComponentDefinitionException("No matching methods found for listener unregistration method: " + unregisterMethod);
             }
+            LOGGER.debug("Found unregister methods: {}", unregisterMethods);
         }
         initialized = true;
     }

Modified: geronimo/sandbox/blueprint/blueprint-core/src/main/java/org/apache/geronimo/blueprint/container/ServiceRecipe.java
URL: http://svn.apache.org/viewvc/geronimo/sandbox/blueprint/blueprint-core/src/main/java/org/apache/geronimo/blueprint/container/ServiceRecipe.java?rev=790792&r1=790791&r2=790792&view=diff
==============================================================================
--- geronimo/sandbox/blueprint/blueprint-core/src/main/java/org/apache/geronimo/blueprint/container/ServiceRecipe.java (original)
+++ geronimo/sandbox/blueprint/blueprint-core/src/main/java/org/apache/geronimo/blueprint/container/ServiceRecipe.java Fri Jul  3 05:16:05 2009
@@ -263,7 +263,7 @@
                 service = ((ServiceFactory) service).getService(bundle, registration);
             } else if (prototypeService && bundle != blueprintContainer.getBundleContext().getBundle()) {
                 service = createInstance();
-                LOGGER.debug("Created service instance for bundle: " + bundle + " " + service.hashCode());
+                LOGGER.debug("Created service instance for bundle: {} {}", bundle, service.hashCode());
             }
             if (service == null) {
                 throw new IllegalStateException("service is null");
@@ -304,7 +304,7 @@
         }
         if (prototypeService) {
             destroyInstance(service);
-            LOGGER.debug("Destroyed service instance for bundle: " + bundle);
+            LOGGER.debug("Destroyed service instance for bundle: {}", bundle);
         }
     }
 

Modified: geronimo/sandbox/blueprint/blueprint-core/src/main/java/org/apache/geronimo/blueprint/ext/ExtNamespaceHandler.java
URL: http://svn.apache.org/viewvc/geronimo/sandbox/blueprint/blueprint-core/src/main/java/org/apache/geronimo/blueprint/ext/ExtNamespaceHandler.java?rev=790792&r1=790791&r2=790792&view=diff
==============================================================================
--- geronimo/sandbox/blueprint/blueprint-core/src/main/java/org/apache/geronimo/blueprint/ext/ExtNamespaceHandler.java (original)
+++ geronimo/sandbox/blueprint/blueprint-core/src/main/java/org/apache/geronimo/blueprint/ext/ExtNamespaceHandler.java Fri Jul  3 05:16:05 2009
@@ -99,7 +99,7 @@
     }
 
     public Metadata parse(Element element, ParserContext context) {
-        LOGGER.debug("Parsing element {" + element.getNamespaceURI() + "}" + element.getLocalName());
+        LOGGER.debug("Parsing element {{}}{}", element.getNamespaceURI(), element.getLocalName());
         if (nodeNameEquals(element, PROPERTY_PLACEHOLDER_ELEMENT)) {
             return parsePropertyPlaceholder(context, element);
         } else {