[jira] [Commented] (HBASE-20910) Fix dev-support/submit-patch.py by opening file with 'b' mode

["Ted Yu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-20910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16551381#comment-16551381 ] 

Ted Yu commented on HBASE-20910:
--------------------------------

Thanks for the patch, Ankit

Thanks for the review, Mike

> Fix dev-support/submit-patch.py by opening file with 'b' mode
> -------------------------------------------------------------
>
>                 Key: HBASE-20910
>                 URL: https://issues.apache.org/jira/browse/HBASE-20910
>             Project: HBase
>          Issue Type: Bug
>          Components: scripts
>            Reporter: Ankit Singhal
>            Assignee: Ankit Singhal
>            Priority: Major
>         Attachments: HBASE-20910.patch, HBASE-20910_v1.patch
>
>
> {code:python}
> hbase$ python3.6 dev-support/submit-patch.py
> INFO:submit-patch: Active branch: master
> INFO:submit-patch: Using tracking branch as base branch
> INFO:submit-patch: Base branch: origin/master
> INFO:submit-patch: Patch directory: /Users/asinghal/patches
> INFO:submit-patch: Patch name: master.patch
> Traceback (most recent call last):
>  File "dev-support/submit-patch.py", line 253, in <module>
>  f.write(diff.encode('utf8'))
> TypeError: write() argument must be str, not bytes
> {code}
> [~tedyu@apache.org], FYI



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)