svn commit: r1866563 - in /jackrabbit/oak/trunk: oak-blob-cloud-azure/src/main/java/org/apache/jackrabbit/oak/blob/cloud/azure/blobstorage/AzureBlobStoreBackend.java oak-blob-cloud/src/main/java/org/apache/jackrabbit/oak/blob/cloud/s3/S3Backend.java

[ma...@apache.org]

Author: mattryan
Date: Sat Sep  7 18:55:21 2019
New Revision: 1866563

URL: http://svn.apache.org/viewvc?rev=1866563&view=rev
Log:
OAK-8600: Change log level to DEBUG in getRecord() when blob does not exist

With recent optimizations to getRecord() in the cloud data stores, it is
not an unexpected thing for the corresponding blob to not exist. We
want to avoid filling logs with INFO level log messages and stack
traces for missing records if the calling code has a reasonable
expectation that the record may not exist.  A DataStoreException will
still be thrown that must be caught by the caller, in case this
situation is not expected.  Just the log level is changed.

Modified:
    jackrabbit/oak/trunk/oak-blob-cloud-azure/src/main/java/org/apache/jackrabbit/oak/blob/cloud/azure/blobstorage/AzureBlobStoreBackend.java
    jackrabbit/oak/trunk/oak-blob-cloud/src/main/java/org/apache/jackrabbit/oak/blob/cloud/s3/S3Backend.java

Modified: jackrabbit/oak/trunk/oak-blob-cloud-azure/src/main/java/org/apache/jackrabbit/oak/blob/cloud/azure/blobstorage/AzureBlobStoreBackend.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-blob-cloud-azure/src/main/java/org/apache/jackrabbit/oak/blob/cloud/azure/blobstorage/AzureBlobStoreBackend.java?rev=1866563&r1=1866562&r2=1866563&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-blob-cloud-azure/src/main/java/org/apache/jackrabbit/oak/blob/cloud/azure/blobstorage/AzureBlobStoreBackend.java (original)
+++ jackrabbit/oak/trunk/oak-blob-cloud-azure/src/main/java/org/apache/jackrabbit/oak/blob/cloud/azure/blobstorage/AzureBlobStoreBackend.java Sat Sep  7 18:55:21 2019
@@ -389,7 +389,12 @@ public class AzureBlobStoreBackend exten
             return record;
         }
         catch (StorageException e) {
-            LOG.info("Error getting data record for blob. identifier={}", key, e);
+            if (404 == e.getHttpStatusCode()) {
+                LOG.debug("Unable to get record for blob; blob does not exist. identifier={}", key);
+            }
+            else {
+                LOG.info("Error getting data record for blob. identifier={}", key, e);
+            }
             throw new DataStoreException(String.format("Cannot retrieve blob. identifier=%s", key), e);
         }
         catch (URISyntaxException e) {

Modified: jackrabbit/oak/trunk/oak-blob-cloud/src/main/java/org/apache/jackrabbit/oak/blob/cloud/s3/S3Backend.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-blob-cloud/src/main/java/org/apache/jackrabbit/oak/blob/cloud/s3/S3Backend.java?rev=1866563&r1=1866562&r2=1866563&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-blob-cloud/src/main/java/org/apache/jackrabbit/oak/blob/cloud/s3/S3Backend.java (original)
+++ jackrabbit/oak/trunk/oak-blob-cloud/src/main/java/org/apache/jackrabbit/oak/blob/cloud/s3/S3Backend.java Sat Sep  7 18:55:21 2019
@@ -644,7 +644,7 @@ public class S3Backend extends AbstractS
             return record;
         } catch (AmazonServiceException e) {
             if (e.getStatusCode() == 404 || e.getStatusCode() == 403) {
-                LOG.info(
+                LOG.debug(
                         "getRecord:Identifier [{}] not found. Took [{}] ms.",
                         identifier, (System.currentTimeMillis() - start));
             }