You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kylin.apache.org by li...@apache.org on 2015/07/11 01:27:34 UTC
[48/50] [abbrv] incubator-kylin git commit: KYLIN-875 minor refactor,
add 'addTask()' to interface ChainedExecutable
KYLIN-875 minor refactor, add 'addTask()' to interface ChainedExecutable
Project: http://git-wip-us.apache.org/repos/asf/incubator-kylin/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-kylin/commit/44c09a26
Tree: http://git-wip-us.apache.org/repos/asf/incubator-kylin/tree/44c09a26
Diff: http://git-wip-us.apache.org/repos/asf/incubator-kylin/diff/44c09a26
Branch: refs/heads/0.7
Commit: 44c09a269e642bbc511fba197a8ae83db86cc3a8
Parents: 340a175
Author: Li, Yang <ya...@ebay.com>
Authored: Wed Jul 8 11:15:49 2015 +0800
Committer: Li, Yang <ya...@ebay.com>
Committed: Wed Jul 8 11:16:20 2015 +0800
----------------------------------------------------------------------
.../org/apache/kylin/job/execution/ChainedExecutable.java | 4 +++-
.../java/org/apache/kylin/job/manager/ExecutableManager.java | 8 ++++----
2 files changed, 7 insertions(+), 5 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-kylin/blob/44c09a26/job/src/main/java/org/apache/kylin/job/execution/ChainedExecutable.java
----------------------------------------------------------------------
diff --git a/job/src/main/java/org/apache/kylin/job/execution/ChainedExecutable.java b/job/src/main/java/org/apache/kylin/job/execution/ChainedExecutable.java
index 3eddf1d..8ceb23e 100644
--- a/job/src/main/java/org/apache/kylin/job/execution/ChainedExecutable.java
+++ b/job/src/main/java/org/apache/kylin/job/execution/ChainedExecutable.java
@@ -25,6 +25,8 @@ import java.util.List;
*/
public interface ChainedExecutable extends Executable {
- List<? extends Executable> getTasks();
+ List<? extends AbstractExecutable> getTasks();
+
+ void addTask(AbstractExecutable executable);
}
http://git-wip-us.apache.org/repos/asf/incubator-kylin/blob/44c09a26/job/src/main/java/org/apache/kylin/job/manager/ExecutableManager.java
----------------------------------------------------------------------
diff --git a/job/src/main/java/org/apache/kylin/job/manager/ExecutableManager.java b/job/src/main/java/org/apache/kylin/job/manager/ExecutableManager.java
index a2b310b..05f8c8e 100644
--- a/job/src/main/java/org/apache/kylin/job/manager/ExecutableManager.java
+++ b/job/src/main/java/org/apache/kylin/job/manager/ExecutableManager.java
@@ -280,9 +280,9 @@ public class ExecutableManager {
result.setUuid(executable.getId());
result.setType(executable.getClass().getName());
result.setParams(executable.getParams());
- if (executable instanceof DefaultChainedExecutable) {
+ if (executable instanceof ChainedExecutable) {
List<ExecutablePO> tasks = Lists.newArrayList();
- for (AbstractExecutable task : ((DefaultChainedExecutable) executable).getTasks()) {
+ for (AbstractExecutable task : ((ChainedExecutable) executable).getTasks()) {
tasks.add(parse(task));
}
result.setTasks(tasks);
@@ -304,9 +304,9 @@ public class ExecutableManager {
result.setParams(executablePO.getParams());
List<ExecutablePO> tasks = executablePO.getTasks();
if (tasks != null && !tasks.isEmpty()) {
- Preconditions.checkArgument(result instanceof DefaultChainedExecutable);
+ Preconditions.checkArgument(result instanceof ChainedExecutable);
for (ExecutablePO subTask: tasks) {
- ((DefaultChainedExecutable) result).addTask(parseTo(subTask));
+ ((ChainedExecutable) result).addTask(parseTo(subTask));
}
}
return result;