You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@kafka.apache.org by shivsantham <gi...@git.apache.org> on 2017/10/21 07:07:56 UTC

[GitHub] kafka pull request #4109: KAFKA-6024 - Move validation in KafkaConsumer ahea...

GitHub user shivsantham opened a pull request:

    https://github.com/apache/kafka/pull/4109

    KAFKA-6024 - Move validation in KafkaConsumer ahead of acquireAndEnsu…

    In several methods, parameter validation is done after calling acquireAndEnsureOpen() in Kafka Consumer :
    
        public void seek(TopicPartition partition, long offset) {
            acquireAndEnsureOpen();
            try {
                if (offset < 0)
                    throw new IllegalArgumentException("seek offset must not be a negative number");
    
    Since the value of parameter would not change per invocation, it seems performing validation ahead of acquireAndEnsureOpen() call would be better.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shivsantham/kafka kafka-6024

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/4109.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4109
    
----
commit 79b6fbcff617f6412798d6395b3378df5dd601ed
Author: siva santhalingam <si...@gmail.com>
Date:   2017-10-21T07:05:03Z

    KAFKA-6024 - Move validation in KafkaConsumer ahead of acquireAndEnsureOpen()

----


---