You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "jsoref (via GitHub)" <gi...@apache.org> on 2023/09/28 22:53:27 UTC
[GitHub] [superset] jsoref opened a new pull request, #25452: chore(frontend): Spelling
jsoref opened a new pull request, #25452:
URL: https://github.com/apache/superset/pull/25452
### SUMMARY
Spelling fixes for the frontend
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] john-bodley commented on a diff in pull request #25452: chore(frontend): Spelling
Posted by "john-bodley (via GitHub)" <gi...@apache.org>.
john-bodley commented on code in PR #25452:
URL: https://github.com/apache/superset/pull/25452#discussion_r1341615385
##########
superset-frontend/packages/superset-ui-core/test/chart/components/ChartDataProvider.test.tsx:
##########
@@ -214,7 +214,7 @@ describe('ChartDataProvider', () => {
const children = jest.fn<React.ReactNode, unknown[]>();
setup({ children });
- // during the first tick (before more promises resolve) loading is true
+ // during the first tick (befor more promises resolve) loading is true
Review Comment:
```suggestion
// during the first tick (before more promises resolve) loading is true
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] jsoref commented on a diff in pull request #25452: chore(frontend): Spelling
Posted by "jsoref (via GitHub)" <gi...@apache.org>.
jsoref commented on code in PR #25452:
URL: https://github.com/apache/superset/pull/25452#discussion_r1340751622
##########
superset/translations/en/LC_MESSAGES/messages.json:
##########
Review Comment:
Sadly, these files are a mix of frontend/backend. I should have looked more carefully...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] jsoref commented on a diff in pull request #25452: chore(frontend): Spelling
Posted by "jsoref (via GitHub)" <gi...@apache.org>.
jsoref commented on code in PR #25452:
URL: https://github.com/apache/superset/pull/25452#discussion_r1340758926
##########
superset-frontend/cypress-base/cypress/e2e/dashboard/nativeFilters.test.ts:
##########
@@ -225,11 +225,11 @@ function setFilterBarOrientation(orientation: 'vertical' | 'horizontal') {
}
}
-function openMoreFilters(intercetFilterState = true) {
+function openMoreFilters(waitFilterState = true) {
interceptFilterState();
cy.getBySel('dropdown-container-btn').click();
- if (intercetFilterState) {
+ if (waitFilterState) {
Review Comment:
This typo meant that people didn't realize that they were almost shadowing a function. I've renamed the argument to `wait` instead of `intercept` to more accurately describe what the boolean guards...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(frontend): Spelling [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #25452:
URL: https://github.com/apache/superset/pull/25452#issuecomment-2299738756
Oof... not so sure about this one @jsoref - looks like a more painful rebase situation than the other PR :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] jsoref commented on a diff in pull request #25452: chore(frontend): Spelling
Posted by "jsoref (via GitHub)" <gi...@apache.org>.
jsoref commented on code in PR #25452:
URL: https://github.com/apache/superset/pull/25452#discussion_r1341631039
##########
superset-frontend/packages/superset-ui-core/test/chart/components/ChartDataProvider.test.tsx:
##########
@@ -214,7 +214,7 @@ describe('ChartDataProvider', () => {
const children = jest.fn<React.ReactNode, unknown[]>();
setup({ children });
- // during the first tick (before more promises resolve) loading is true
+ // during the first tick (befor more promises resolve) loading is true
Review Comment:
oops
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on a diff in pull request #25452: chore(frontend): Spelling
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on code in PR #25452:
URL: https://github.com/apache/superset/pull/25452#discussion_r1341784864
##########
superset-frontend/src/setup/setupApp.ts:
##########
@@ -95,6 +95,6 @@ export default function setupApp() {
window.jQuery = $;
require('bootstrap');
- // setup appwide custom error messages
+ // set up app wide custom error messages
Review Comment:
arguably it should be app-wide.
##########
superset-frontend/src/setup/setupApp.ts:
##########
@@ -95,6 +95,6 @@ export default function setupApp() {
window.jQuery = $;
require('bootstrap');
- // setup appwide custom error messages
+ // set up app wide custom error messages
Review Comment:
... but I won't lose any sleep over that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on a diff in pull request #25452: chore(frontend): Spelling
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on code in PR #25452:
URL: https://github.com/apache/superset/pull/25452#discussion_r1341784366
##########
superset-frontend/src/pages/DatasetList/index.tsx:
##########
@@ -493,7 +493,7 @@ const DatasetList: FunctionComponent<DatasetListProps> = ({
)}
{canDuplicate && original.kind === 'virtual' && (
<Tooltip
- id="duplicate-action-tooltop"
+ id="duplicate-action-tooltip"
Review Comment:
here's the instance you caught (thanks!) that affects the script elsewhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(frontend): Spelling [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on code in PR #25452:
URL: https://github.com/apache/superset/pull/25452#discussion_r1750567978
##########
superset-frontend/src/components/Button/Button.test.tsx:
##########
@@ -38,10 +38,10 @@ test('does not handle onClicks when disabled', () => {
expect(mockAction).toHaveBeenCalledTimes(0);
});
+
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] jsoref commented on a diff in pull request #25452: chore(frontend): Spelling
Posted by "jsoref (via GitHub)" <gi...@apache.org>.
jsoref commented on code in PR #25452:
URL: https://github.com/apache/superset/pull/25452#discussion_r1340733245
##########
superset-frontend/plugins/plugin-chart-echarts/test/Graph/transformProps.test.ts:
##########
@@ -172,7 +172,7 @@ describe('EchartsGraph transformProps', () => {
);
});
- it('should transform chart props for viz with category and falsey normalization', () => {
+ it('should transform chart props for viz with category and falsy normalization', () => {
Review Comment:
apparently i'm temporarily opinionated. I can't remember why. Typically it's because both spellings are in use.
##########
superset-frontend/src/SqlLab/components/App/index.jsx:
##########
@@ -125,7 +125,7 @@ class App extends React.PureComponent {
componentDidUpdate() {
const { localStorageUsageInKilobytes, actions, queries } = this.props;
- const queryCount = queries?.lenghth || 0;
+ const queryCount = queries?.length || 0;
Review Comment:
scary;
I think we've talked about this in the past :(
##########
superset-frontend/src/pages/DatasetList/DatasetList.test.tsx:
##########
@@ -197,7 +197,7 @@ describe('DatasetList', () => {
).toBeFalsy();
act(() => {
wrapper
- .find('#duplicate-action-tooltop')
+ .find('#duplicate-action-tooltip')
Review Comment:
notable
##########
superset-frontend/packages/superset-ui-core/test/query/processExtraFormData.test.ts:
##########
@@ -19,7 +19,7 @@
import { overrideExtraFormData } from '../../src/query/processExtraFormData';
describe('overrideExtraFormData', () => {
- it('should assign allowed non-existent value', () => {
+ it('should assign allowed nonexistent value', () => {
Review Comment:
often controversial (I can't find the discussion)
##########
superset-frontend/plugins/plugin-chart-table/src/TableChart.tsx:
##########
@@ -665,7 +665,7 @@ export default function TableChart<D extends DataRecord = DataRecord>(
useLayoutEffect(() => {
// After initial load the table should resize only when the new sizes
- // Are not only scrollbar updates, otherwise, the table would twicth
+ // Are not only scrollbar updates, otherwise, the table would twitch
Review Comment:
I seem to remember discussing this, I'm not sure why it wasn't resolved
##########
superset-frontend/plugins/legacy-preset-chart-deckgl/src/layers/Heatmap/Heatmap.tsx:
##########
@@ -66,7 +66,7 @@ export const getLayer: getLayerType<unknown> = (
?.reverse() as Color[];
return new HeatmapLayer({
- id: `heatmp-layer-${fd.slice_id}` as const,
+ id: `heatmap-layer-${fd.slice_id}` as const,
Review Comment:
possibly problematic as it's changing an id
##########
superset-frontend/packages/superset-ui-demo/storybook/stories/plugins/plugin-chart-pivot-table/testData.ts:
##########
@@ -91,7 +91,7 @@ export const basicData = {
data: [
{
location: 'AMEA',
- program_language: 'Javscript',
+ program_language: 'JavaScript',
Review Comment:
similarly.
fwiw, I threw out my baseline because I wanted to test the next version of check-spelling...
##########
superset-frontend/src/components/Button/Button.test.tsx:
##########
@@ -50,7 +50,7 @@ describe('Button', () => {
});
// test stories from the storybook!
- it('All the sorybook gallery variants mount', () => {
+ it('All the storybook gallery variants mount', () => {
Review Comment:
brand
##########
superset-frontend/cypress-base/cypress/e2e/sqllab/_skip.sourcePanel.index.test.js:
##########
@@ -23,7 +23,7 @@ describe.skip('SqlLab datasource panel', () => {
cy.visit('/superset/sqllab');
});
- // TODO the test bellow is flaky, and has been disabled for the time being
+ // TODO the test below is flaky, and has been disabled for the time being
Review Comment:
This is actually a word: https://www.merriam-webster.com/dictionary/bellow, but it's almost never right, so I now reject it by default in spell-check-this: https://github.com/check-spelling/spell-check-this/blob/b968ca32e0e5961a85c7fe3e9431f81553c3f434/.github/actions/spelling/reject.txt#L2
##########
superset-frontend/plugins/legacy-plugin-chart-partition/src/Partition.js:
##########
@@ -331,7 +331,7 @@ function Icicle(element, props) {
tooltip.interrupt().transition().duration(250).style('opacity', 0);
});
- // When clicking a subdivision, the vis will zoom in to it
+ // When clicking a subdivision, the vis will zoom into it
Review Comment:
often controversial
##########
superset-frontend/cypress-base/cypress/e2e/dashboard/utils.ts:
##########
@@ -205,9 +205,9 @@ export function expandFilterOnLeftPanel() {
}
/** ************************************************************************
- * Collapes Native Filter from the left panel on dashboard
+ * Collapses Native Filter from the left panel on dashboard
* @returns {None}
- * @summary helper for collape native filter
+ * @summary helper for collapse native filter
Review Comment:
I have a feeling we talked about this in the past, but I'm not certain...
##########
superset-frontend/src/dashboard/components/DashboardBuilder/DashboardBuilder.test.tsx:
##########
@@ -46,7 +46,7 @@ jest.mock('src/dashboard/actions/dashboardState', () => ({
}));
jest.mock('src/components/ResizableSidebar/useStoredSidebarWidth');
-// mock following dependant components to fix the prop warnings
+// mock following dependent components to fix the prop warnings
Review Comment:
https://www.merriam-webster.com/grammar/spelling-variants-dependent-vs-dependant
In general, dependant is only right in en-GB and only when referencing a person.
##########
superset-frontend/src/SqlLab/components/SqlEditor/SqlEditor.test.jsx:
##########
@@ -107,7 +107,7 @@ const logAction = () => next => action => {
const createStore = initState =>
setupStore({
- disableDegugger: true,
+ disableDebugger: true,
Review Comment:
scary
##########
superset-frontend/src/dashboard/components/SliceHeader/SliceHeader.test.tsx:
##########
@@ -356,7 +356,7 @@ test('Should render "annotationsError"', () => {
render(<SliceHeader {...props} />, { useRedux: true, useRouter: true });
expect(
screen.getByRole('img', {
- name: 'One ore more annotation layers failed loading.',
+ name: 'One or more annotation layers failed loading.',
Review Comment:
New spell-check-this rule:
https://github.com/check-spelling/spell-check-this/blob/b968ca32e0e5961a85c7fe3e9431f81553c3f434/.github/actions/spelling/line_forbidden.patterns#L67-L68
##########
superset-frontend/src/dashboard/util/getDashboardUrl.test.js:
##########
@@ -89,15 +89,15 @@ describe('getChartIdsFromLayout', () => {
windowSpy.mockImplementation(() => ({
location: {
origin: 'https://localhost',
- search: '?unkown_param=value',
+ search: '?unknown_param=value',
Review Comment:
always unclear when tests do things like this what they're testing...
##########
superset-frontend/src/SqlLab/fixtures.ts:
##########
@@ -29,7 +29,7 @@ import { ISaveableDatasource } from 'src/SqlLab/components/SaveDatasetModal';
export const mockedActions = sinon.stub({ ...actions });
-export const alert = { bsStyle: 'danger', msg: 'Ooops', id: 'lksvmcx32' };
+export const alert = { bsStyle: 'danger', msg: 'Oops', id: 'lksvmcx32' };
Review Comment:
hopefully this doesn't matter
##########
superset-frontend/tools/eslint-plugin-translation-vars/index.js:
##########
@@ -41,7 +41,7 @@ module.exports = {
context.report({
node,
message:
- "Don't use variables in translation string templates. Flask-babel is a static translation translation service, so it can’t handle strings that include variables",
+ "Don't use variables in translation string templates. Flask-babel is a static translation service, so it can’t handle strings that include variables",
Review Comment:
duplicate words are usually typos...
##########
superset-frontend/src/explore/components/controls/DatasourceControl/index.jsx:
##########
@@ -179,7 +179,7 @@ class DatasourceControl extends React.PureComponent {
const { columns } = datasource;
// the current granularity_sqla might not be a temporal column anymore
const timeCol = this.props.form_data?.granularity_sqla;
- const isGranularitySqalTemporal = columns.find(
+ const isGranularitySqlaTemporal = columns.find(
Review Comment:
brand
##########
superset-frontend/src/setup/setupApp.ts:
##########
@@ -95,6 +95,6 @@ export default function setupApp() {
window.jQuery = $;
require('bootstrap');
- // setup appwide custom error messages
+ // set up app wide custom error messages
Review Comment:
notable. `setup` is a noun but this wants the verb-phrase, and there's no particularly good reason to merge `app`+`wide`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(frontend): Spelling [superset]
Posted by "jsoref (via GitHub)" <gi...@apache.org>.
jsoref commented on PR #25452:
URL: https://github.com/apache/superset/pull/25452#issuecomment-2299744029
lemme look...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on a diff in pull request #25452: chore(frontend): Spelling
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on code in PR #25452:
URL: https://github.com/apache/superset/pull/25452#discussion_r1341780207
##########
superset-frontend/src/SqlLab/components/App/index.jsx:
##########
@@ -125,7 +125,7 @@ class App extends React.PureComponent {
componentDidUpdate() {
const { localStorageUsageInKilobytes, actions, queries } = this.props;
- const queryCount = queries?.lenghth || 0;
+ const queryCount = queries?.length || 0;
Review Comment:
Yeah, I remember this to... let's let it through...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on a diff in pull request #25452: chore(frontend): Spelling
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on code in PR #25452:
URL: https://github.com/apache/superset/pull/25452#discussion_r1341779495
##########
superset-frontend/plugins/legacy-preset-chart-nvd3/src/NVD3Controls.tsx:
##########
@@ -170,7 +170,7 @@ export const showControls: CustomControlItem = {
default: false,
description: t(
'Whether to show extra controls or not. Extra controls ' +
- 'include things like making mulitBar charts stacked ' +
+ 'include things like making multiBar charts stacked ' +
Review Comment:
this might actually need to be multi-bar... but what you have here is an improvement, so that's fine :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(frontend): Spelling [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on code in PR #25452:
URL: https://github.com/apache/superset/pull/25452#discussion_r1750568330
##########
superset-frontend/src/components/Button/Button.test.tsx:
##########
@@ -38,10 +38,10 @@ test('does not handle onClicks when disabled', () => {
expect(mockAction).toHaveBeenCalledTimes(0);
});
+
Review Comment:
Making `prettier` happy :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(frontend): Spelling [superset]
Posted by "jsoref (via GitHub)" <gi...@apache.org>.
jsoref commented on PR #25452:
URL: https://github.com/apache/superset/pull/25452#issuecomment-2299762053
@rusackas: rebased -- thankfully single correction scoped commits isn't as daunting as a squashed quagmire when rebasing :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on a diff in pull request #25452: chore(frontend): Spelling
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on code in PR #25452:
URL: https://github.com/apache/superset/pull/25452#discussion_r1341784106
##########
superset-frontend/src/pages/DatasetList/DatasetList.test.tsx:
##########
@@ -197,7 +197,7 @@ describe('DatasetList', () => {
).toBeFalsy();
act(() => {
wrapper
- .find('#duplicate-action-tooltop')
+ .find('#duplicate-action-tooltip')
Review Comment:
It looks like you got it in the other location where it's set, so we should be fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #25452: chore(frontend): Spelling
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #25452:
URL: https://github.com/apache/superset/pull/25452#issuecomment-1741681863
Codeowner stamp needed from @kgabryje @geido or @michael-s-molina
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on a diff in pull request #25452: chore(frontend): Spelling
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on code in PR #25452:
URL: https://github.com/apache/superset/pull/25452#discussion_r1341778931
##########
superset-frontend/plugins/legacy-preset-chart-deckgl/src/layers/Heatmap/Heatmap.tsx:
##########
@@ -66,7 +66,7 @@ export const getLayer: getLayerType<unknown> = (
?.reverse() as Color[];
return new HeatmapLayer({
- id: `heatmp-layer-${fd.slice_id}` as const,
+ id: `heatmap-layer-${fd.slice_id}` as const,
Review Comment:
I think it's fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(frontend): Spelling [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas merged PR #25452:
URL: https://github.com/apache/superset/pull/25452
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org