You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "RexXiong (via GitHub)" <gi...@apache.org> on 2023/04/25 12:59:14 UTC

[GitHub] [incubator-celeborn] RexXiong opened a new pull request, #1458: [CELEBORN-553] Improve IO for Rpc/openChannel

RexXiong opened a new pull request, #1458:
URL: https://github.com/apache/incubator-celeborn/pull/1458

   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     - Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'.
     - Be sure to keep the PR description updated to reflect all changes.
     - Please write your PR title to summarize what this PR proposes.
     - If possible, provide a concise example to reproduce the issue for a faster review.
   -->
   
   ### What changes were proposed in this pull request?
   1.Use FileChannel instead FileOutputStream/FileInputStream
   2.batch release partition request as default
   
   ### Why are the changes needed?
   1.Use FileChannel instead FileOutputStream/FileInputStream this will benefit when close the channel.
   2. Every time release one single partition will cost lots of rpc threads to handle
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   
   ### How was this patch tested?
   UT & TPCDS
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-celeborn] codecov[bot] commented on pull request #1458: [CELEBORN-553] Improve IO for Rpc/openChannel

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #1458:
URL: https://github.com/apache/incubator-celeborn/pull/1458#issuecomment-1521767439

   ## [Codecov](https://codecov.io/gh/apache/incubator-celeborn/pull/1458?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1458](https://codecov.io/gh/apache/incubator-celeborn/pull/1458?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (acc34e3) into [main](https://codecov.io/gh/apache/incubator-celeborn/commit/01d8d1079cd2e8ac4de514a675a10093af2e26dd?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (01d8d10) will **decrease** coverage by `0.04%`.
   > The diff coverage is `100.00%`.
   
   ```diff
   @@            Coverage Diff             @@
   ##             main    #1458      +/-   ##
   ==========================================
   - Coverage   44.82%   44.78%   -0.04%     
   ==========================================
     Files         155      155              
     Lines        9586     9586              
     Branches      955      955              
   ==========================================
   - Hits         4296     4292       -4     
   - Misses       5007     5009       +2     
   - Partials      283      285       +2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-celeborn/pull/1458?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...cala/org/apache/celeborn/common/CelebornConf.scala](https://codecov.io/gh/apache/incubator-celeborn/pull/1458?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvY2VsZWJvcm4vY29tbW9uL0NlbGVib3JuQ29uZi5zY2FsYQ==) | `86.97% <100.00%> (ø)` | |
   
   ... and [2 files with indirect coverage changes](https://codecov.io/gh/apache/incubator-celeborn/pull/1458/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-celeborn] waitinfuture merged pull request #1458: [CELEBORN-553] Improve IO for Rpc/openChannel

Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture merged PR #1458:
URL: https://github.com/apache/incubator-celeborn/pull/1458


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org