You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by Daniel Shahaf <d....@daniel.shahaf.name> on 2013/07/09 22:05:38 UTC

Re: svn commit: r1501360 - /subversion/trunk/subversion/libsvn_wc/wc_db.c

rhuijben@apache.org wrote on Tue, Jul 09, 2013 at 16:09:33 -0000:
> @@ -13532,6 +13533,9 @@ wclock_obtain_cb(svn_wc__db_wcroot_t *wc
> +  if (enforce_empty_wq)
> +    svn_wc__db_verify_no_work(wcroot->sdb);

Missing SVN_ERR wrapper.

> @@ -13679,9 +13683,6 @@ svn_wc__db_wclock_obtain(svn_wc__db_t *d
> -  if (db->enforce_empty_wq)
> -    SVN_ERR(svn_wc__db_verify_no_work(wcroot->sdb));

RE: svn commit: r1501360 - /subversion/trunk/subversion/libsvn_wc/wc_db.c

Posted by Bert Huijben <be...@qqmail.nl>.

> -----Original Message-----
> From: Daniel Shahaf [mailto:d.s@daniel.shahaf.name]
> Sent: dinsdag 9 juli 2013 22:06
> To: dev@subversion.apache.org
> Cc: commits@subversion.apache.org
> Subject: Re: svn commit: r1501360 -
> /subversion/trunk/subversion/libsvn_wc/wc_db.c
> 
> rhuijben@apache.org wrote on Tue, Jul 09, 2013 at 16:09:33 -0000:
> > @@ -13532,6 +13533,9 @@ wclock_obtain_cb(svn_wc__db_wcroot_t *wc
> > +  if (enforce_empty_wq)
> > +    svn_wc__db_verify_no_work(wcroot->sdb);
> 
> Missing SVN_ERR wrapper.
> 
> > @@ -13679,9 +13683,6 @@ svn_wc__db_wclock_obtain(svn_wc__db_t *d
> > -  if (db->enforce_empty_wq)
> > -    SVN_ERR(svn_wc__db_verify_no_work(wcroot->sdb));

Good catch.
(writing patch now)

	Bert