You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Likitha Shetty <li...@citrix.com> on 2012/12/12 13:59:33 UTC
Review Request: Unable to edit a Sub domain
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8547/
-----------------------------------------------------------
Review request for cloudstack and Alena Prokharchyk.
Description
-------
UpdateDomain to be consistent with CreateDomain i.e. before this operation, while checking if the domain-name is unique, search under the parent domain instead of searching under the ROOT domain.
This addresses bug CLOUDSTACK-617.
Diffs
-----
server/src/com/cloud/server/ManagementServerImpl.java 117be57
Diff: https://reviews.apache.org/r/8547/diff/
Testing
-------
Created this tree of domains
ROOT
india
dev
prod
us
dev
prod
Each domain has 2 subdomains "dev" and "prod".
Able to successfully edit 'network' domain (other fields as well).
Thanks,
Likitha Shetty
Re: Review Request: Unable to edit a Sub domain
Posted by Rohit Yadav <bh...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8547/#review15908
-----------------------------------------------------------
Ship it!
Ship It!
- Rohit Yadav
On Dec. 12, 2012, 12:59 p.m., Likitha Shetty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8547/
> -----------------------------------------------------------
>
> (Updated Dec. 12, 2012, 12:59 p.m.)
>
>
> Review request for cloudstack and Alena Prokharchyk.
>
>
> Description
> -------
>
> UpdateDomain to be consistent with CreateDomain i.e. before this operation, while checking if the domain-name is unique, search under the parent domain instead of searching under the ROOT domain.
>
>
> This addresses bug CLOUDSTACK-617.
>
>
> Diffs
> -----
>
> server/src/com/cloud/server/ManagementServerImpl.java 117be57
>
> Diff: https://reviews.apache.org/r/8547/diff/
>
>
> Testing
> -------
>
> Created this tree of domains
>
> ROOT
> india
> dev
> prod
> us
> dev
> prod
>
> Each domain has 2 subdomains "dev" and "prod".
> Able to successfully edit 'network' domain (other fields as well).
>
>
> Thanks,
>
> Likitha Shetty
>
>
Re: Review Request: Unable to edit a Sub domain
Posted by Rohit Yadav <bh...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8547/#review15910
-----------------------------------------------------------
Thanks, committed on master:
commit 99556a4f30865081ee58825a37f52d8cedab185b
Author: Likitha Shetty <li...@citrix.com>
Date: Wed Dec 12 17:42:04 2012 +0530
CLOUDSTACK-617: Unable to edit a sub-domain. Change UpdateDomain to be consistent with CreateDomain i.e. before this operation, while che
Signed-off-by: Rohit Yadav <bh...@apache.org>
- Rohit Yadav
On Dec. 12, 2012, 12:59 p.m., Likitha Shetty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8547/
> -----------------------------------------------------------
>
> (Updated Dec. 12, 2012, 12:59 p.m.)
>
>
> Review request for cloudstack and Alena Prokharchyk.
>
>
> Description
> -------
>
> UpdateDomain to be consistent with CreateDomain i.e. before this operation, while checking if the domain-name is unique, search under the parent domain instead of searching under the ROOT domain.
>
>
> This addresses bug CLOUDSTACK-617.
>
>
> Diffs
> -----
>
> server/src/com/cloud/server/ManagementServerImpl.java 117be57
>
> Diff: https://reviews.apache.org/r/8547/diff/
>
>
> Testing
> -------
>
> Created this tree of domains
>
> ROOT
> india
> dev
> prod
> us
> dev
> prod
>
> Each domain has 2 subdomains "dev" and "prod".
> Able to successfully edit 'network' domain (other fields as well).
>
>
> Thanks,
>
> Likitha Shetty
>
>