[GitHub] [kylin] nichunen commented on a change in pull request #687: Kylin-4037 Fix can't Cleanup Data in Hbase's HDFS Storage When Deploy Apache Kylin with Standalone HBase Cluster

[GitBox <gi...@apache.org>]

nichunen commented on a change in pull request #687: Kylin-4037 Fix can't Cleanup Data in Hbase's HDFS Storage When Deploy Apache Kylin with Standalone HBase Cluster
URL: https://github.com/apache/kylin/pull/687#discussion_r303234041
 
 

 ##########
 File path: server-base/src/main/java/org/apache/kylin/rest/job/StorageCleanupJob.java
 ##########
 @@ -217,25 +217,24 @@ private void cleanUnusedHdfsFiles() throws IOException {
     
     protected void collectUnusedHdfsFiles(UnusedHdfsFileCollector collector) throws IOException {
         if (StringUtils.isNotEmpty(config.getHBaseClusterFs())) {
-            cleanUnusedHdfsFiles(hbaseFs, collector);
+            cleanUnusedHdfsFiles(hbaseFs, collector, true);
         }
-        cleanUnusedHdfsFiles(defaultFs, collector);
+        cleanUnusedHdfsFiles(defaultFs, collector, false);
 
 Review comment:
   Why should run cleanUnusedHdfsFiles twice if config.getHBaseClusterFs() is not empty?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services