You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by se...@apache.org on 2010/09/12 14:47:54 UTC

svn commit: r996304 - in /commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils: BeanMapTestCase.java DynaPropertyUtilsTestCase.java LazyDynaListTestCase.java

Author: sebb
Date: Sun Sep 12 12:47:53 2010
New Revision: 996304

URL: http://svn.apache.org/viewvc?rev=996304&view=rev
Log:
Unnecessary casts

Modified:
    commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/BeanMapTestCase.java
    commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/DynaPropertyUtilsTestCase.java
    commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/LazyDynaListTestCase.java

Modified: commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/BeanMapTestCase.java
URL: http://svn.apache.org/viewvc/commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/BeanMapTestCase.java?rev=996304&r1=996303&r2=996304&view=diff
==============================================================================
--- commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/BeanMapTestCase.java (original)
+++ commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/BeanMapTestCase.java Sun Sep 12 12:47:53 2010
@@ -328,7 +328,7 @@ public class BeanMapTestCase extends Abs
     public void testBeanMapClone() {
         BeanMap map = (BeanMap)makeFullMap();
         try {
-            BeanMap map2 = (BeanMap)((BeanMap)map).clone();
+            BeanMap map2 = (BeanMap)map.clone();
 
             // make sure containsKey is working to verify the bean was cloned
             // ok, and the read methods were properly initialized

Modified: commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/DynaPropertyUtilsTestCase.java
URL: http://svn.apache.org/viewvc/commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/DynaPropertyUtilsTestCase.java?rev=996304&r1=996303&r2=996304&view=diff
==============================================================================
--- commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/DynaPropertyUtilsTestCase.java (original)
+++ commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/DynaPropertyUtilsTestCase.java Sun Sep 12 12:47:53 2010
@@ -1443,7 +1443,7 @@ public class DynaPropertyUtilsTestCase e
         } catch (NoSuchMethodException e) {
             // Correct result for this test
             assertEquals("Unknown property 'unknown' on dynaclass '" +
-                         ((DynaBean) bean).getDynaClass() + "'", e.getMessage() );
+                         bean.getDynaClass() + "'", e.getMessage() );
         }
 
     }
@@ -2595,7 +2595,7 @@ public class DynaPropertyUtilsTestCase e
         } catch (NoSuchMethodException e) {
             // Correct result for this test
             assertEquals("Unknown property 'unknown' on dynaclass '" +
-                         ((DynaBean) bean).getDynaClass() + "'", e.getMessage() );
+                         bean.getDynaClass() + "'", e.getMessage() );
         }
 
     }

Modified: commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/LazyDynaListTestCase.java
URL: http://svn.apache.org/viewvc/commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/LazyDynaListTestCase.java?rev=996304&r1=996303&r2=996304&view=diff
==============================================================================
--- commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/LazyDynaListTestCase.java (original)
+++ commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/LazyDynaListTestCase.java Sun Sep 12 12:47:53 2010
@@ -306,7 +306,7 @@ public class LazyDynaListTestCase extend
 
         // Test Insert - add(index, Object)
         try {
-            DynaBean extraElement = (DynaBean)testDynaClass.newInstance();
+            DynaBean extraElement = testDynaClass.newInstance();
             extraElement.set(testProperty, "extraOne");
             list.add(2, extraElement);
             dynaArray = list.toDynaBeanArray();