You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "errose28 (via GitHub)" <gi...@apache.org> on 2026/07/13 20:03:25 UTC

[PR] HDDS-15848. Add new upgrade action annotations for component versions [ozone]

errose28 opened a new pull request, #10744:
URL: https://github.com/apache/ozone/pull/10744

   ## What changes were proposed in this pull request?
   
   The existing upgrade action annotations only had layout feature fields. Annotation fields cannot be an interface like `ComponentVersion`, so create a new set of annotations to be used for upgrade actions mapped to ComponentVersions going forward. The annotations were given more descriptive names as follows:
   ```
   UpgradeAction{Om,SCM,Datanode} → {Om,SCM,Datanode}UpgradeActionForLayoutFeature, {Om,SCM,Datanode}UpgradeActionForVersion
   ```
   
   On the ZDU branch Recon's upgrade actions had been switched from LayoutFeature to ComponentVersion since it did not use both versions simultaneously. This means Recon now only needs `ReconUpgradeActionForVersion` and no `ReconUpgradeActionForLayoutFeature` was created.
   
   Upgrade action providers were modified to load both annotations.
   
   ## What is the link to the Apache JIRA
   
   HDDS-15848
   
   ## How was this patch tested?
   
   Unit tests for the new annotations with mocked upgrade actions were added since there are currently no real upgrade actions mapped to ComponentVersions. Once there are actions added for new versions the mocks can be removed, potentially as part of HDDS-14754. Existing tests for actions mapped to layout features should continue to pass.
   
   Pending CI on my [fork](https://github.com/errose28/ozone/actions/runs/29276516240/job/86909928241)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


Re: [PR] HDDS-15848. Add new upgrade action annotations for component versions [ozone]

Posted by "errose28 (via GitHub)" <gi...@apache.org>.
errose28 merged PR #10744:
URL: https://github.com/apache/ozone/pull/10744


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


Re: [PR] HDDS-15848. Add new upgrade action annotations for component versions [ozone]

Posted by "errose28 (via GitHub)" <gi...@apache.org>.
errose28 commented on PR #10744:
URL: https://github.com/apache/ozone/pull/10744#issuecomment-4994283503

   The acceptance test failure is unrelated and fixed on master. I'm going to merge this to the feature branch and bring the latest master in to the feature branch soon.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org