You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@harmony.apache.org by "Stepan Mishura (JIRA)" <ji...@apache.org> on 2006/02/27 08:49:04 UTC
[jira] Created: (HARMONY-138) 2 regression tests for URLConnection
class should be network independent
2 regression tests for URLConnection class should be network independent
------------------------------------------------------------------------
Key: HARMONY-138
URL: http://issues.apache.org/jira/browse/HARMONY-138
Project: Harmony
Type: Bug
Reporter: Stepan Mishura
Priority: Minor
There are two regression tests for URLConnection class:
- HARMONY-71: test_setUseCachesZ
- HARMONY-72: test_setAllowUserInteractionZ
They may fail because depend on network connection. It is possible to fix these tests to avoid dependency on connection because they verify URLConnection object state only and opened connections are not used by tests. Also tests should verify URLConnection class code rather then a default implementation of HttpURLConnection class because tested method may be overridden by default implementation.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-138) 2 regression tests for URLConnection
class should be network independent
Posted by "Stepan Mishura (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-138?page=all ]
Stepan Mishura updated HARMONY-138:
-----------------------------------
Attachment: fixURLConnectionTest.txt
A patch is attached
> 2 regression tests for URLConnection class should be network independent
> ------------------------------------------------------------------------
>
> Key: HARMONY-138
> URL: http://issues.apache.org/jira/browse/HARMONY-138
> Project: Harmony
> Type: Bug
> Reporter: Stepan Mishura
> Priority: Minor
> Attachments: fixURLConnectionTest.txt
>
> There are two regression tests for URLConnection class:
> - HARMONY-71: test_setUseCachesZ
> - HARMONY-72: test_setAllowUserInteractionZ
> They may fail because depend on network connection. It is possible to fix these tests to avoid dependency on connection because they verify URLConnection object state only and opened connections are not used by tests. Also tests should verify URLConnection class code rather then a default implementation of HttpURLConnection class because tested method may be overridden by default implementation.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Resolved: (HARMONY-138) 2 regression tests for URLConnection
class should be network independent
Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-138?page=all ]
Tim Ellison resolved HARMONY-138:
---------------------------------
Resolution: Fixed
Thanks Stepan.
A sneaky hack! I like your style ;-)
Applied to LUNI module org.apache.harmony.tests.java.net.URLConnectionTest at repo revision 381337.
Please check it was applied as you expected.
> 2 regression tests for URLConnection class should be network independent
> ------------------------------------------------------------------------
>
> Key: HARMONY-138
> URL: http://issues.apache.org/jira/browse/HARMONY-138
> Project: Harmony
> Type: Bug
> Components: Classlib
> Reporter: Stepan Mishura
> Assignee: Tim Ellison
> Priority: Minor
> Attachments: fixURLConnectionTest.txt
>
> There are two regression tests for URLConnection class:
> - HARMONY-71: test_setUseCachesZ
> - HARMONY-72: test_setAllowUserInteractionZ
> They may fail because depend on network connection. It is possible to fix these tests to avoid dependency on connection because they verify URLConnection object state only and opened connections are not used by tests. Also tests should verify URLConnection class code rather then a default implementation of HttpURLConnection class because tested method may be overridden by default implementation.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Assigned: (HARMONY-138) 2 regression tests for URLConnection
class should be network independent
Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-138?page=all ]
Tim Ellison reassigned HARMONY-138:
-----------------------------------
Assign To: Tim Ellison
> 2 regression tests for URLConnection class should be network independent
> ------------------------------------------------------------------------
>
> Key: HARMONY-138
> URL: http://issues.apache.org/jira/browse/HARMONY-138
> Project: Harmony
> Type: Bug
> Components: Classlib
> Reporter: Stepan Mishura
> Assignee: Tim Ellison
> Priority: Minor
> Attachments: fixURLConnectionTest.txt
>
> There are two regression tests for URLConnection class:
> - HARMONY-71: test_setUseCachesZ
> - HARMONY-72: test_setAllowUserInteractionZ
> They may fail because depend on network connection. It is possible to fix these tests to avoid dependency on connection because they verify URLConnection object state only and opened connections are not used by tests. Also tests should verify URLConnection class code rather then a default implementation of HttpURLConnection class because tested method may be overridden by default implementation.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-138) 2 regression tests for
URLConnection class should be network independent
Posted by "Stepan Mishura (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-138?page=comments#action_12367953 ]
Stepan Mishura commented on HARMONY-138:
----------------------------------------
Ok with the fix
> 2 regression tests for URLConnection class should be network independent
> ------------------------------------------------------------------------
>
> Key: HARMONY-138
> URL: http://issues.apache.org/jira/browse/HARMONY-138
> Project: Harmony
> Type: Bug
> Components: Classlib
> Reporter: Stepan Mishura
> Assignee: Tim Ellison
> Priority: Minor
> Attachments: fixURLConnectionTest.txt
>
> There are two regression tests for URLConnection class:
> - HARMONY-71: test_setUseCachesZ
> - HARMONY-72: test_setAllowUserInteractionZ
> They may fail because depend on network connection. It is possible to fix these tests to avoid dependency on connection because they verify URLConnection object state only and opened connections are not used by tests. Also tests should verify URLConnection class code rather then a default implementation of HttpURLConnection class because tested method may be overridden by default implementation.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Closed: (HARMONY-138) 2 regression tests for URLConnection
class should be network independent
Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-138?page=all ]
Tim Ellison closed HARMONY-138:
-------------------------------
Verified by Stepan.
> 2 regression tests for URLConnection class should be network independent
> ------------------------------------------------------------------------
>
> Key: HARMONY-138
> URL: http://issues.apache.org/jira/browse/HARMONY-138
> Project: Harmony
> Type: Bug
> Components: Classlib
> Reporter: Stepan Mishura
> Assignee: Tim Ellison
> Priority: Minor
> Attachments: fixURLConnectionTest.txt
>
> There are two regression tests for URLConnection class:
> - HARMONY-71: test_setUseCachesZ
> - HARMONY-72: test_setAllowUserInteractionZ
> They may fail because depend on network connection. It is possible to fix these tests to avoid dependency on connection because they verify URLConnection object state only and opened connections are not used by tests. Also tests should verify URLConnection class code rather then a default implementation of HttpURLConnection class because tested method may be overridden by default implementation.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-138) 2 regression tests for URLConnection
class should be network independent
Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-138?page=all ]
Tim Ellison updated HARMONY-138:
--------------------------------
Component: Classlib
> 2 regression tests for URLConnection class should be network independent
> ------------------------------------------------------------------------
>
> Key: HARMONY-138
> URL: http://issues.apache.org/jira/browse/HARMONY-138
> Project: Harmony
> Type: Bug
> Components: Classlib
> Reporter: Stepan Mishura
> Priority: Minor
> Attachments: fixURLConnectionTest.txt
>
> There are two regression tests for URLConnection class:
> - HARMONY-71: test_setUseCachesZ
> - HARMONY-72: test_setAllowUserInteractionZ
> They may fail because depend on network connection. It is possible to fix these tests to avoid dependency on connection because they verify URLConnection object state only and opened connections are not used by tests. Also tests should verify URLConnection class code rather then a default implementation of HttpURLConnection class because tested method may be overridden by default implementation.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira