You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2020/05/05 09:44:36 UTC
[GitHub] [trafficserver] maskit opened a new pull request #6736: Generalize callbacks for TLS session resumption
maskit opened a new pull request #6736:
URL: https://github.com/apache/trafficserver/pull/6736
Callback functions for session resumption were not usable with QUICNetVC because
those expect that Session Resumption is used only on SSLNetVC.
This commit introduces TLSSessionResumptionSupport that helps supporting Session
Resumption and provides generalized interface to remove the direct dependency
for SSLNetVC. Adding support for session resumption on QUIC would be like https://github.com/maskit/trafficserver/commit/71aef65086e0b0dc2481c1a1cdc859622ad1ae57
Also, by ensuring a pointer stored in SSL application specific data is always
TLSSessionResumptionSupport, it removes a use of dynamic_cast.
It looks like a big change but I just moved functions into TLSSessionResumptionSupport and introduced another index for SSL application data. I could move a couple of more functions into the class, and maybe I should, but I didn't move those unnecessarily to make change minimal.
This contains removing ssl_session_ticket_index, which is proposed on #6735. I would need to rebase this after merging #6735.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] zwoop commented on pull request #6736: Generalize callbacks for TLS session resumption
Posted by GitBox <gi...@apache.org>.
zwoop commented on pull request #6736:
URL: https://github.com/apache/trafficserver/pull/6736#issuecomment-634847947
Cherry-picked to v9.0.x branch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] randall removed a comment on pull request #6736: Generalize callbacks for TLS session resumption
Posted by GitBox <gi...@apache.org>.
randall removed a comment on pull request #6736:
URL: https://github.com/apache/trafficserver/pull/6736#issuecomment-628262172
[approve ci clang-analyzer]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] maskit commented on pull request #6736: Generalize callbacks for TLS session resumption
Posted by GitBox <gi...@apache.org>.
maskit commented on pull request #6736:
URL: https://github.com/apache/trafficserver/pull/6736#issuecomment-628280973
[approve ci clang-analyzer]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] randall commented on pull request #6736: Generalize callbacks for TLS session resumption
Posted by GitBox <gi...@apache.org>.
randall commented on pull request #6736:
URL: https://github.com/apache/trafficserver/pull/6736#issuecomment-628262172
[approve ci clang-analyzer]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] a-canary commented on pull request #6736: Generalize callbacks for TLS session resumption
Posted by GitBox <gi...@apache.org>.
a-canary commented on pull request #6736:
URL: https://github.com/apache/trafficserver/pull/6736#issuecomment-639725957
I'm seeing this fail autest tls.test.py. Can anyone confirm?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] maskit commented on pull request #6736: Generalize callbacks for TLS session resumption
Posted by GitBox <gi...@apache.org>.
maskit commented on pull request #6736:
URL: https://github.com/apache/trafficserver/pull/6736#issuecomment-628281072
[approve ci autest]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] maskit merged pull request #6736: Generalize callbacks for TLS session resumption
Posted by GitBox <gi...@apache.org>.
maskit merged pull request #6736:
URL: https://github.com/apache/trafficserver/pull/6736
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] maskit commented on pull request #6736: Generalize callbacks for TLS session resumption
Posted by GitBox <gi...@apache.org>.
maskit commented on pull request #6736:
URL: https://github.com/apache/trafficserver/pull/6736#issuecomment-628301842
The only change I made since the last review is fixing a typo. And it dismissed the reviews, unfortunately.
There are docs about ssl_session_reuse plugin and the API it uses but I couldn't find docs that describes internal implementation. Please let me know if you find it. I'll be happy to update it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org