You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@gluten.apache.org by "zhouyuan (via GitHub)" <gi...@apache.org> on 2024/05/10 12:50:36 UTC

[PR] [GLUTEN-4917][VL] CI adding TPCDS benchmark [incubator-gluten]

zhouyuan opened a new pull request, #5693:
URL: https://github.com/apache/incubator-gluten/pull/5693

   ## What changes were proposed in this pull request?
   
   Adding TPCDS benchmarks on comment
   
   ## How was this patch tested?
   
   pass GHA
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org


Re: [PR] [GLUTEN-4917][VL] CI adding TPCDS benchmark [incubator-gluten]

Posted by "jinchengchenghh (via GitHub)" <gi...@apache.org>.
jinchengchenghh commented on code in PR #5693:
URL: https://github.com/apache/incubator-gluten/pull/5693#discussion_r1597380951


##########
.github/workflows/velox_tpch_bench.yml:
##########
@@ -40,3 +40,18 @@ jobs:
         run: |
           branchname=origin/pr/${{ github.event.issue.number }}/head
           curl --noproxy $JENKINS_HOST -L -X POST http://$JENKINS_HOST:$JENKINS_PORT/job/Gluten_Perf_Github_Action_Check/build --user $JENKINS_USER --data-urlencode json='{"parameter": [{"name":"sha1", "value":"'$branchname'"}]}'
+  velox-trigger-tpcds-on-comment:
+    # check the comment if it contains the keywords
+    if: ${{ github.event.issue.pull_request && contains(github.event.comment.body, '/Benchmark Velox TPCDS') }}
+    runs-on: velox-self-hosted
+    container: ubuntu:22.04
+    steps:
+      - uses: actions/checkout@v4
+      - run: apt-get update && apt-get install ca-certificates -y && update-ca-certificates
+      - run: sed -i 's/http\:\/\/archive.ubuntu.com/https\:\/\/mirrors.ustc.edu.cn/g' /etc/apt/sources.list
+      - run: apt-get update
+      - run: apt-get install -y curl
+      - name: trigger_tpch_bench

Review Comment:
   please update the name to `trigger_tpcds_bench`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org


Re: [PR] [GLUTEN-4917][VL] CI adding TPCDS benchmark [incubator-gluten]

Posted by "Yohahaha (via GitHub)" <gi...@apache.org>.
Yohahaha commented on PR #5693:
URL: https://github.com/apache/incubator-gluten/pull/5693#issuecomment-2104620180

   thank you and curious does the new benchmark is run with partitioned table?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org


Re: [PR] [GLUTEN-4917][VL] CI adding TPCDS benchmark [incubator-gluten]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5693:
URL: https://github.com/apache/incubator-gluten/pull/5693#issuecomment-2104555224

   https://github.com/apache/incubator-gluten/issues/4917


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org


Re: [PR] [GLUTEN-4917][VL] CI adding TPCDS benchmark [incubator-gluten]

Posted by "PHILO-HE (via GitHub)" <gi...@apache.org>.
PHILO-HE merged PR #5693:
URL: https://github.com/apache/incubator-gluten/pull/5693


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org


Re: [PR] [GLUTEN-4917][VL] CI adding TPCDS benchmark [incubator-gluten]

Posted by "zhouyuan (via GitHub)" <gi...@apache.org>.
zhouyuan commented on PR #5693:
URL: https://github.com/apache/incubator-gluten/pull/5693#issuecomment-2105396329

   Hi yang, thanks for your interest, yes it will benchmark with TPCDS SF2000 with partitioned dataset. Please note the server is from intel PRC lab and it's not very stable due to GitHub connections issues.
   
   thanks,
   -yuan
   
   
   ________________________________
   From: Yang Zhang ***@***.***>
   Sent: Friday, May 10, 2024 9:33 PM
   To: apache/incubator-gluten ***@***.***>
   Cc: Yuan ***@***.***>; Author ***@***.***>
   Subject: Re: [apache/incubator-gluten] [GLUTEN-4917][VL] CI adding TPCDS benchmark (PR #5693)
   
   
   thank you and curious does the new benchmark is run with partitioned table?
   
   —
   Reply to this email directly, view it on GitHub<https://github.com/apache/incubator-gluten/pull/5693#issuecomment-2104620180>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAAKXDJSCWGZ4DTANFT72FTZBTEDPAVCNFSM6AAAAABHQSRPCSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBUGYZDAMJYGA>.
   You are receiving this because you authored the thread.Message ID: ***@***.***>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org