You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/02/18 12:28:12 UTC
[GitHub] [incubator-shardingsphere] sluk3r opened a new pull request #4359:
for issue 4357
sluk3r opened a new pull request #4359: for issue 4357
URL: https://github.com/apache/incubator-shardingsphere/pull/4359
Fixes #4357
Changes proposed in this pull request:
- delete the unused line: when(insertStatement.findSQLSegment(LimitSegment.class)).thenReturn(Optional.of(new LimitSegment(0, 10, null, null)));
- for InsertStatement object, use "new InsertStatement()" instead of "mock(InsertStatement.class)", and other mocked methods setup are also deleted.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu merged pull request #4359: for
issue 4357
Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #4359: for issue 4357
URL: https://github.com/apache/incubator-shardingsphere/pull/4359
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull
request #4359: for issue 4357
Posted by GitBox <gi...@apache.org>.
terrymanu commented on a change in pull request #4359: for issue 4357
URL: https://github.com/apache/incubator-shardingsphere/pull/4359#discussion_r380700666
##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-relation/src/test/java/org/apache/shardingsphere/sql/parser/relation/statement/SQLStatementContextFactoryTest.java
##########
@@ -1,3 +1,7 @@
+
+
+
+
Review comment:
Please remove useless blank lines
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4359: for
issue 4357
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #4359: for issue 4357
URL: https://github.com/apache/incubator-shardingsphere/pull/4359#issuecomment-589049112
## Pull Request Test Coverage Report for [Build 9675](https://coveralls.io/builds/28854682)
* **0** of **0** changed or added relevant lines in **0** files are covered.
* **4** unchanged lines in **2** files lost coverage.
* Overall coverage decreased (**-0.01%**) to **56.637%**
---
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [sharding-orchestration/sharding-orchestration-center/sharding-orchestration-center-apollo/src/main/java/org/apache/shardingsphere/orchestration/center/instance/ApolloInstance.java](https://coveralls.io/builds/28854682/source?filename=sharding-orchestration%2Fsharding-orchestration-center%2Fsharding-orchestration-center-apollo%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcenter%2Finstance%2FApolloInstance.java#L117) | 1 | 59.46% |
| [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java](https://coveralls.io/builds/28854682/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Futil%2FIpUtils.java#L63) | 3 | 76.0% |
<!-- | **Total:** | **4** | | -->
| Totals | [](https://coveralls.io/builds/28854682) |
| :-- | --: |
| Change from base [Build 894](https://coveralls.io/builds/28852262): | -0.01% |
| Covered Lines: | 11029 |
| Relevant Lines: | 19473 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull
request #4359: for issue 4357
Posted by GitBox <gi...@apache.org>.
terrymanu commented on a change in pull request #4359: for issue 4357
URL: https://github.com/apache/incubator-shardingsphere/pull/4359#discussion_r380701578
##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-relation/src/test/java/org/apache/shardingsphere/sql/parser/relation/statement/SQLStatementContextFactoryTest.java
##########
@@ -1,3 +1,7 @@
+
+
+
+
Review comment:
Please remove useless blank lines
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services