You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Prashant Kommireddi (JIRA)" <ji...@apache.org> on 2012/10/22 10:24:12 UTC
[jira] [Created] (PIG-2997) Provide a convenience constructor on
PigServer that accepts Configuration
Prashant Kommireddi created PIG-2997:
----------------------------------------
Summary: Provide a convenience constructor on PigServer that accepts Configuration
Key: PIG-2997
URL: https://issues.apache.org/jira/browse/PIG-2997
Project: Pig
Issue Type: Improvement
Reporter: Prashant Kommireddi
Assignee: Prashant Kommireddi
Fix For: 0.11
Attachments: PIG-2997.patch
PigServer currently has Properties based constructor. Hadoop in general deals with Configuration and it would be good to have a PigServer constructor that accepts the same. With this, user does not have to worry about creating Properties object out of conf and can simply invoke this new constructor.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-2997) Provide a convenience constructor on
PigServer that accepts Configuration
Posted by "Prashant Kommireddi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Prashant Kommireddi updated PIG-2997:
-------------------------------------
Attachment: PIG-2997_1.patch
Thanks for the review Rohini.
Adding a test case. Also, I have moved the Configuration->Properties switch into PigContext so stuff other than PigServer can use it too.
> Provide a convenience constructor on PigServer that accepts Configuration
> -------------------------------------------------------------------------
>
> Key: PIG-2997
> URL: https://issues.apache.org/jira/browse/PIG-2997
> Project: Pig
> Issue Type: Improvement
> Reporter: Prashant Kommireddi
> Assignee: Prashant Kommireddi
> Fix For: 0.11
>
> Attachments: PIG-2997_1.patch, PIG-2997.patch
>
>
> PigServer currently has Properties based constructor. Hadoop in general deals with Configuration and it would be good to have a PigServer constructor that accepts the same. With this, user does not have to worry about creating Properties object out of conf and can simply invoke this new constructor.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-2997) Provide a convenience constructor on
PigServer that accepts Configuration
Posted by "Rohini Palaniswamy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13486532#comment-13486532 ]
Rohini Palaniswamy commented on PIG-2997:
-----------------------------------------
Prashant,
I did not mean that you need to write a unit test for this. It would be overkill :). Sorry for not being clear. There are already unit tests which use ConfigurationUtil.toProperties() - TestHBaseStorage.beforeTest() and TestFRJoin.FRJoin.setUpHashTable(). It would be good if you can change those existing tests to use your new API instead of a new test.
> Provide a convenience constructor on PigServer that accepts Configuration
> -------------------------------------------------------------------------
>
> Key: PIG-2997
> URL: https://issues.apache.org/jira/browse/PIG-2997
> Project: Pig
> Issue Type: Improvement
> Reporter: Prashant Kommireddi
> Assignee: Prashant Kommireddi
> Fix For: 0.11
>
> Attachments: PIG-2997_1.patch, PIG-2997.patch
>
>
> PigServer currently has Properties based constructor. Hadoop in general deals with Configuration and it would be good to have a PigServer constructor that accepts the same. With this, user does not have to worry about creating Properties object out of conf and can simply invoke this new constructor.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-2997) Provide a convenience constructor on
PigServer that accepts Configuration
Posted by "Prashant Kommireddi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Prashant Kommireddi updated PIG-2997:
-------------------------------------
Attachment: PIG-2997_2.patch
Rohini, uploading a new test patch. I have also cleaned up some code in TestHBaseStorage and TestFRJoin which had some unused imports and variables. Tests pass.
> Provide a convenience constructor on PigServer that accepts Configuration
> -------------------------------------------------------------------------
>
> Key: PIG-2997
> URL: https://issues.apache.org/jira/browse/PIG-2997
> Project: Pig
> Issue Type: Improvement
> Reporter: Prashant Kommireddi
> Assignee: Prashant Kommireddi
> Fix For: 0.11
>
> Attachments: PIG-2997_1.patch, PIG-2997_2.patch, PIG-2997.patch
>
>
> PigServer currently has Properties based constructor. Hadoop in general deals with Configuration and it would be good to have a PigServer constructor that accepts the same. With this, user does not have to worry about creating Properties object out of conf and can simply invoke this new constructor.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-2997) Provide a convenience constructor on
PigServer that accepts Configuration
Posted by "Prashant Kommireddi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Prashant Kommireddi updated PIG-2997:
-------------------------------------
Attachment: PIG-2997.patch
> Provide a convenience constructor on PigServer that accepts Configuration
> -------------------------------------------------------------------------
>
> Key: PIG-2997
> URL: https://issues.apache.org/jira/browse/PIG-2997
> Project: Pig
> Issue Type: Improvement
> Reporter: Prashant Kommireddi
> Assignee: Prashant Kommireddi
> Fix For: 0.11
>
> Attachments: PIG-2997.patch
>
>
> PigServer currently has Properties based constructor. Hadoop in general deals with Configuration and it would be good to have a PigServer constructor that accepts the same. With this, user does not have to worry about creating Properties object out of conf and can simply invoke this new constructor.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (PIG-2997) Provide a convenience constructor on
PigServer that accepts Configuration
Posted by "Rohini Palaniswamy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rohini Palaniswamy resolved PIG-2997.
-------------------------------------
Resolution: Fixed
Fix Version/s: (was: 0.11)
0.12
Committed to trunk. Thanks Prashant.
> Provide a convenience constructor on PigServer that accepts Configuration
> -------------------------------------------------------------------------
>
> Key: PIG-2997
> URL: https://issues.apache.org/jira/browse/PIG-2997
> Project: Pig
> Issue Type: Improvement
> Reporter: Prashant Kommireddi
> Assignee: Prashant Kommireddi
> Fix For: 0.12
>
> Attachments: PIG-2997_1.patch, PIG-2997_2.patch, PIG-2997.patch
>
>
> PigServer currently has Properties based constructor. Hadoop in general deals with Configuration and it would be good to have a PigServer constructor that accepts the same. With this, user does not have to worry about creating Properties object out of conf and can simply invoke this new constructor.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-2997) Provide a convenience constructor on
PigServer that accepts Configuration
Posted by "Prashant Kommireddi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13486536#comment-13486536 ]
Prashant Kommireddi commented on PIG-2997:
------------------------------------------
I knew what you meant but wanted to keep my changes isolated. Wasn't a huge deal to add a 10 line test case. But I will change the above mentioned tests to re-use this.
> Provide a convenience constructor on PigServer that accepts Configuration
> -------------------------------------------------------------------------
>
> Key: PIG-2997
> URL: https://issues.apache.org/jira/browse/PIG-2997
> Project: Pig
> Issue Type: Improvement
> Reporter: Prashant Kommireddi
> Assignee: Prashant Kommireddi
> Fix For: 0.11
>
> Attachments: PIG-2997_1.patch, PIG-2997.patch
>
>
> PigServer currently has Properties based constructor. Hadoop in general deals with Configuration and it would be good to have a PigServer constructor that accepts the same. With this, user does not have to worry about creating Properties object out of conf and can simply invoke this new constructor.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-2997) Provide a convenience constructor on
PigServer that accepts Configuration
Posted by "Rohini Palaniswamy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13485450#comment-13485450 ]
Rohini Palaniswamy commented on PIG-2997:
-----------------------------------------
Good utility method. Could you also change unit tests to use it?
> Provide a convenience constructor on PigServer that accepts Configuration
> -------------------------------------------------------------------------
>
> Key: PIG-2997
> URL: https://issues.apache.org/jira/browse/PIG-2997
> Project: Pig
> Issue Type: Improvement
> Reporter: Prashant Kommireddi
> Assignee: Prashant Kommireddi
> Fix For: 0.11
>
> Attachments: PIG-2997.patch
>
>
> PigServer currently has Properties based constructor. Hadoop in general deals with Configuration and it would be good to have a PigServer constructor that accepts the same. With this, user does not have to worry about creating Properties object out of conf and can simply invoke this new constructor.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira