You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/03/01 00:55:04 UTC
[GitHub] [airflow] uranusjr opened a new pull request #21882: Enhance magic methods on XComArg for UX
uranusjr opened a new pull request #21882:
URL: https://github.com/apache/airflow/pull/21882
See #21853. We can do better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #21882: Enhance magic methods on XComArg for UX
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #21882:
URL: https://github.com/apache/airflow/pull/21882#issuecomment-1057820818
random ci failure. Merging
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] malthe commented on pull request #21882: Enhance magic methods on XComArg for UX
Posted by GitBox <gi...@apache.org>.
malthe commented on pull request #21882:
URL: https://github.com/apache/airflow/pull/21882#issuecomment-1056873692
```python
>>> class A:
... def __getitem__(self, name): print name; return repr(name)
...
>>> a = A()
>>> next(iter(a))
0
'0'
```
OK that is surprising. Unexpected Python magic!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #21882: Enhance magic methods on XComArg for UX
Posted by GitBox <gi...@apache.org>.
uranusjr commented on pull request #21882:
URL: https://github.com/apache/airflow/pull/21882#issuecomment-1057585737
Tests added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #21882: Enhance magic methods on XComArg for UX
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #21882:
URL: https://github.com/apache/airflow/pull/21882#issuecomment-1056886599
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #21882: Enhance magic methods on XComArg for UX
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #21882:
URL: https://github.com/apache/airflow/pull/21882#issuecomment-1057309848
> Should we add tests?
Actually two short tests generating the exceptions would be nice :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #21882: Enhance magic methods on XComArg for UX
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #21882:
URL: https://github.com/apache/airflow/pull/21882
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org