You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/01/23 02:06:03 UTC

[GitHub] [superset] ktmud opened a new pull request #12705: feat(explore): allow opening charts with missing dataset

ktmud opened a new pull request #12705:
URL: https://github.com/apache/superset/pull/12705


   ### SUMMARY
   
   Allow opening charts with missing dataset as proposed in https://github.com/apache/superset/issues/12464#issuecomment-758895950. Alternative solution for #12468 .
   
   Also did some refactoring on `get_datasource` error handling.
   
   Closes #12464 
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   #### Before
   
   Opening a chart with missing dataset redirects to chart list with a flash message.
   
   #### After
   
   <img width="1249" alt="show-missing-dataset" src="https://user-images.githubusercontent.com/335541/105565553-3663c200-5cdc-11eb-8a20-83c9b51e645b.png">
   
   Chart can open, all control params retained; users are offered a way to quickly switch to a valid dataset.
   
   ### TEST PLAN
   
   Manual
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [x] Has associated issue: see SUMMARY
   - [x] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov-io edited a comment on pull request #12705: feat(explore): allow opening charts with missing dataset

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12705:
URL: https://github.com/apache/superset/pull/12705#issuecomment-765819050


   # [Codecov](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=h1) Report
   > Merging [#12705](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=desc) (919c7bc) into [master](https://codecov.io/gh/apache/superset/commit/0f8a62babf9bbff6ff53d835f77322d6563b5739?el=desc) (0f8a62b) will **decrease** coverage by `8.79%`.
   > The diff coverage is `62.50%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/12705/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12705      +/-   ##
   ==========================================
   - Coverage   59.37%   50.57%   -8.80%     
   ==========================================
     Files         962      475     -487     
     Lines       47037    17029   -30008     
     Branches     4387     4392       +5     
   ==========================================
   - Hits        27927     8612   -19315     
   + Misses      19110     8417   -10693     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `50.57% <62.50%> (-0.37%)` | :arrow_down: |
   | python | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/common/components/index.tsx](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
   | [...perset-frontend/src/explore/components/Control.tsx](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sLnRzeA==) | `100.00% <ø> (ø)` | |
   | [.../explore/components/controls/DatasourceControl.jsx](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRhc291cmNlQ29udHJvbC5qc3g=) | `60.00% <40.00%> (-1.02%)` | :arrow_down: |
   | [...rontend/src/explore/components/DatasourcePanel.tsx](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhc291cmNlUGFuZWwudHN4) | `80.95% <100.00%> (+0.95%)` | :arrow_up: |
   | [...et-frontend/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `33.33% <0.00%> (-16.67%)` | :arrow_down: |
   | [superset-frontend/src/reduxUtils.ts](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3JlZHV4VXRpbHMudHM=) | `52.17% <0.00%> (-11.60%)` | :arrow_down: |
   | [...rontend/src/SqlLab/components/TabbedSqlEditors.jsx](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmJlZFNxbEVkaXRvcnMuanN4) | `53.16% <0.00%> (-7.60%)` | :arrow_down: |
   | [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `17.62% <0.00%> (-5.53%)` | :arrow_down: |
   | [superset-frontend/src/SqlLab/reducers/sqlLab.js](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9zcWxMYWIuanM=) | `11.98% <0.00%> (-4.96%)` | :arrow_down: |
   | [superset/utils/dashboard\_import\_export.py](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGFzaGJvYXJkX2ltcG9ydF9leHBvcnQucHk=) | | |
   | ... and [477 more](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=footer). Last update [0f8a62b...67fc121](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov-io edited a comment on pull request #12705: feat(explore): allow opening charts with missing dataset

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12705:
URL: https://github.com/apache/superset/pull/12705#issuecomment-765819050


   # [Codecov](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=h1) Report
   > Merging [#12705](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=desc) (13b6a54) into [master](https://codecov.io/gh/apache/superset/commit/0f8a62babf9bbff6ff53d835f77322d6563b5739?el=desc) (0f8a62b) will **decrease** coverage by `8.80%`.
   > The diff coverage is `62.50%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/12705/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12705      +/-   ##
   ==========================================
   - Coverage   59.37%   50.56%   -8.81%     
   ==========================================
     Files         962      475     -487     
     Lines       47037    17029   -30008     
     Branches     4387     4392       +5     
   ==========================================
   - Hits        27927     8611   -19316     
   + Misses      19110     8418   -10692     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `50.56% <62.50%> (-0.38%)` | :arrow_down: |
   | python | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/common/components/index.tsx](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
   | [...perset-frontend/src/explore/components/Control.tsx](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sLnRzeA==) | `100.00% <ø> (ø)` | |
   | [.../explore/components/controls/DatasourceControl.jsx](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRhc291cmNlQ29udHJvbC5qc3g=) | `60.00% <40.00%> (-1.02%)` | :arrow_down: |
   | [...rontend/src/explore/components/DatasourcePanel.tsx](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhc291cmNlUGFuZWwudHN4) | `80.95% <100.00%> (+0.95%)` | :arrow_up: |
   | [...et-frontend/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `33.33% <0.00%> (-16.67%)` | :arrow_down: |
   | [superset-frontend/src/reduxUtils.ts](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3JlZHV4VXRpbHMudHM=) | `52.17% <0.00%> (-11.60%)` | :arrow_down: |
   | [...rontend/src/SqlLab/components/TabbedSqlEditors.jsx](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmJlZFNxbEVkaXRvcnMuanN4) | `53.16% <0.00%> (-7.60%)` | :arrow_down: |
   | [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `17.62% <0.00%> (-5.53%)` | :arrow_down: |
   | [superset-frontend/src/SqlLab/reducers/sqlLab.js](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9zcWxMYWIuanM=) | `11.98% <0.00%> (-4.96%)` | :arrow_down: |
   | [...set-frontend/src/dashboard/util/getDropPosition.js](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERyb3BQb3NpdGlvbi5qcw==) | `77.77% <0.00%> (ø)` | |
   | ... and [477 more](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=footer). Last update [0f8a62b...2d58d3f](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] ktmud merged pull request #12705: feat(explore): allow opening charts with missing dataset

Posted by GitBox <gi...@apache.org>.
ktmud merged pull request #12705:
URL: https://github.com/apache/superset/pull/12705


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] ktmud commented on pull request #12705: feat(explore): allow opening charts with missing dataset

Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #12705:
URL: https://github.com/apache/superset/pull/12705#issuecomment-767171264






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov-io edited a comment on pull request #12705: feat(explore): allow opening charts with missing dataset

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12705:
URL: https://github.com/apache/superset/pull/12705#issuecomment-765819050






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] ktmud commented on a change in pull request #12705: feat(explore): allow opening charts with missing dataset

Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #12705:
URL: https://github.com/apache/superset/pull/12705#discussion_r563976755



##########
File path: superset-frontend/src/explore/components/controls/DatasourceControl.jsx
##########
@@ -196,6 +207,35 @@ class DatasourceControl extends React.PureComponent {
             </Tooltip>
           </Dropdown>
         </div>
+        {/* missing dataset */}
+        {datasource.id == null && (
+          <div className="error-alert">
+            <ErrorAlert
+              level="warning"
+              title={t('Missing dataset')}
+              source="explore"
+              subtitle={
+                <>
+                  <p>
+                    {t(
+                      'The dataset linked to this chart may have been deleted.',

Review comment:
       My thinking is this: the dataset does not exist for two reasons, either it never existed or has been deleted. Since the latter is the most likely case, we inform users about this possibility, but also show reservations with "may" to be more accurate.
   
   I think a little bit more color in copy is more helpful comparing to repeating the same general message over and over.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov-io edited a comment on pull request #12705: feat(explore): allow opening charts with missing dataset

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12705:
URL: https://github.com/apache/superset/pull/12705#issuecomment-765819050


   # [Codecov](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=h1) Report
   > Merging [#12705](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=desc) (919c7bc) into [master](https://codecov.io/gh/apache/superset/commit/0f8a62babf9bbff6ff53d835f77322d6563b5739?el=desc) (0f8a62b) will **decrease** coverage by `8.42%`.
   > The diff coverage is `62.50%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/12705/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12705      +/-   ##
   ==========================================
   - Coverage   59.37%   50.94%   -8.43%     
   ==========================================
     Files         962      475     -487     
     Lines       47037    17029   -30008     
     Branches     4387     4392       +5     
   ==========================================
   - Hits        27927     8676   -19251     
   + Misses      19110     8353   -10757     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `50.94% <62.50%> (+0.01%)` | :arrow_up: |
   | python | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/common/components/index.tsx](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
   | [...perset-frontend/src/explore/components/Control.tsx](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sLnRzeA==) | `100.00% <ø> (ø)` | |
   | [.../explore/components/controls/DatasourceControl.jsx](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRhc291cmNlQ29udHJvbC5qc3g=) | `60.00% <40.00%> (-1.02%)` | :arrow_down: |
   | [...rontend/src/explore/components/DatasourcePanel.tsx](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhc291cmNlUGFuZWwudHN4) | `80.95% <100.00%> (+0.95%)` | :arrow_up: |
   | [...et/migrations/versions/12d55656cbca\_is\_featured.py](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy8xMmQ1NTY1NmNiY2FfaXNfZmVhdHVyZWQucHk=) | | |
   | [superset/dashboards/schemas.py](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9zY2hlbWFzLnB5) | | |
   | [superset/tasks/alerts/observer.py](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvYWxlcnRzL29ic2VydmVyLnB5) | | |
   | [superset/examples/sf\_population\_polygons.py](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvc2ZfcG9wdWxhdGlvbl9wb2x5Z29ucy5weQ==) | | |
   | [superset/migrations/versions/45e7da7cfeba\_.py](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy80NWU3ZGE3Y2ZlYmFfLnB5) | | |
   | [superset/utils/feature\_flag\_manager.py](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZmVhdHVyZV9mbGFnX21hbmFnZXIucHk=) | | |
   | ... and [472 more](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=footer). Last update [0f8a62b...67fc121](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov-io edited a comment on pull request #12705: feat(explore): allow opening charts with missing dataset

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12705:
URL: https://github.com/apache/superset/pull/12705#issuecomment-765819050


   # [Codecov](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=h1) Report
   > Merging [#12705](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=desc) (04fab5e) into [master](https://codecov.io/gh/apache/superset/commit/51d1b66dcaac1e8f858560ba82ad3fd36d37190a?el=desc) (51d1b66) will **decrease** coverage by `3.50%`.
   > The diff coverage is `77.96%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/12705/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12705      +/-   ##
   ==========================================
   - Coverage   66.88%   63.38%   -3.51%     
   ==========================================
     Files        1022      488     -534     
     Lines       49992    30113   -19879     
     Branches     4892        0    -4892     
   ==========================================
   - Hits        33439    19088   -14351     
   + Misses      16428    11025    -5403     
   + Partials      125        0     -125     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | javascript | `?` | |
   | python | `63.38% <77.96%> (-0.69%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/connectors/druid/views.py](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC92aWV3cy5weQ==) | `69.79% <0.00%> (ø)` | |
   | [superset/datasets/api.py](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `89.49% <ø> (-1.83%)` | :arrow_down: |
   | [superset/views/base.py](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `75.31% <50.00%> (-0.11%)` | :arrow_down: |
   | [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.02% <66.66%> (-0.10%)` | :arrow_down: |
   | [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `71.82% <68.00%> (-3.48%)` | :arrow_down: |
   | [superset/views/datasource.py](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YXNvdXJjZS5weQ==) | `90.16% <71.42%> (+0.76%)` | :arrow_up: |
   | [superset/commands/exceptions.py](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvZXhjZXB0aW9ucy5weQ==) | `91.30% <100.00%> (ø)` | |
   | [superset/commands/utils.py](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvdXRpbHMucHk=) | `100.00% <100.00%> (ø)` | |
   | [superset/connectors/connector\_registry.py](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9jb25uZWN0b3JfcmVnaXN0cnkucHk=) | `86.27% <100.00%> (+1.83%)` | :arrow_up: |
   | [superset/datasets/commands/exceptions.py](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvZXhjZXB0aW9ucy5weQ==) | `92.98% <100.00%> (+0.25%)` | :arrow_up: |
   | ... and [556 more](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=footer). Last update [51d1b66...04fab5e](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov-io edited a comment on pull request #12705: feat(explore): allow opening charts with missing dataset

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12705:
URL: https://github.com/apache/superset/pull/12705#issuecomment-765819050


   # [Codecov](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=h1) Report
   > Merging [#12705](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=desc) (aa350ef) into [master](https://codecov.io/gh/apache/superset/commit/0fed1e04ef8cd09384b1290c7ebad622731b4aca?el=desc) (0fed1e0) will **decrease** coverage by `15.85%`.
   > The diff coverage is `81.81%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/12705/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           master   #12705       +/-   ##
   ===========================================
   - Coverage   66.89%   51.03%   -15.86%     
   ===========================================
     Files        1022      477      -545     
     Lines       49994    17101    -32893     
     Branches     4892     4405      -487     
   ===========================================
   - Hits        33442     8728    -24714     
   + Misses      16427     8373     -8054     
   + Partials      125        0      -125     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `51.03% <81.81%> (+0.11%)` | :arrow_up: |
   | javascript | `?` | |
   | python | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/common/components/index.tsx](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
   | [...perset-frontend/src/explore/components/Control.tsx](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sLnRzeA==) | `100.00% <ø> (+4.76%)` | :arrow_up: |
   | [.../explore/components/controls/DatasourceControl.jsx](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRhc291cmNlQ29udHJvbC5qc3g=) | `62.68% <75.00%> (-0.03%)` | :arrow_down: |
   | [...rontend/src/explore/components/DatasourcePanel.tsx](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhc291cmNlUGFuZWwudHN4) | `80.95% <100.00%> (-1.66%)` | :arrow_down: |
   | [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
   | [...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvRXhlY3V0aW9uTG9nLnRzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
   | [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
   | ... and [864 more](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=footer). Last update [0fed1e0...aa350ef](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov-io edited a comment on pull request #12705: feat(explore): allow opening charts with missing dataset

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12705:
URL: https://github.com/apache/superset/pull/12705#issuecomment-765819050


   # [Codecov](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=h1) Report
   > Merging [#12705](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=desc) (04fab5e) into [master](https://codecov.io/gh/apache/superset/commit/51d1b66dcaac1e8f858560ba82ad3fd36d37190a?el=desc) (51d1b66) will **decrease** coverage by `3.49%`.
   > The diff coverage is `77.96%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/12705/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12705      +/-   ##
   ==========================================
   - Coverage   66.88%   63.39%   -3.50%     
   ==========================================
     Files        1022      488     -534     
     Lines       49992    30115   -19877     
     Branches     4892        0    -4892     
   ==========================================
   - Hits        33439    19090   -14349     
   + Misses      16428    11025    -5403     
   + Partials      125        0     -125     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | javascript | `?` | |
   | python | `63.39% <77.96%> (-0.69%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/connectors/druid/views.py](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC92aWV3cy5weQ==) | `69.79% <0.00%> (ø)` | |
   | [superset/datasets/api.py](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `89.49% <ø> (-1.83%)` | :arrow_down: |
   | [superset/views/base.py](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `75.31% <50.00%> (-0.11%)` | :arrow_down: |
   | [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.02% <66.66%> (-0.10%)` | :arrow_down: |
   | [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `71.82% <68.00%> (-3.48%)` | :arrow_down: |
   | [superset/views/datasource.py](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YXNvdXJjZS5weQ==) | `90.16% <71.42%> (+0.76%)` | :arrow_up: |
   | [superset/commands/exceptions.py](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvZXhjZXB0aW9ucy5weQ==) | `91.30% <100.00%> (ø)` | |
   | [superset/commands/utils.py](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvdXRpbHMucHk=) | `100.00% <100.00%> (ø)` | |
   | [superset/connectors/connector\_registry.py](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9jb25uZWN0b3JfcmVnaXN0cnkucHk=) | `86.27% <100.00%> (+1.83%)` | :arrow_up: |
   | [superset/datasets/commands/exceptions.py](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvZXhjZXB0aW9ucy5weQ==) | `92.98% <100.00%> (+0.25%)` | :arrow_up: |
   | ... and [555 more](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=footer). Last update [51d1b66...04fab5e](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov-io edited a comment on pull request #12705: feat(explore): allow opening charts with missing dataset

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12705:
URL: https://github.com/apache/superset/pull/12705#issuecomment-765819050


   # [Codecov](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=h1) Report
   > Merging [#12705](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=desc) (aa350ef) into [master](https://codecov.io/gh/apache/superset/commit/0fed1e04ef8cd09384b1290c7ebad622731b4aca?el=desc) (0fed1e0) will **decrease** coverage by `16.22%`.
   > The diff coverage is `81.81%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/12705/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           master   #12705       +/-   ##
   ===========================================
   - Coverage   66.89%   50.66%   -16.23%     
   ===========================================
     Files        1022      477      -545     
     Lines       49994    17101    -32893     
     Branches     4892     4405      -487     
   ===========================================
   - Hits        33442     8664    -24778     
   + Misses      16427     8437     -7990     
   + Partials      125        0      -125     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `50.66% <81.81%> (-0.26%)` | :arrow_down: |
   | javascript | `?` | |
   | python | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/common/components/index.tsx](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
   | [...perset-frontend/src/explore/components/Control.tsx](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sLnRzeA==) | `100.00% <ø> (+4.76%)` | :arrow_up: |
   | [.../explore/components/controls/DatasourceControl.jsx](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRhc291cmNlQ29udHJvbC5qc3g=) | `62.68% <75.00%> (-0.03%)` | :arrow_down: |
   | [...rontend/src/explore/components/DatasourcePanel.tsx](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhc291cmNlUGFuZWwudHN4) | `80.95% <100.00%> (-1.66%)` | :arrow_down: |
   | [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
   | [...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvRXhlY3V0aW9uTG9nLnRzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
   | [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
   | ... and [864 more](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=footer). Last update [0fed1e0...aa350ef](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov-io edited a comment on pull request #12705: feat(explore): allow opening charts with missing dataset

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12705:
URL: https://github.com/apache/superset/pull/12705#issuecomment-765819050


   # [Codecov](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=h1) Report
   > Merging [#12705](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=desc) (aa350ef) into [master](https://codecov.io/gh/apache/superset/commit/0fed1e04ef8cd09384b1290c7ebad622731b4aca?el=desc) (0fed1e0) will **decrease** coverage by `7.71%`.
   > The diff coverage is `78.57%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/12705/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12705      +/-   ##
   ==========================================
   - Coverage   66.89%   59.17%   -7.72%     
   ==========================================
     Files        1022      965      -57     
     Lines       49994    47218    -2776     
     Branches     4892     4405     -487     
   ==========================================
   - Hits        33442    27942    -5500     
   - Misses      16427    19276    +2849     
   + Partials      125        0     -125     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `51.03% <81.81%> (+0.11%)` | :arrow_up: |
   | javascript | `?` | |
   | python | `63.79% <77.96%> (-0.29%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/common/components/index.tsx](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
   | [...perset-frontend/src/explore/components/Control.tsx](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sLnRzeA==) | `100.00% <ø> (+4.76%)` | :arrow_up: |
   | [superset/connectors/druid/views.py](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC92aWV3cy5weQ==) | `69.79% <0.00%> (ø)` | |
   | [superset/datasets/api.py](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `89.49% <ø> (-1.83%)` | :arrow_down: |
   | [superset/views/base.py](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `75.31% <50.00%> (-0.11%)` | :arrow_down: |
   | [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.04% <66.66%> (-0.10%)` | :arrow_down: |
   | [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `72.93% <68.00%> (-2.37%)` | :arrow_down: |
   | [superset/views/datasource.py](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YXNvdXJjZS5weQ==) | `90.16% <71.42%> (+0.76%)` | :arrow_up: |
   | [.../explore/components/controls/DatasourceControl.jsx](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRhc291cmNlQ29udHJvbC5qc3g=) | `62.68% <75.00%> (-0.03%)` | :arrow_down: |
   | [...rontend/src/explore/components/DatasourcePanel.tsx](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhc291cmNlUGFuZWwudHN4) | `80.95% <100.00%> (-1.66%)` | :arrow_down: |
   | ... and [421 more](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=footer). Last update [0fed1e0...aa350ef](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov-io edited a comment on pull request #12705: feat(explore): allow opening charts with missing dataset

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12705:
URL: https://github.com/apache/superset/pull/12705#issuecomment-765819050


   # [Codecov](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=h1) Report
   > Merging [#12705](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=desc) (d2f47a4) into [master](https://codecov.io/gh/apache/superset/commit/0143a983b2b8e672f491c4a2c1f359e1c2b33c1f?el=desc) (0143a98) will **decrease** coverage by `8.01%`.
   > The diff coverage is `76.47%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/12705/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12705      +/-   ##
   ==========================================
   - Coverage   66.89%   58.88%   -8.02%     
   ==========================================
     Files        1020      963      -57     
     Lines       49905    47133    -2772     
     Branches     4888     4401     -487     
   ==========================================
   - Hits        33384    27753    -5631     
   - Misses      16396    19380    +2984     
   + Partials      125        0     -125     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `50.91% <66.66%> (+0.01%)` | :arrow_up: |
   | javascript | `?` | |
   | python | `63.41% <77.96%> (-0.69%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/common/components/index.tsx](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
   | [...perset-frontend/src/explore/components/Control.tsx](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sLnRzeA==) | `100.00% <ø> (+4.76%)` | :arrow_up: |
   | [superset/connectors/druid/views.py](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC92aWV3cy5weQ==) | `69.79% <0.00%> (ø)` | |
   | [superset/datasets/api.py](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `89.49% <ø> (-1.83%)` | :arrow_down: |
   | [.../explore/components/controls/DatasourceControl.jsx](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRhc291cmNlQ29udHJvbC5qc3g=) | `60.00% <50.00%> (-2.72%)` | :arrow_down: |
   | [superset/views/base.py](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `75.31% <50.00%> (-0.11%)` | :arrow_down: |
   | [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.02% <66.66%> (-0.10%)` | :arrow_down: |
   | [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `71.82% <68.00%> (-3.48%)` | :arrow_down: |
   | [superset/views/datasource.py](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YXNvdXJjZS5weQ==) | `90.16% <71.42%> (+0.76%)` | :arrow_up: |
   | [...rontend/src/explore/components/DatasourcePanel.tsx](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhc291cmNlUGFuZWwudHN4) | `80.95% <100.00%> (-1.66%)` | :arrow_down: |
   | ... and [422 more](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=footer). Last update [0143a98...d2f47a4](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov-io edited a comment on pull request #12705: feat(explore): allow opening charts with missing dataset

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12705:
URL: https://github.com/apache/superset/pull/12705#issuecomment-765819050


   # [Codecov](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=h1) Report
   > Merging [#12705](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=desc) (d2f47a4) into [master](https://codecov.io/gh/apache/superset/commit/0143a983b2b8e672f491c4a2c1f359e1c2b33c1f?el=desc) (0143a98) will **decrease** coverage by `15.98%`.
   > The diff coverage is `66.66%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/12705/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           master   #12705       +/-   ##
   ===========================================
   - Coverage   66.89%   50.91%   -15.99%     
   ===========================================
     Files        1020      476      -544     
     Lines       49905    17078    -32827     
     Branches     4888     4401      -487     
   ===========================================
   - Hits        33384     8695    -24689     
   + Misses      16396     8383     -8013     
   + Partials      125        0      -125     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `50.91% <66.66%> (+0.01%)` | :arrow_up: |
   | javascript | `?` | |
   | python | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/common/components/index.tsx](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
   | [...perset-frontend/src/explore/components/Control.tsx](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sLnRzeA==) | `100.00% <ø> (+4.76%)` | :arrow_up: |
   | [.../explore/components/controls/DatasourceControl.jsx](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRhc291cmNlQ29udHJvbC5qc3g=) | `60.00% <50.00%> (-2.72%)` | :arrow_down: |
   | [...rontend/src/explore/components/DatasourcePanel.tsx](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhc291cmNlUGFuZWwudHN4) | `80.95% <100.00%> (-1.66%)` | :arrow_down: |
   | [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
   | [...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvRXhlY3V0aW9uTG9nLnRzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
   | [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
   | ... and [860 more](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=footer). Last update [0143a98...d2f47a4](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] villebro commented on a change in pull request #12705: feat(explore): allow opening charts with missing dataset

Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #12705:
URL: https://github.com/apache/superset/pull/12705#discussion_r563534564



##########
File path: superset-frontend/src/explore/components/controls/DatasourceControl.jsx
##########
@@ -164,16 +169,22 @@ class DatasourceControl extends React.PureComponent {
       </Menu>
     );
 
-    // eslint-disable-next-line camelcase
     const { health_check_message: healthCheckMessage } = datasource;
 
     return (
       <Styles className="DatasourceControl">
         <div className="data-container">
           <Icon name="dataset-physical" className="dataset-svg" />
-          <Tooltip title={datasource.name}>
-            <span className="title-select">{datasource.name}</span>
-          </Tooltip>
+          {/* Add a tooltip only for long dataset names */}
+          {datasource.name.length > 20 ? (

Review comment:
       Could be nice to have this in a `constants.ts`

##########
File path: superset-frontend/src/explore/components/controls/DatasourceControl.jsx
##########
@@ -196,6 +207,35 @@ class DatasourceControl extends React.PureComponent {
             </Tooltip>
           </Dropdown>
         </div>
+        {/* missing dataset */}
+        {datasource.id == null && (
+          <div className="error-alert">
+            <ErrorAlert
+              level="warning"
+              title={t('Missing dataset')}
+              source="explore"
+              subtitle={
+                <>
+                  <p>
+                    {t(
+                      'The dataset linked to this chart may have been deleted.',

Review comment:
       Could we be more explicit here as in the other error - "Dataset does not exist".

##########
File path: superset/connectors/connector_registry.py
##########
@@ -44,12 +46,23 @@ def register_sources(cls, datasource_config: "OrderedDict[str, List[str]]") -> N
     def get_datasource(
         cls, datasource_type: str, datasource_id: int, session: Session
     ) -> "BaseDatasource":
-        return (
+        """Safely get a datasource without raising any errors.
+        Returns None if `datasource_type` is not registered or `datasource_id` does
+        not exists."""

Review comment:
       nit:
   ```suggestion
           not exist."""
   ```

##########
File path: superset/models/slice.py
##########
@@ -206,7 +206,7 @@ def digest(self) -> str:
         """
         Returns a MD5 HEX digest that makes this dashboard unique
         """
-        return utils.md5_hex(self.params)
+        return utils.md5_hex(self.params or "")

Review comment:
       Not that it matters, but I've always been allergic to md5 on empty string:
   ```
   >>> import hashlib
   >>> hashlib.md5(''.encode()).hexdigest()
   'd41d8cd98f00b204e9800998ecf8427e'
   ```
   
   ```suggestion
           return utils.md5_hex(self.params) if self.params else ''
   ```

##########
File path: superset/datasets/commands/exceptions.py
##########
@@ -54,7 +57,7 @@ class DatasetExistsValidationError(ValidationError):
 
     def __init__(self, table_name: str) -> None:
         super().__init__(
-            get_datasource_exist_error_msg(table_name), field_name="table_name"
+            [get_dataset_exist_error_msg(table_name)], field_name="table_name"

Review comment:
       Nice catch 👍 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] ktmud commented on pull request #12705: feat(explore): allow opening charts with missing dataset

Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #12705:
URL: https://github.com/apache/superset/pull/12705#issuecomment-767171264


   @junlincc @mihir174 feel free to create another issue to track followups if you want to update the design or copy.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] ktmud commented on a change in pull request #12705: feat(explore): allow opening charts with missing dataset

Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #12705:
URL: https://github.com/apache/superset/pull/12705#discussion_r563973045



##########
File path: superset-frontend/src/explore/components/controls/DatasourceControl.jsx
##########
@@ -164,16 +169,22 @@ class DatasourceControl extends React.PureComponent {
       </Menu>
     );
 
-    // eslint-disable-next-line camelcase
     const { health_check_message: healthCheckMessage } = datasource;
 
     return (
       <Styles className="DatasourceControl">
         <div className="data-container">
           <Icon name="dataset-physical" className="dataset-svg" />
-          <Tooltip title={datasource.name}>
-            <span className="title-select">{datasource.name}</span>
-          </Tooltip>
+          {/* Add a tooltip only for long dataset names */}
+          {datasource.name.length > 20 ? (

Review comment:
       This ideally should be more sophisticated where we display tooltip only when we detect text has been cutoff. This is just a heuristic number that works for the smallest panel width (300px).
   
   It's a very local feature so I wouldn't put it into another file.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] ktmud commented on a change in pull request #12705: feat(explore): allow opening charts with missing dataset

Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #12705:
URL: https://github.com/apache/superset/pull/12705#discussion_r564029116



##########
File path: superset/models/slice.py
##########
@@ -206,7 +206,7 @@ def digest(self) -> str:
         """
         Returns a MD5 HEX digest that makes this dashboard unique
         """
-        return utils.md5_hex(self.params)
+        return utils.md5_hex(self.params or "")

Review comment:
       Nvm. I'll keep `utils.md5_hex(self.params or "")` since this key is also used in thumbnail URLs:
   
   ```python
           return f"/api/v1/chart/{self.id}/thumbnail/{self.digest}/"
   ```
   
   We can make a follow up PR to rename `digest` to `thumbnail_key` (for both chart and dashboard) if we think it's necessary.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov-io edited a comment on pull request #12705: feat(explore): allow opening charts with missing dataset

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12705:
URL: https://github.com/apache/superset/pull/12705#issuecomment-765819050


   # [Codecov](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=h1) Report
   > Merging [#12705](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=desc) (aa350ef) into [master](https://codecov.io/gh/apache/superset/commit/0fed1e04ef8cd09384b1290c7ebad622731b4aca?el=desc) (0fed1e0) will **decrease** coverage by `7.97%`.
   > The diff coverage is `78.57%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/12705/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12705      +/-   ##
   ==========================================
   - Coverage   66.89%   58.91%   -7.98%     
   ==========================================
     Files        1022      965      -57     
     Lines       49994    47218    -2776     
     Branches     4892     4405     -487     
   ==========================================
   - Hits        33442    27820    -5622     
   - Misses      16427    19398    +2971     
   + Partials      125        0     -125     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `51.03% <81.81%> (+0.11%)` | :arrow_up: |
   | javascript | `?` | |
   | python | `63.39% <77.96%> (-0.69%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/common/components/index.tsx](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
   | [...perset-frontend/src/explore/components/Control.tsx](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sLnRzeA==) | `100.00% <ø> (+4.76%)` | :arrow_up: |
   | [superset/connectors/druid/views.py](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC92aWV3cy5weQ==) | `69.79% <0.00%> (ø)` | |
   | [superset/datasets/api.py](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `89.49% <ø> (-1.83%)` | :arrow_down: |
   | [superset/views/base.py](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `75.31% <50.00%> (-0.11%)` | :arrow_down: |
   | [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.04% <66.66%> (-0.10%)` | :arrow_down: |
   | [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `71.82% <68.00%> (-3.48%)` | :arrow_down: |
   | [superset/views/datasource.py](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YXNvdXJjZS5weQ==) | `90.16% <71.42%> (+0.76%)` | :arrow_up: |
   | [.../explore/components/controls/DatasourceControl.jsx](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRhc291cmNlQ29udHJvbC5qc3g=) | `62.68% <75.00%> (-0.03%)` | :arrow_down: |
   | [...rontend/src/explore/components/DatasourcePanel.tsx](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhc291cmNlUGFuZWwudHN4) | `80.95% <100.00%> (-1.66%)` | :arrow_down: |
   | ... and [425 more](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=footer). Last update [0fed1e0...aa350ef](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov-io edited a comment on pull request #12705: feat(explore): allow opening charts with missing dataset

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12705:
URL: https://github.com/apache/superset/pull/12705#issuecomment-765819050


   # [Codecov](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=h1) Report
   > Merging [#12705](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=desc) (13b6a54) into [master](https://codecov.io/gh/apache/superset/commit/0f8a62babf9bbff6ff53d835f77322d6563b5739?el=desc) (0f8a62b) will **decrease** coverage by `8.42%`.
   > The diff coverage is `62.50%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/12705/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12705      +/-   ##
   ==========================================
   - Coverage   59.37%   50.94%   -8.43%     
   ==========================================
     Files         962      475     -487     
     Lines       47037    17029   -30008     
     Branches     4387     4392       +5     
   ==========================================
   - Hits        27927     8675   -19252     
   + Misses      19110     8354   -10756     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `50.94% <62.50%> (+<0.01%)` | :arrow_up: |
   | python | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/common/components/index.tsx](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
   | [...perset-frontend/src/explore/components/Control.tsx](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sLnRzeA==) | `100.00% <ø> (ø)` | |
   | [.../explore/components/controls/DatasourceControl.jsx](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRhc291cmNlQ29udHJvbC5qc3g=) | `60.00% <40.00%> (-1.02%)` | :arrow_down: |
   | [...rontend/src/explore/components/DatasourcePanel.tsx](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhc291cmNlUGFuZWwudHN4) | `80.95% <100.00%> (+0.95%)` | :arrow_up: |
   | [...set-frontend/src/dashboard/util/getDropPosition.js](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERyb3BQb3NpdGlvbi5qcw==) | `77.77% <0.00%> (ø)` | |
   | [superset/utils/dashboard\_import\_export.py](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGFzaGJvYXJkX2ltcG9ydF9leHBvcnQucHk=) | | |
   | [...ns/8ee129739cf9\_security\_converge\_css\_templates.py](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy84ZWUxMjk3MzljZjlfc2VjdXJpdHlfY29udmVyZ2VfY3NzX3RlbXBsYXRlcy5weQ==) | | |
   | [.../c2acd2cf3df2\_alter\_type\_of\_dbs\_encrypted\_extra.py](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9jMmFjZDJjZjNkZjJfYWx0ZXJfdHlwZV9vZl9kYnNfZW5jcnlwdGVkX2V4dHJhLnB5) | | |
   | [.../migrations/versions/bddc498dd179\_adhoc\_filters.py](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9iZGRjNDk4ZGQxNzlfYWRob2NfZmlsdGVycy5weQ==) | | |
   | [superset/models/schedules.py](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NjaGVkdWxlcy5weQ==) | | |
   | ... and [472 more](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=footer). Last update [0f8a62b...2d58d3f](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] villebro commented on a change in pull request #12705: feat(explore): allow opening charts with missing dataset

Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #12705:
URL: https://github.com/apache/superset/pull/12705#discussion_r563534564



##########
File path: superset-frontend/src/explore/components/controls/DatasourceControl.jsx
##########
@@ -164,16 +169,22 @@ class DatasourceControl extends React.PureComponent {
       </Menu>
     );
 
-    // eslint-disable-next-line camelcase
     const { health_check_message: healthCheckMessage } = datasource;
 
     return (
       <Styles className="DatasourceControl">
         <div className="data-container">
           <Icon name="dataset-physical" className="dataset-svg" />
-          <Tooltip title={datasource.name}>
-            <span className="title-select">{datasource.name}</span>
-          </Tooltip>
+          {/* Add a tooltip only for long dataset names */}
+          {datasource.name.length > 20 ? (

Review comment:
       Could be nice to have this in a `constants.ts`

##########
File path: superset-frontend/src/explore/components/controls/DatasourceControl.jsx
##########
@@ -196,6 +207,35 @@ class DatasourceControl extends React.PureComponent {
             </Tooltip>
           </Dropdown>
         </div>
+        {/* missing dataset */}
+        {datasource.id == null && (
+          <div className="error-alert">
+            <ErrorAlert
+              level="warning"
+              title={t('Missing dataset')}
+              source="explore"
+              subtitle={
+                <>
+                  <p>
+                    {t(
+                      'The dataset linked to this chart may have been deleted.',

Review comment:
       Could we be more explicit here as in the other error - "Dataset does not exist".

##########
File path: superset/connectors/connector_registry.py
##########
@@ -44,12 +46,23 @@ def register_sources(cls, datasource_config: "OrderedDict[str, List[str]]") -> N
     def get_datasource(
         cls, datasource_type: str, datasource_id: int, session: Session
     ) -> "BaseDatasource":
-        return (
+        """Safely get a datasource without raising any errors.
+        Returns None if `datasource_type` is not registered or `datasource_id` does
+        not exists."""

Review comment:
       nit:
   ```suggestion
           not exist."""
   ```

##########
File path: superset/models/slice.py
##########
@@ -206,7 +206,7 @@ def digest(self) -> str:
         """
         Returns a MD5 HEX digest that makes this dashboard unique
         """
-        return utils.md5_hex(self.params)
+        return utils.md5_hex(self.params or "")

Review comment:
       Not that it matters, but I've always been allergic to md5 on empty string:
   ```
   >>> import hashlib
   >>> hashlib.md5(''.encode()).hexdigest()
   'd41d8cd98f00b204e9800998ecf8427e'
   ```
   
   ```suggestion
           return utils.md5_hex(self.params) if self.params else ''
   ```

##########
File path: superset/datasets/commands/exceptions.py
##########
@@ -54,7 +57,7 @@ class DatasetExistsValidationError(ValidationError):
 
     def __init__(self, table_name: str) -> None:
         super().__init__(
-            get_datasource_exist_error_msg(table_name), field_name="table_name"
+            [get_dataset_exist_error_msg(table_name)], field_name="table_name"

Review comment:
       Nice catch 👍 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov-io edited a comment on pull request #12705: feat(explore): allow opening charts with missing dataset

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12705:
URL: https://github.com/apache/superset/pull/12705#issuecomment-765819050


   # [Codecov](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=h1) Report
   > Merging [#12705](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=desc) (d2f47a4) into [master](https://codecov.io/gh/apache/superset/commit/0143a983b2b8e672f491c4a2c1f359e1c2b33c1f?el=desc) (0143a98) will **decrease** coverage by `8.01%`.
   > The diff coverage is `76.47%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/12705/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12705      +/-   ##
   ==========================================
   - Coverage   66.89%   58.88%   -8.02%     
   ==========================================
     Files        1020      963      -57     
     Lines       49905    47131    -2774     
     Branches     4888     4401     -487     
   ==========================================
   - Hits        33384    27751    -5633     
   - Misses      16396    19380    +2984     
   + Partials      125        0     -125     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `50.91% <66.66%> (+0.01%)` | :arrow_up: |
   | javascript | `?` | |
   | python | `63.40% <77.96%> (-0.70%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/common/components/index.tsx](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
   | [...perset-frontend/src/explore/components/Control.tsx](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sLnRzeA==) | `100.00% <ø> (+4.76%)` | :arrow_up: |
   | [superset/connectors/druid/views.py](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC92aWV3cy5weQ==) | `69.79% <0.00%> (ø)` | |
   | [superset/datasets/api.py](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `89.49% <ø> (-1.83%)` | :arrow_down: |
   | [.../explore/components/controls/DatasourceControl.jsx](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRhc291cmNlQ29udHJvbC5qc3g=) | `60.00% <50.00%> (-2.72%)` | :arrow_down: |
   | [superset/views/base.py](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `75.31% <50.00%> (-0.11%)` | :arrow_down: |
   | [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.02% <66.66%> (-0.10%)` | :arrow_down: |
   | [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `71.82% <68.00%> (-3.48%)` | :arrow_down: |
   | [superset/views/datasource.py](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YXNvdXJjZS5weQ==) | `90.16% <71.42%> (+0.76%)` | :arrow_up: |
   | [...rontend/src/explore/components/DatasourcePanel.tsx](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhc291cmNlUGFuZWwudHN4) | `80.95% <100.00%> (-1.66%)` | :arrow_down: |
   | ... and [423 more](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=footer). Last update [0143a98...d2f47a4](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] ktmud commented on a change in pull request #12705: feat(explore): allow opening charts with missing dataset

Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #12705:
URL: https://github.com/apache/superset/pull/12705#discussion_r563978780



##########
File path: superset/connectors/connector_registry.py
##########
@@ -44,12 +46,23 @@ def register_sources(cls, datasource_config: "OrderedDict[str, List[str]]") -> N
     def get_datasource(
         cls, datasource_type: str, datasource_id: int, session: Session
     ) -> "BaseDatasource":
-        return (
+        """Safely get a datasource without raising any errors.
+        Returns None if `datasource_type` is not registered or `datasource_id` does
+        not exists."""

Review comment:
       This comment is inaccurate. I decided to still raise an error to avoid making too many changes.
   
   Will delete.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] ktmud merged pull request #12705: feat(explore): allow opening charts with missing dataset

Posted by GitBox <gi...@apache.org>.
ktmud merged pull request #12705:
URL: https://github.com/apache/superset/pull/12705


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] junlincc commented on pull request #12705: feat(explore): allow opening charts with missing dataset

Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #12705:
URL: https://github.com/apache/superset/pull/12705#issuecomment-766169758


   I agree - this offers better UX. thanks for the (mid-term) solution. sad to see the toast message go though. Thank you both! @kkucharc @ktmud 🙏
   LGTM 
   https://user-images.githubusercontent.com/67837651/105612528-a8d2b180-5d71-11eb-90e7-57a4ad15cd98.mov
   
   cc @mihir174 we can tweak the styling and msg content later. 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov-io edited a comment on pull request #12705: feat(explore): allow opening charts with missing dataset

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12705:
URL: https://github.com/apache/superset/pull/12705#issuecomment-765819050






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] ktmud commented on a change in pull request #12705: feat(explore): allow opening charts with missing dataset

Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #12705:
URL: https://github.com/apache/superset/pull/12705#discussion_r563003291



##########
File path: superset/datasets/commands/exceptions.py
##########
@@ -26,7 +26,10 @@
     ImportFailedError,
     UpdateFailedError,
 )
-from superset.views.base import get_datasource_exist_error_msg

Review comment:
       Move to reduce the change of circular imports.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov-io edited a comment on pull request #12705: feat(explore): allow opening charts with missing dataset

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12705:
URL: https://github.com/apache/superset/pull/12705#issuecomment-765819050


   # [Codecov](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=h1) Report
   > Merging [#12705](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=desc) (aa350ef) into [master](https://codecov.io/gh/apache/superset/commit/0fed1e04ef8cd09384b1290c7ebad622731b4aca?el=desc) (0fed1e0) will **decrease** coverage by `7.97%`.
   > The diff coverage is `78.57%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/12705/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12705      +/-   ##
   ==========================================
   - Coverage   66.89%   58.91%   -7.98%     
   ==========================================
     Files        1022      965      -57     
     Lines       49994    47216    -2778     
     Branches     4892     4405     -487     
   ==========================================
   - Hits        33442    27818    -5624     
   - Misses      16427    19398    +2971     
   + Partials      125        0     -125     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `51.03% <81.81%> (+0.11%)` | :arrow_up: |
   | javascript | `?` | |
   | python | `63.39% <77.96%> (-0.69%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/common/components/index.tsx](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
   | [...perset-frontend/src/explore/components/Control.tsx](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sLnRzeA==) | `100.00% <ø> (+4.76%)` | :arrow_up: |
   | [superset/connectors/druid/views.py](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC92aWV3cy5weQ==) | `69.79% <0.00%> (ø)` | |
   | [superset/datasets/api.py](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `89.49% <ø> (-1.83%)` | :arrow_down: |
   | [superset/views/base.py](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `75.31% <50.00%> (-0.11%)` | :arrow_down: |
   | [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.04% <66.66%> (-0.10%)` | :arrow_down: |
   | [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `71.82% <68.00%> (-3.48%)` | :arrow_down: |
   | [superset/views/datasource.py](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YXNvdXJjZS5weQ==) | `90.16% <71.42%> (+0.76%)` | :arrow_up: |
   | [.../explore/components/controls/DatasourceControl.jsx](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRhc291cmNlQ29udHJvbC5qc3g=) | `62.68% <75.00%> (-0.03%)` | :arrow_down: |
   | [...rontend/src/explore/components/DatasourcePanel.tsx](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhc291cmNlUGFuZWwudHN4) | `80.95% <100.00%> (-1.66%)` | :arrow_down: |
   | ... and [426 more](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=footer). Last update [0fed1e0...aa350ef](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] ktmud commented on pull request #12705: feat(explore): allow opening charts with missing dataset

Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #12705:
URL: https://github.com/apache/superset/pull/12705#issuecomment-767172616


   A possible followup would be to add "Delete chart" shortcut CTA to make it easier for chart owners to delete outdated charts.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov-io commented on pull request #12705: feat(explore): allow opening charts with missing dataset

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #12705:
URL: https://github.com/apache/superset/pull/12705#issuecomment-765819050


   # [Codecov](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=h1) Report
   > Merging [#12705](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=desc) (13b6a54) into [master](https://codecov.io/gh/apache/superset/commit/0f8a62babf9bbff6ff53d835f77322d6563b5739?el=desc) (0f8a62b) will **decrease** coverage by `8.80%`.
   > The diff coverage is `62.50%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/12705/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12705      +/-   ##
   ==========================================
   - Coverage   59.37%   50.56%   -8.81%     
   ==========================================
     Files         962      475     -487     
     Lines       47037    17029   -30008     
     Branches     4387     4392       +5     
   ==========================================
   - Hits        27927     8611   -19316     
   + Misses      19110     8418   -10692     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `50.56% <62.50%> (-0.38%)` | :arrow_down: |
   | python | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/common/components/index.tsx](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
   | [...perset-frontend/src/explore/components/Control.tsx](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sLnRzeA==) | `100.00% <ø> (ø)` | |
   | [.../explore/components/controls/DatasourceControl.jsx](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRhc291cmNlQ29udHJvbC5qc3g=) | `60.00% <40.00%> (-1.02%)` | :arrow_down: |
   | [...rontend/src/explore/components/DatasourcePanel.tsx](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhc291cmNlUGFuZWwudHN4) | `80.95% <100.00%> (+0.95%)` | :arrow_up: |
   | [...et-frontend/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `33.33% <0.00%> (-16.67%)` | :arrow_down: |
   | [superset-frontend/src/reduxUtils.ts](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3JlZHV4VXRpbHMudHM=) | `52.17% <0.00%> (-11.60%)` | :arrow_down: |
   | [...rontend/src/SqlLab/components/TabbedSqlEditors.jsx](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmJlZFNxbEVkaXRvcnMuanN4) | `53.16% <0.00%> (-7.60%)` | :arrow_down: |
   | [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `17.62% <0.00%> (-5.53%)` | :arrow_down: |
   | [superset-frontend/src/SqlLab/reducers/sqlLab.js](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9zcWxMYWIuanM=) | `11.98% <0.00%> (-4.96%)` | :arrow_down: |
   | [...set-frontend/src/dashboard/util/getDropPosition.js](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERyb3BQb3NpdGlvbi5qcw==) | `77.77% <0.00%> (ø)` | |
   | ... and [477 more](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=footer). Last update [0f8a62b...2d58d3f](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] junlincc edited a comment on pull request #12705: feat(explore): allow opening charts with missing dataset

Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on pull request #12705:
URL: https://github.com/apache/superset/pull/12705#issuecomment-766169758


   I agree - this offers better UX. thanks for the (mid-term) solution. sad to see the toast message go though. Thank you both! @kkucharc @ktmud 🙏
   LGTM 
   
   https://user-images.githubusercontent.com/67837651/105612613-3f06d780-5d72-11eb-9646-705db390a07b.mov
   
   
   cc @mihir174 we can tweak the styling and msg content later. 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov-io edited a comment on pull request #12705: feat(explore): allow opening charts with missing dataset

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12705:
URL: https://github.com/apache/superset/pull/12705#issuecomment-765819050


   # [Codecov](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=h1) Report
   > Merging [#12705](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=desc) (aa350ef) into [master](https://codecov.io/gh/apache/superset/commit/0fed1e04ef8cd09384b1290c7ebad622731b4aca?el=desc) (0fed1e0) will **decrease** coverage by `18.12%`.
   > The diff coverage is `81.81%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/12705/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           master   #12705       +/-   ##
   ===========================================
   - Coverage   66.89%   48.76%   -18.13%     
   ===========================================
     Files        1022      477      -545     
     Lines       49994    17101    -32893     
     Branches     4892     4405      -487     
   ===========================================
   - Hits        33442     8339    -25103     
   + Misses      16427     8762     -7665     
   + Partials      125        0      -125     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `48.76% <81.81%> (-2.16%)` | :arrow_down: |
   | javascript | `?` | |
   | python | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/common/components/index.tsx](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
   | [...perset-frontend/src/explore/components/Control.tsx](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sLnRzeA==) | `100.00% <ø> (+4.76%)` | :arrow_up: |
   | [.../explore/components/controls/DatasourceControl.jsx](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRhc291cmNlQ29udHJvbC5qc3g=) | `62.68% <75.00%> (-0.03%)` | :arrow_down: |
   | [...rontend/src/explore/components/DatasourcePanel.tsx](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhc291cmNlUGFuZWwudHN4) | `80.95% <100.00%> (-1.66%)` | :arrow_down: |
   | [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...tend/src/dashboard/util/getDirectPathToTabIndex.js](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERpcmVjdFBhdGhUb1RhYkluZGV4Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...tend/src/visualizations/FilterBox/controlPanel.jsx](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9jb250cm9sUGFuZWwuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
   | ... and [877 more](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=footer). Last update [0fed1e0...aa350ef](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] ktmud commented on a change in pull request #12705: feat(explore): allow opening charts with missing dataset

Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #12705:
URL: https://github.com/apache/superset/pull/12705#discussion_r563001847



##########
File path: superset-frontend/src/common/components/index.tsx
##########
@@ -28,6 +28,7 @@ import { DropDownProps } from 'antd/lib/dropdown';
  */
 // eslint-disable-next-line no-restricted-imports
 export {
+  Alert,

Review comment:
       Wanted to use Antd Alert, but it looks inconsistent with the error box in chart container.

##########
File path: superset/connectors/connector_registry.py
##########
@@ -44,12 +46,23 @@ def register_sources(cls, datasource_config: "OrderedDict[str, List[str]]") -> N
     def get_datasource(
         cls, datasource_type: str, datasource_id: int, session: Session
     ) -> "BaseDatasource":
-        return (
+        """Safely get a datasource without raising any errors.
+        Returns None if `datasource_type` is not registered or `datasource_id` does
+        not exists."""
+        if datasource_type not in cls.sources:
+            raise DatasetNotFoundError()

Review comment:
       `handle_api_exception` will be able to render the error properly.

##########
File path: superset-frontend/src/explore/components/DatasourcePanel.tsx
##########
@@ -17,57 +17,25 @@
  * under the License.
  */
 import React, { useEffect, useState } from 'react';
-import { styled, t, QueryFormData } from '@superset-ui/core';
+import { styled, t } from '@superset-ui/core';
 import { Collapse } from 'src/common/components';
 import {
   ColumnOption,
   MetricOption,
-  ControlType,
+  ControlConfig,
+  DatasourceMeta,
 } from '@superset-ui/chart-controls';
 import { debounce } from 'lodash';
 import { matchSorter, rankings } from 'match-sorter';
 import { ExploreActions } from '../actions/exploreActions';
 import Control from './Control';
 
-interface DatasourceControl {
-  validationErrors: Array<any>;
-  mapStateToProps: QueryFormData;
-  type: ControlType;
-  label: string;
-  datasource?: DatasourceControl;
+interface DatasourceControl extends ControlConfig {
+  datasource?: DatasourceMeta;

Review comment:
       Bycatch: reuse typing from `@superset-ui/chart-controls`.

##########
File path: superset/views/datasource.py
##########
@@ -58,9 +58,7 @@ def save(self) -> FlaskResponse:
             try:
                 check_ownership(orm_datasource)
             except SupersetSecurityException:
-                return json_error_response(
-                    f"{DatasetForbiddenError.message}", DatasetForbiddenError.status
-                )
+                raise DatasetForbiddenError()

Review comment:
       `handle_api_exception` will be able to render the error properly.

##########
File path: superset-frontend/src/explore/components/DatasourcePanel.tsx
##########
@@ -279,6 +240,13 @@ export default function DataSourcePanel({
           </Collapse.Panel>
         </Collapse>
       </div>
+    </>
+  );
+
+  return (
+    <DatasourceContainer>
+      <Control {...datasourceControl} name="datasource" actions={actions} />
+      {datasource.id != null && mainBody}

Review comment:
       Datasource ID is `null` when it is unavailable.

##########
File path: superset/views/core.py
##########
@@ -771,25 +770,31 @@ def explore(  # pylint: disable=too-many-locals,too-many-return-statements
                 status=400,
             )
 
-        if action in ("saveas", "overwrite"):
+        if datasource_id and action in ("saveas", "overwrite"):
             return self.save_or_overwrite_slice(
                 slc,
                 slice_add_perm,
                 slice_overwrite_perm,
                 slice_download_perm,
                 datasource_id,
                 cast(str, datasource_type),
-                datasource.name,
+                datasource_name,
             )
 
         standalone = (
             request.args.get(utils.ReservedUrlParameters.STANDALONE.value) == "true"
         )
+        dummy_datasource_data: Dict[str, Any] = {
+            "type": datasource_type,
+            "name": datasource_name,
+            "columns": [],
+            "metrics": [],
+        }

Review comment:
       Adding a dummy datasource is easier than fixing countless places on the frontend where it's expected to exist.

##########
File path: superset/utils/core.py
##########
@@ -504,6 +505,8 @@ def base_json_conv(  # pylint: disable=inconsistent-return-statements,too-many-r
             return obj.decode("utf-8")
         except Exception:  # pylint: disable=broad-except
             return "[bytes]"
+    if isinstance(obj, LazyString):
+        return str(obj)

Review comment:
       Make sure translations can be properly outputted in json API response.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] ktmud commented on a change in pull request #12705: feat(explore): allow opening charts with missing dataset

Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #12705:
URL: https://github.com/apache/superset/pull/12705#discussion_r563973045



##########
File path: superset-frontend/src/explore/components/controls/DatasourceControl.jsx
##########
@@ -164,16 +169,22 @@ class DatasourceControl extends React.PureComponent {
       </Menu>
     );
 
-    // eslint-disable-next-line camelcase
     const { health_check_message: healthCheckMessage } = datasource;
 
     return (
       <Styles className="DatasourceControl">
         <div className="data-container">
           <Icon name="dataset-physical" className="dataset-svg" />
-          <Tooltip title={datasource.name}>
-            <span className="title-select">{datasource.name}</span>
-          </Tooltip>
+          {/* Add a tooltip only for long dataset names */}
+          {datasource.name.length > 20 ? (

Review comment:
       This ideally should be more sophisticated where we display tooltip only when we detect text has been cutoff. This is just a heuristic number that works for the smallest panel width (300px).
   
   It's a very local feature so I wouldn't put it into another file.

##########
File path: superset-frontend/src/explore/components/controls/DatasourceControl.jsx
##########
@@ -196,6 +207,35 @@ class DatasourceControl extends React.PureComponent {
             </Tooltip>
           </Dropdown>
         </div>
+        {/* missing dataset */}
+        {datasource.id == null && (
+          <div className="error-alert">
+            <ErrorAlert
+              level="warning"
+              title={t('Missing dataset')}
+              source="explore"
+              subtitle={
+                <>
+                  <p>
+                    {t(
+                      'The dataset linked to this chart may have been deleted.',

Review comment:
       My thinking is this: the dataset does not exist for two reasons, either it never existed or has been deleted. Since the latter is the most likely case, we inform users about this possibility, but also show reservations with "may" to be more accurate.
   
   I think a little bit more color in copy is more helpful comparing to repeating the same general message over and over.

##########
File path: superset/connectors/connector_registry.py
##########
@@ -44,12 +46,23 @@ def register_sources(cls, datasource_config: "OrderedDict[str, List[str]]") -> N
     def get_datasource(
         cls, datasource_type: str, datasource_id: int, session: Session
     ) -> "BaseDatasource":
-        return (
+        """Safely get a datasource without raising any errors.
+        Returns None if `datasource_type` is not registered or `datasource_id` does
+        not exists."""

Review comment:
       This comment is inaccurate. I decided to still raise an error to avoid making too many changes.
   
   Will delete.

##########
File path: superset/models/slice.py
##########
@@ -206,7 +206,7 @@ def digest(self) -> str:
         """
         Returns a MD5 HEX digest that makes this dashboard unique
         """
-        return utils.md5_hex(self.params)
+        return utils.md5_hex(self.params or "")

Review comment:
       I think I'll return `None` here just to be more explicit. The original change is for avoiding an uncaught exception, explicitly returning None forces the downstream handle the case of missing `params` more properly.

##########
File path: superset/models/slice.py
##########
@@ -206,7 +206,7 @@ def digest(self) -> str:
         """
         Returns a MD5 HEX digest that makes this dashboard unique
         """
-        return utils.md5_hex(self.params)
+        return utils.md5_hex(self.params or "")

Review comment:
       Nvm. I'll keep `utils.md5_hex(self.params or "")` since this key is also used in thumbnail URLs:
   
   ```python
           return f"/api/v1/chart/{self.id}/thumbnail/{self.digest}/"
   ```
   
   We can make a follow up PR to rename `digest` to `thumbnail_key` (for both chart and dashboard) if we think it's necessary.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] ktmud commented on a change in pull request #12705: feat(explore): allow opening charts with missing dataset

Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #12705:
URL: https://github.com/apache/superset/pull/12705#discussion_r563980914



##########
File path: superset/models/slice.py
##########
@@ -206,7 +206,7 @@ def digest(self) -> str:
         """
         Returns a MD5 HEX digest that makes this dashboard unique
         """
-        return utils.md5_hex(self.params)
+        return utils.md5_hex(self.params or "")

Review comment:
       I think I'll return `None` here just to be more explicit. The original change is for avoiding an uncaught exception, explicitly returning None forces the downstream handle the case of missing `params` more properly.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov-io edited a comment on pull request #12705: feat(explore): allow opening charts with missing dataset

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12705:
URL: https://github.com/apache/superset/pull/12705#issuecomment-765819050


   # [Codecov](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=h1) Report
   > Merging [#12705](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=desc) (d2f47a4) into [master](https://codecov.io/gh/apache/superset/commit/0143a983b2b8e672f491c4a2c1f359e1c2b33c1f?el=desc) (0143a98) will **decrease** coverage by `7.75%`.
   > The diff coverage is `76.47%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/12705/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12705      +/-   ##
   ==========================================
   - Coverage   66.89%   59.14%   -7.76%     
   ==========================================
     Files        1020      963      -57     
     Lines       49905    47133    -2772     
     Branches     4888     4401     -487     
   ==========================================
   - Hits        33384    27875    -5509     
   - Misses      16396    19258    +2862     
   + Partials      125        0     -125     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `50.91% <66.66%> (+0.01%)` | :arrow_up: |
   | javascript | `?` | |
   | python | `63.81% <77.96%> (-0.29%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/common/components/index.tsx](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
   | [...perset-frontend/src/explore/components/Control.tsx](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sLnRzeA==) | `100.00% <ø> (+4.76%)` | :arrow_up: |
   | [superset/connectors/druid/views.py](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC92aWV3cy5weQ==) | `69.79% <0.00%> (ø)` | |
   | [superset/datasets/api.py](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `89.49% <ø> (-1.83%)` | :arrow_down: |
   | [.../explore/components/controls/DatasourceControl.jsx](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRhc291cmNlQ29udHJvbC5qc3g=) | `60.00% <50.00%> (-2.72%)` | :arrow_down: |
   | [superset/views/base.py](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `75.31% <50.00%> (-0.11%)` | :arrow_down: |
   | [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.02% <66.66%> (-0.10%)` | :arrow_down: |
   | [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `72.93% <68.00%> (-2.37%)` | :arrow_down: |
   | [superset/views/datasource.py](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YXNvdXJjZS5weQ==) | `90.16% <71.42%> (+0.76%)` | :arrow_up: |
   | [...rontend/src/explore/components/DatasourcePanel.tsx](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhc291cmNlUGFuZWwudHN4) | `80.95% <100.00%> (-1.66%)` | :arrow_down: |
   | ... and [418 more](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=footer). Last update [0143a98...d2f47a4](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org