You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "Ma77Ball (via GitHub)" <gi...@apache.org> on 2026/07/01 22:15:41 UTC

[I] Remove dead MySQLSource exec path and document deserialization-only retention [texera]

Ma77Ball opened a new issue, #6051:
URL: https://github.com/apache/texera/issues/6051

   ### Task Summary
   The MySQL source operator (`MySQLSourceOpDesc` / `MySQLSourceOpExec` / `MySQLConnUtil` under `common/workflow-operator/.../source/sql/mysql/`) was deprecated and made non-executable in #4386 when `mysql-connector-java` was dropped for being GPLv2 (ASF Category X). The classes are retained only so legacy saved workflows containing a `MySQLSource` node still deserialize (`LogicalOp.scala` still registers `name = "MySQLSource"`), which leaves the `MySQLSourceOpExec` execution path as unreachable dead code and records the retention rationale only in a `@deprecated` message and a test comment. Proposed cleanup: (1) remove the genuinely dead execution half (`MySQLSourceOpExec`, and `MySQLConnUtil` if unused elsewhere), keeping only the minimal non-executable `MySQLSourceOpDesc` stub required for deserialization; (2) add a one-line comment at the `LogicalOp.scala` registration site stating the type is retained non-executable for legacy-workflow deserialization (ref #4386), so the contrac
 t is discoverable at the point a maintainer would touch it. Full removal of the operator (a load-time migration/version-gate that rewrites legacy `MySQLSource` nodes, then deleting the desc and type registration) is deferred as a larger follow-up; it is not worth the migration risk for a single dormant operator right now.
   ### Task Type
   - [x] Refactor / cleanup


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Remove dead MySQLSource exec path and document deserialization-only retention [texera]

Posted by "Ma77Ball (via GitHub)" <gi...@apache.org>.
Ma77Ball closed issue #6051: Remove dead MySQLSource exec path and document deserialization-only retention
URL: https://github.com/apache/texera/issues/6051


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Remove dead MySQLSource exec path and document deserialization-only retention [texera]

Posted by "anthonychengit (via GitHub)" <gi...@apache.org>.
anthonychengit commented on issue #6051:
URL: https://github.com/apache/texera/issues/6051#issuecomment-4897045288

   /take


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Remove dead MySQLSource exec path and document deserialization-only retention [texera]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #6051:
URL: https://github.com/apache/texera/issues/6051#issuecomment-4860464629

   <!-- texera:template-compliance -->
   👋 Thanks for opening this issue, @Ma77Ball!
   
   It looks like the issue description doesn't quite follow our template yet:
   
   - This issue doesn't appear to use one of our templates (Bug, Feature, or Task). Please open it using a template so the required details are captured.
   
   Filling out the template helps reviewers understand and triage your contribution faster. Please edit the description to complete it. This message will disappear automatically once the template is followed.
   
   You can find the template prompts by editing the description, or see [CONTRIBUTING.md](https://github.com/apache/texera/blob/main/CONTRIBUTING.md) for the full contribution flow.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org