You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "Taragolis (via GitHub)" <gi...@apache.org> on 2023/09/26 15:43:06 UTC
[GitHub] [airflow] Taragolis opened a new pull request, #34629: Use `airflow.models.dag.DAG` in core tests
Taragolis opened a new pull request, #34629:
URL: https://github.com/apache/airflow/pull/34629
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jens-scheffler-bosch commented on a diff in pull request #34629: Use `airflow.models.dag.DAG` in core tests
Posted by "jens-scheffler-bosch (via GitHub)" <gi...@apache.org>.
jens-scheffler-bosch commented on code in PR #34629:
URL: https://github.com/apache/airflow/pull/34629#discussion_r1337800781
##########
tests/models/test_dagrun.py:
##########
@@ -31,15 +31,14 @@
from airflow.decorators import setup, task, task_group, teardown
from airflow.exceptions import AirflowException
from airflow.models import (
- DAG,
DagBag,
Review Comment:
Here you missed some small pieces :-D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Lee-W commented on a diff in pull request #34629: Use `airflow.models.dag.DAG` in core tests
Posted by "Lee-W (via GitHub)" <gi...@apache.org>.
Lee-W commented on code in PR #34629:
URL: https://github.com/apache/airflow/pull/34629#discussion_r1338377995
##########
tests/operators/test_python.py:
##########
@@ -59,6 +59,10 @@
from tests.test_utils import AIRFLOW_MAIN_FOLDER
from tests.test_utils.db import clear_db_runs
+if TYPE_CHECKING:
+ from airflow.models.dagrun import DagRun
+
+TI = TaskInstance
Review Comment:
Should we unify how `TaskInstance` is referenced in this test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] hussein-awala commented on a diff in pull request #34629: Use `airflow.models.dag.DAG` in core tests
Posted by "hussein-awala (via GitHub)" <gi...@apache.org>.
hussein-awala commented on code in PR #34629:
URL: https://github.com/apache/airflow/pull/34629#discussion_r1337819258
##########
tests/models/test_dagrun.py:
##########
@@ -31,15 +31,14 @@
from airflow.decorators import setup, task, task_group, teardown
from airflow.exceptions import AirflowException
from airflow.models import (
- DAG,
DagBag,
Review Comment:
Same comment, if you will update them in a separate PR, then LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Taragolis commented on a diff in pull request #34629: Use `airflow.models.dag.DAG` in core tests
Posted by "Taragolis (via GitHub)" <gi...@apache.org>.
Taragolis commented on code in PR #34629:
URL: https://github.com/apache/airflow/pull/34629#discussion_r1338393007
##########
tests/operators/test_python.py:
##########
@@ -59,6 +59,10 @@
from tests.test_utils import AIRFLOW_MAIN_FOLDER
from tests.test_utils.db import clear_db_runs
+if TYPE_CHECKING:
+ from airflow.models.dagrun import DagRun
+
+TI = TaskInstance
Review Comment:
I think we could do as follow up. In some tests `TI` uses as shorthand for `TaskInstance` and I'm not sure should we do that, because it might lead to situation as we have in this test where `TaskInstance` uses for type annotation inside of the tests and `TI` uses for create object 🙄
##########
tests/operators/test_python.py:
##########
@@ -59,6 +59,10 @@
from tests.test_utils import AIRFLOW_MAIN_FOLDER
from tests.test_utils.db import clear_db_runs
+if TYPE_CHECKING:
+ from airflow.models.dagrun import DagRun
+
+TI = TaskInstance
Review Comment:
I think we could do as follow up. In some tests `TI` uses as shorthand for `TaskInstance` and I'm not sure should we do that, because it might lead to situation as we have in this test where `TaskInstance` uses for type annotation inside of the tests and `TI` uses for create object 🙄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Taragolis merged pull request #34629: Use `airflow.models.dag.DAG` in core tests
Posted by "Taragolis (via GitHub)" <gi...@apache.org>.
Taragolis merged PR #34629:
URL: https://github.com/apache/airflow/pull/34629
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org