You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "nvazquez (via GitHub)" <gi...@apache.org> on 2023/08/20 00:02:16 UTC
[GitHub] [cloudstack] nvazquez opened a new pull request, #7882: UI: Fix hide delete button for templates that are in Installing template state
nvazquez opened a new pull request, #7882:
URL: https://github.com/apache/cloudstack/pull/7882
### Description
This PR hides the Delete Template button when a template is installing
Fixes: #7865
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [x] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on a diff in pull request #7882: UI: Fix hide delete button for templates that are in Installing template state
Posted by "nvazquez (via GitHub)" <gi...@apache.org>.
nvazquez commented on code in PR #7882:
URL: https://github.com/apache/cloudstack/pull/7882#discussion_r1299398105
##########
ui/src/views/image/TemplateZones.vue:
##########
@@ -66,7 +66,7 @@
@onClick="showCopyTemplate(record)" />
<tooltip-button
style="margin-right: 5px"
- :disabled="!('deleteTemplate' in $store.getters.apis)"
+ :disabled="!('deleteTemplate' in $store.getters.apis && !record.status.startsWith('Installing'))"
Review Comment:
Thanks fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #7882: UI: Fix hide delete button for templates that are in Installing template state
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #7882:
URL: https://github.com/apache/cloudstack/pull/7882#issuecomment-1685948616
@nvazquez @andrijapanicsb @DaanHoogland
we could hide the button for the templates which is downloading as well.
however, what if the template is stuck at downloading or installing ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7882: UI: Fix hide delete button for templates that are in Installing template state
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7882:
URL: https://github.com/apache/cloudstack/pull/7882#issuecomment-1685290118
@nvazquez a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7882: UI: Fix hide delete button for templates that are in Installing template state
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7882:
URL: https://github.com/apache/cloudstack/pull/7882#issuecomment-1685316503
@nvazquez a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #7882: UI: Fix hide delete button for templates that are in Installing template state
Posted by "nvazquez (via GitHub)" <gi...@apache.org>.
nvazquez commented on PR #7882:
URL: https://github.com/apache/cloudstack/pull/7882#issuecomment-1685316454
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] codecov[bot] commented on pull request #7882: UI: Fix hide delete button for templates that are in Installing template state
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #7882:
URL: https://github.com/apache/cloudstack/pull/7882#issuecomment-1685145263
## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/7882?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#7882](https://app.codecov.io/gh/apache/cloudstack/pull/7882?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (b813df8) into [4.18](https://app.codecov.io/gh/apache/cloudstack/commit/f7345e861f832dbf5576c24c21eef73d72fe5d58?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (f7345e8) will **not change** coverage.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## 4.18 #7882 +/- ##
=========================================
Coverage 13.04% 13.04%
Complexity 9067 9067
=========================================
Files 2720 2720
Lines 257236 257236
Branches 40103 40103
=========================================
Hits 33552 33552
Misses 219474 219474
Partials 4210 4210
```
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #7882: UI: Fix hide delete button for templates that are in Installing template state
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on code in PR #7882:
URL: https://github.com/apache/cloudstack/pull/7882#discussion_r1299382139
##########
ui/src/views/image/TemplateZones.vue:
##########
@@ -66,7 +66,7 @@
@onClick="showCopyTemplate(record)" />
<tooltip-button
style="margin-right: 5px"
- :disabled="!('deleteTemplate' in $store.getters.apis)"
+ :disabled="!('deleteTemplate' in $store.getters.apis && !record.status.startsWith('Installing'))"
Review Comment:
hm, not (something and (not something else)) can this be re-written like
```suggestion
:disabled="record.status.startsWith('Installing') || !('deleteTemplate' in $store.getters.apis)"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #7882: UI: Fix hide delete button for templates that are in Installing template state
Posted by "nvazquez (via GitHub)" <gi...@apache.org>.
nvazquez commented on PR #7882:
URL: https://github.com/apache/cloudstack/pull/7882#issuecomment-1685289940
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7882: UI: Fix hide delete button for templates that are in Installing template state
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7882:
URL: https://github.com/apache/cloudstack/pull/7882#issuecomment-1685292999
UI build: :heavy_check_mark:
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/7882 (QA-JID-152)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7882: UI: Fix hide delete button for templates that are in Installing template state
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7882:
URL: https://github.com/apache/cloudstack/pull/7882#issuecomment-1685319149
UI build: :heavy_check_mark:
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/7882 (QA-JID-154)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #7882: UI: Fix hide delete button for templates that are in Installing template state
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #7882:
URL: https://github.com/apache/cloudstack/pull/7882#issuecomment-1687776055
It doens't allow deletion until it times out or errors. LGTM, merging this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud merged pull request #7882: UI: Fix hide delete button for templates that are in Installing template state
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud merged PR #7882:
URL: https://github.com/apache/cloudstack/pull/7882
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org