You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Arne Plöse (JIRA)" <ji...@apache.org> on 2011/07/21 11:24:03 UTC
[jira] [Created] (MATH-625) rename SparseRealVectorTest to
OpenMapRealMatrixTest
rename SparseRealVectorTest to OpenMapRealMatrixTest
----------------------------------------------------
Key: MATH-625
URL: https://issues.apache.org/jira/browse/MATH-625
Project: Commons Math
Issue Type: Wish
Affects Versions: 3.0
Reporter: Arne Plöse
Priority: Trivial
rename all Sparse(Real|Field)(Matrix|Vector)Test classes to OPenMap(Real|Field)(Matrix|Vector)Test
because OpenMap* is what they really test.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MATH-625) rename SparseRealVectorTest to
OpenMapRealMatrixTest
Posted by "Phil Steitz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13082189#comment-13082189 ]
Phil Steitz commented on MATH-625:
----------------------------------
Anyone agree with this? I disagree, because I think the structure is good as is, as it leaves open the possibility of splitting out tests for different impls, making the SparseXxx tests abstract.
> rename SparseRealVectorTest to OpenMapRealMatrixTest
> ----------------------------------------------------
>
> Key: MATH-625
> URL: https://issues.apache.org/jira/browse/MATH-625
> Project: Commons Math
> Issue Type: Wish
> Affects Versions: 3.0
> Reporter: Arne Plöse
> Priority: Trivial
>
> rename all Sparse(Real|Field)(Matrix|Vector)Test classes to OPenMap(Real|Field)(Matrix|Vector)Test
> because OpenMap* is what they really test.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MATH-625) rename SparseRealVectorTest to
OpenMapRealMatrixTest
Posted by "Gilles (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gilles updated MATH-625:
------------------------
Fix Version/s: (was: 3.1)
3.2
> rename SparseRealVectorTest to OpenMapRealMatrixTest
> ----------------------------------------------------
>
> Key: MATH-625
> URL: https://issues.apache.org/jira/browse/MATH-625
> Project: Commons Math
> Issue Type: Wish
> Reporter: Arne Plöse
> Priority: Trivial
> Fix For: 3.2
>
>
> rename all Sparse(Real|Field)(Matrix|Vector)Test classes to OPenMap(Real|Field)(Matrix|Vector)Test
> because OpenMap* is what they really test.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MATH-625) rename SparseRealVectorTest to
OpenMapRealMatrixTest
Posted by "Gilles (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13082302#comment-13082302 ]
Gilles commented on MATH-625:
-----------------------------
IIUC, the possible evolution which you suggest would indeed lead to having
{noformat}
SparseXxxAbstractTest
OpenMapXxxTest extends SparseXxxAbstractTest
SomeOtherSparseImplXxxTest extends SparseXxxAbstractTest
{noformat}
where "OpenMapXxxTest" in effect contains most of what is in the current "SparseXxxTest".
I think that there is some logic in making the change. I mean the full one, i.e. move the generic test code into abstract classes and create concrete ones for the "OpenMapXxx" implementations.
Anyways, the decision can be postponed to 3.1.
> rename SparseRealVectorTest to OpenMapRealMatrixTest
> ----------------------------------------------------
>
> Key: MATH-625
> URL: https://issues.apache.org/jira/browse/MATH-625
> Project: Commons Math
> Issue Type: Wish
> Affects Versions: 3.0
> Reporter: Arne Plöse
> Priority: Trivial
>
> rename all Sparse(Real|Field)(Matrix|Vector)Test classes to OPenMap(Real|Field)(Matrix|Vector)Test
> because OpenMap* is what they really test.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MATH-625) rename SparseRealVectorTest to
OpenMapRealMatrixTest
Posted by "Phil Steitz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phil Steitz updated MATH-625:
-----------------------------
Affects Version/s: (was: 3.0)
Fix Version/s: 3.1
> rename SparseRealVectorTest to OpenMapRealMatrixTest
> ----------------------------------------------------
>
> Key: MATH-625
> URL: https://issues.apache.org/jira/browse/MATH-625
> Project: Commons Math
> Issue Type: Wish
> Reporter: Arne Plöse
> Priority: Trivial
> Fix For: 3.1
>
>
> rename all Sparse(Real|Field)(Matrix|Vector)Test classes to OPenMap(Real|Field)(Matrix|Vector)Test
> because OpenMap* is what they really test.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MATH-625) rename SparseRealVectorTest to
OpenMapRealMatrixTest
Posted by "Luc Maisonobe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13082508#comment-13082508 ]
Luc Maisonobe commented on MATH-625:
------------------------------------
As this is a test class, there are no compatibility rules to enforce, so this can be decided upon for 3.1.
> rename SparseRealVectorTest to OpenMapRealMatrixTest
> ----------------------------------------------------
>
> Key: MATH-625
> URL: https://issues.apache.org/jira/browse/MATH-625
> Project: Commons Math
> Issue Type: Wish
> Affects Versions: 3.0
> Reporter: Arne Plöse
> Priority: Trivial
>
> rename all Sparse(Real|Field)(Matrix|Vector)Test classes to OPenMap(Real|Field)(Matrix|Vector)Test
> because OpenMap* is what they really test.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira