[GitHub] [arrow-rs] alamb opened a new issue, #2065: Rename `weekday` and `weekday0` kenrels to to `num_days_from_monday` and `days_since_sunday`

[GitBox <gi...@apache.org>]

alamb opened a new issue, #2065:
URL: https://github.com/apache/arrow-rs/issues/2065

   **Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
   Depending on the usecase sometimes one wants the days of week to start from Sunday or Monday. Dates :shrug:
   
   @ovr added the `weekday0` kernel in https://github.com/apache/arrow-rs/pull/2052
   
   But now the names are `weekday` and `weekday0` which I think might be confusing to the average reader
   
   
   **Describe the solution you'd like**
   I propose we follow the chrono naming scheme `num_days_from_sunday` and `num_days_from_monday`
   
   https://docs.rs/chrono/0.4.19/chrono/enum.Weekday.html#method.num_days_from_sunday
   https://docs.rs/chrono/0.4.19/chrono/enum.Weekday.html#method.num_days_from_monday
   
   
   **Describe alternatives you've considered**
   We could do nothing and handle any potential confusion with documentation
   
   
   **Additional context**
   Add any other context or screenshots about the feature request here.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] tustvold closed issue #2065: Rename `weekday` and `weekday0` kenrels to to `num_days_from_monday` and `days_since_sunday`

[GitBox <gi...@apache.org>]

tustvold closed issue #2065: Rename `weekday` and `weekday0` kenrels to to `num_days_from_monday` and `days_since_sunday`
URL: https://github.com/apache/arrow-rs/issues/2065


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org