You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2021/03/26 14:14:33 UTC
[GitHub] [netbeans] entlicher commented on a change in pull request #2825: Native debugging of GraalVM's native images.
entlicher commented on a change in pull request #2825:
URL: https://github.com/apache/netbeans/pull/2825#discussion_r602327632
##########
File path: java/java.lsp.server/nbcode/nbproject/platform.properties
##########
@@ -301,7 +302,6 @@ disabled.modules=\
org.netbeans.modules.team.commons,\
org.netbeans.modules.team.ide,\
org.netbeans.modules.templates,\
- org.netbeans.modules.terminal,\
Review comment:
We do not need it because of the terminal. We need it because of dependency on `dlight.nativeexecution`. We use `org.netbeans.modules.nativeexecution.pty` in `CPPLiteDebugger`. And `org.netbeans.modules.nativeexecution.pty.IOConnector` uses `org.netbeans.modules.terminal.api.*`
A solution can be to extract PTY-related stuff that happens to be used by cpplite from `dlight.nativeexecution` into a separate module. It's ugly, however, that only a part of the PTY API can be extracte, because a part of it depends on the `IOConnector`, which uses `org.netbeans.modules.terminal.api`. We would need to extract that API also.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists