[kudu-CR] refactor schema-design guide

["David Ribeiro Alves (Code Review)" <ge...@cloudera.org>]

David Ribeiro Alves has posted comments on this change.

Change subject: refactor schema-design guide
......................................................................


Patch Set 1:

(10 comments)

http://gerrit.cloudera.org:8080/#/c/4485/1//COMMIT_MSG
Commit Message:

PS1, Line 7: r
Nit capitalize


http://gerrit.cloudera.org:8080/#/c/4485/1/docs/schema_design.adoc
File docs/schema_design.adoc:

PS1, Line 40: next
doesn't the next section discuss the perfect schema and the concerns you mention before?


PS1, Line 49: the
nit: remove "the"?


Line 51:   remain steady over time. This is most impacted by partitioning.
nit: say "table", like above, for consistency, or remove table above, same below


PS1, Line 155: failure
s/failure/error


PS1, Line 155: rows 
s/rows/row


PS1, Line 221: Attempting to insert a row which falls in a 'non-covered'
             : portion of the range key space will fail.
For users familar with HBase and such this will seem weird without more context, i.e. How can a range be non-covered? Please elaborate a bit on that, jut point to the next section or remove this altogether and introduce it only in the next section.

Maybe also mention that the user would get NumSplitPoints + 1 tablets.


PS1, Line 255:  
add randomly


PS1, Line 255: is an effective tool
xxs nit: s/is an effective tool/is effective the former sounds repetitive with the previous sentence


Line 310: [[range-partitioning-example]]
any specific reason why the examples aren't next to their partitioning type? could they be? the explanation for multi level, for instance is abstract enough that my guess is most people will need the example to understand it


-- 
To view, visit http://gerrit.cloudera.org:8080/4485
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If4d91043d72e816a930d50927bf9441bd6b30b9b
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: Yes