You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@geode.apache.org by jb...@apache.org on 2017/09/20 17:08:50 UTC
[geode-native] branch develop updated: GEODE-3634: Corrected
spelling on PdxInstanceImpl::compareDefaultBytes
This is an automated email from the ASF dual-hosted git repository.
jbarrett pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/geode-native.git
The following commit(s) were added to refs/heads/develop by this push:
new 5ddb7bd GEODE-3634: Corrected spelling on PdxInstanceImpl::compareDefaultBytes
5ddb7bd is described below
commit 5ddb7bd0d0c4c221075a020912fb264239cc8c4f
Author: Mark Hanson <mh...@pivotal.io>
AuthorDate: Wed Sep 20 10:07:22 2017 -0700
GEODE-3634: Corrected spelling on PdxInstanceImpl::compareDefaultBytes
---
cppcache/src/PdxInstanceImpl.cpp | 32 +++++++++++++++-----------------
cppcache/src/PdxInstanceImpl.hpp | 2 +-
2 files changed, 16 insertions(+), 18 deletions(-)
diff --git a/cppcache/src/PdxInstanceImpl.cpp b/cppcache/src/PdxInstanceImpl.cpp
index 5ce5e43..c69bdfe 100644
--- a/cppcache/src/PdxInstanceImpl.cpp
+++ b/cppcache/src/PdxInstanceImpl.cpp
@@ -1720,9 +1720,9 @@ int PdxInstanceImpl::getSerializedLength(DataInput& dataInput,
return serializedLength;
}
-bool PdxInstanceImpl::compareDefaulBytes(DataInput& dataInput, int start,
- int end, int8_t* defaultBytes,
- int32_t length) const {
+bool PdxInstanceImpl::compareDefaultBytes(DataInput& dataInput, int start,
+ int end, int8_t* defaultBytes,
+ int32_t length) const {
if ((end - start) != length) return false;
dataInput.reset();
@@ -1743,32 +1743,31 @@ bool PdxInstanceImpl::hasDefaultBytes(PdxFieldTypePtr pField,
int end) const {
switch (pField->getTypeId()) {
case PdxFieldTypes::INT: {
- return compareDefaulBytes(dataInput, start, end, m_IntDefaultBytes, 4);
+ return compareDefaultBytes(dataInput, start, end, m_IntDefaultBytes, 4);
}
case PdxFieldTypes::STRING: {
- return compareDefaulBytes(dataInput, start, end, m_StringDefaultBytes, 1);
+ return compareDefaultBytes(dataInput, start, end, m_StringDefaultBytes, 1);
}
case PdxFieldTypes::BOOLEAN: {
- return compareDefaulBytes(dataInput, start, end, m_BooleanDefaultBytes,
- 1);
+ return compareDefaultBytes(dataInput, start, end, m_BooleanDefaultBytes, 1);
}
case PdxFieldTypes::FLOAT: {
- return compareDefaulBytes(dataInput, start, end, m_FloatDefaultBytes, 4);
+ return compareDefaultBytes(dataInput, start, end, m_FloatDefaultBytes, 4);
}
case PdxFieldTypes::DOUBLE: {
- return compareDefaulBytes(dataInput, start, end, m_DoubleDefaultBytes, 8);
+ return compareDefaultBytes(dataInput, start, end, m_DoubleDefaultBytes, 8);
}
case PdxFieldTypes::CHAR: {
- return compareDefaulBytes(dataInput, start, end, m_CharDefaultBytes, 2);
+ return compareDefaultBytes(dataInput, start, end, m_CharDefaultBytes, 2);
}
case PdxFieldTypes::BYTE: {
- return compareDefaulBytes(dataInput, start, end, m_ByteDefaultBytes, 1);
+ return compareDefaultBytes(dataInput, start, end, m_ByteDefaultBytes, 1);
}
case PdxFieldTypes::SHORT: {
- return compareDefaulBytes(dataInput, start, end, m_ShortDefaultBytes, 2);
+ return compareDefaultBytes(dataInput, start, end, m_ShortDefaultBytes, 2);
}
case PdxFieldTypes::LONG: {
- return compareDefaulBytes(dataInput, start, end, m_LongDefaultBytes, 8);
+ return compareDefaultBytes(dataInput, start, end, m_LongDefaultBytes, 8);
}
case PdxFieldTypes::BYTE_ARRAY:
case PdxFieldTypes::DOUBLE_ARRAY:
@@ -1781,14 +1780,13 @@ bool PdxInstanceImpl::hasDefaultBytes(PdxFieldTypePtr pField,
case PdxFieldTypes::STRING_ARRAY:
case PdxFieldTypes::ARRAY_OF_BYTE_ARRAYS:
case PdxFieldTypes::OBJECT_ARRAY: {
- return compareDefaulBytes(dataInput, start, end, m_NULLARRAYDefaultBytes,
- 1);
+ return compareDefaultBytes(dataInput, start, end, m_NULLARRAYDefaultBytes, 1);
}
case PdxFieldTypes::DATE: {
- return compareDefaulBytes(dataInput, start, end, m_DateDefaultBytes, 8);
+ return compareDefaultBytes(dataInput, start, end, m_DateDefaultBytes, 8);
}
case PdxFieldTypes::OBJECT: {
- return compareDefaulBytes(dataInput, start, end, m_ObjectDefaultBytes, 1);
+ return compareDefaultBytes(dataInput, start, end, m_ObjectDefaultBytes, 1);
}
default: {
throw IllegalStateException("hasDefaultBytes unable to find typeID ");
diff --git a/cppcache/src/PdxInstanceImpl.hpp b/cppcache/src/PdxInstanceImpl.hpp
index 723b578..0ca4ef0 100644
--- a/cppcache/src/PdxInstanceImpl.hpp
+++ b/cppcache/src/PdxInstanceImpl.hpp
@@ -1106,7 +1106,7 @@ class CPPCACHE_EXPORT PdxInstanceImpl : public WritablePdxInstance {
bool hasDefaultBytes(PdxFieldTypePtr pField, DataInput& dataInput, int start,
int end) const;
- bool compareDefaulBytes(DataInput& dataInput, int start, int end,
+ bool compareDefaultBytes(DataInput& dataInput, int start, int end,
int8_t* defaultBytes, int32_t length) const;
void writeField(PdxWriterPtr writer, const char* fieldName, int typeId,
--
To stop receiving notification emails like this one, please contact
['"commits@geode.apache.org" <co...@geode.apache.org>'].