You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "Croway (via GitHub)" <gi...@apache.org> on 2023/10/19 14:04:21 UTC
[PR] auto generate META-INF content for DataTypeTransformer [camel]
Croway opened a new pull request, #11775:
URL: https://github.com/apache/camel/pull/11775
Hi, I have some doubts regarding this PR, in particular,
- I had to hack camel-package-maven-plugin in order to support the DataTypeTransformer folder structure `META-INF/services/org/apache/camel/datatype` instead of `META-INF/services/org/apache/camel/` I was wondering if it is worth to use the "default" folder structure `META-INF/services/org/apache/camel/transformer`.
- I've implemented a sanitizer so that file names are equal to the original ones, but it can be removed if yo are fine with files with `:` or `+`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] auto generate META-INF content for DataTypeTransformer [camel]
Posted by "oscerd (via GitHub)" <gi...@apache.org>.
oscerd commented on PR #11775:
URL: https://github.com/apache/camel/pull/11775#issuecomment-1771173710
After this and the release 4.1.0 of camel-kamelets, we can maybe move the transformers from camel-kamelets repo to camel repo and autogenerating
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] auto generate META-INF content for DataTypeTransformer [camel]
Posted by "christophd (via GitHub)" <gi...@apache.org>.
christophd commented on PR #11775:
URL: https://github.com/apache/camel/pull/11775#issuecomment-1771167491
Thanks folks! This makes much more sense. Sorry for the folder structure confusion that I created manually
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] auto generate META-INF content for DataTypeTransformer [camel]
Posted by "Croway (via GitHub)" <gi...@apache.org>.
Croway commented on PR #11775:
URL: https://github.com/apache/camel/pull/11775#issuecomment-1771160192
Thanks @davsclaus, this was my gut feeling, I'll update the PR accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] auto generate META-INF content for DataTypeTransformer [camel]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #11775:
URL: https://github.com/apache/camel/pull/11775#issuecomment-1771151584
Yeah okay yeah so @christophd created this by hand at first, and yeah we should migrate to make it standard and generated like everything else in camel-core project.
And since they are transformer then they should ideally use `META-INF/services/org/apache/camel/transformer` as the folder name. This is what the JdkService would do if you specify transformer as the name.
And then you need to change the `DefaultTransformerResolver` to use the correct location.
For Camel 4.2 we can then add in the release notes about this change (though no camel end users is using this)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] auto generate META-INF content for DataTypeTransformer [camel]
Posted by "christophd (via GitHub)" <gi...@apache.org>.
christophd commented on PR #11775:
URL: https://github.com/apache/camel/pull/11775#issuecomment-1771190540
Yes +1 on moving to camel as much as possible
The only downside I see is that the transformers may add optional/provided dependencies to the Camel components pom.xml. This is because the transformer implementations refer to like JsonNode, CloudEvents etc. and these bits may not be part of the compile time in a Camel component yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] auto generate META-INF content for DataTypeTransformer [camel]
Posted by "Croway (via GitHub)" <gi...@apache.org>.
Croway merged PR #11775:
URL: https://github.com/apache/camel/pull/11775
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] auto generate META-INF content for DataTypeTransformer [camel]
Posted by "christophd (via GitHub)" <gi...@apache.org>.
christophd commented on PR #11775:
URL: https://github.com/apache/camel/pull/11775#issuecomment-1771182833
@davsclaus @oscerd I did not see your comments before writing my last comment. Yes, it makes sense to move the transformers into camel repo and use auto generation there
@Croway +1 on the sanitizer BTW
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] auto generate META-INF content for DataTypeTransformer [camel]
Posted by "christophd (via GitHub)" <gi...@apache.org>.
christophd commented on PR #11775:
URL: https://github.com/apache/camel/pull/11775#issuecomment-1771178053
There are some data type transformer implementations still living in the [camel-kamelets-utils](https://github.com/apache/camel-kamelets/tree/main/library/camel-kamelets-utils/src/main/java/org/apache/camel/kamelets/utils/format/converter) library.
Can we use the same SpiGeneratorMojo to auto generate there?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] auto generate META-INF content for DataTypeTransformer [camel]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #11775:
URL: https://github.com/apache/camel/pull/11775#issuecomment-1771177973
> After this and the release 4.1.0 of camel-kamelets, we can maybe move the transformers from camel-kamelets repo to camel repo and autogenerating
Ah good idea, can we create a JIRA or github issue for this so we wont forget
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] auto generate META-INF content for DataTypeTransformer [camel]
Posted by "oscerd (via GitHub)" <gi...@apache.org>.
oscerd commented on PR #11775:
URL: https://github.com/apache/camel/pull/11775#issuecomment-1771180979
> There are some data type transformer implementations still living in the [camel-kamelets-utils](https://github.com/apache/camel-kamelets/tree/main/library/camel-kamelets-utils/src/main/java/org/apache/camel/kamelets/utils/format/converter) library.
>
> Can we use the same SpiGeneratorMojo to auto generate there?
Wouldn't make more sense to move them in camel repo?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] auto generate META-INF content for DataTypeTransformer [camel]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #11775:
URL: https://github.com/apache/camel/pull/11775#issuecomment-1771425486
Yes its fine to merge
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] auto generate META-INF content for DataTypeTransformer [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #11775:
URL: https://github.com/apache/camel/pull/11775#issuecomment-1771061961
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:robot: CI automation will test this PR automatically.
:camel: Apache Camel Committers, please review the following items:
* First-time contributors **require MANUAL approval** for the GitHub Actions to run
* You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot.
* You can label PRs using `build-all`, `build-dependents`, `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR.
* Build and test logs are available in the Summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary.
* :warning: Be careful when sharing logs. Review their contents before sharing them publicly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] auto generate META-INF content for DataTypeTransformer [camel]
Posted by "Croway (via GitHub)" <gi...@apache.org>.
Croway commented on PR #11775:
URL: https://github.com/apache/camel/pull/11775#issuecomment-1771313397
the action is failing due to missing files, in particular I have the following locally
Is it safe to push these files? @oscerd @davsclaus
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] auto generate META-INF content for DataTypeTransformer [camel]
Posted by "oscerd (via GitHub)" <gi...@apache.org>.
oscerd commented on PR #11775:
URL: https://github.com/apache/camel/pull/11775#issuecomment-1771183079
I mean, we should try to avoid overloading the camel-kamelets library, for example we have also some specific bean there, we should maybe move those in the main repo? WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] auto generate META-INF content for DataTypeTransformer [camel]
Posted by "oscerd (via GitHub)" <gi...@apache.org>.
oscerd commented on PR #11775:
URL: https://github.com/apache/camel/pull/11775#issuecomment-1771443590
Go ahead +1 for me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org