[GitHub] [calcite] chunweilei commented on a change in pull request #1158: [CALCITE-2992] Make implicit conversions when generating hash join keys for an equiCondition

[GitBox <gi...@apache.org>]

chunweilei commented on a change in pull request #1158: [CALCITE-2992] Make implicit conversions when generating hash join keys for an equiCondition
URL: https://github.com/apache/calcite/pull/1158#discussion_r275099898
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/adapter/enumerable/PhysTypeImpl.java
 ##########
 @@ -582,7 +590,8 @@ public Expression generateAccessor(
       // }
       Expressions.FluentList<Expression> list = Expressions.list();
       for (int field : fields) {
-        list.add(fieldReference(v1, field));
+        list.add(
+            Expressions.call(CONVERT2STRING_METHOD, fieldReference(v1, field)));
       }
 
 Review comment:
   Need test case at least. Besides, I really don't think it's a good idea to convert join keys to strings since its costs.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services