Re: [PR] [fix][broker] Handle synchronous schema lookup failures in replication [pulsar]

["void-ptr974 (via GitHub)" <gi...@apache.org>]

void-ptr974 commented on PR #26108:
URL: https://github.com/apache/pulsar/pull/26108#issuecomment-4855990488

   Thanks for the update. The main concerns look addressed.
   
   One small follow-up: after this path calls `beforeTerminateOrCursorRewinding(...)`, `replicateEntries()` returns false, so `readEntriesComplete()` will still call `readMoreEntries()`. That call should not start a read while `waitForCursorRewindingRefCnf > 0`, but it may schedule another delayed retry. Could we skip the outer `readMoreEntries()` when the replicator is already waiting for cursor rewind, and let the scheduled `doRewindCursor(true)` resume reads instead?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org