You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apex.apache.org by chandnisingh <gi...@git.apache.org> on 2016/04/05 02:46:39 UTC
[GitHub] incubator-apex-malhar pull request: APEXMALHAR-2043 using property...
GitHub user chandnisingh opened a pull request:
https://github.com/apache/incubator-apex-malhar/pull/231
APEXMALHAR-2043 using property logViolationsToConsole instead of cons…
…oleOutput
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/chandnisingh/incubator-apex-malhar APEXMALHAR-2043
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-apex-malhar/pull/231.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #231
----
commit 29ea60200055aca0d059d5c5fd2dc6b2e78b3be0
Author: Chandni Singh <cs...@apache.org>
Date: 2016-04-05T00:46:00Z
APEXMALHAR-2043 using property logViolationsToConsole instead of consoleOutput
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-malhar pull request: APEXMALHAR-2043 using property...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-apex-malhar/pull/231
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-malhar pull request: APEXMALHAR-2043 using property...
Posted by chandnisingh <gi...@git.apache.org>.
Github user chandnisingh commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/231#discussion_r58486048
--- Diff: library/pom.xml ---
@@ -35,6 +35,7 @@
<name>Apache Apex Malhar (incubating) Library</name>
<properties>
+ <checkstyle.console>false</checkstyle.console>
--- End diff --
This is how it is in Apex core as well by @vrozov so was mimicking it.
I think the reason is that by default we don't want to print all the existing violations to console so we set the user property ```checkstyle.console``` to ```false```. However we give the user the option to see the existing violations by ```mvn checkstyle:check -Dcheckstyle.console``` if they want to see the existing violations.
If ```logViolationsToConsole``` is set to false, then user will not be able to spit out violations to the console.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-malhar pull request: APEXMALHAR-2043 using property...
Posted by tweise <gi...@git.apache.org>.
Github user tweise commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/231#discussion_r58483684
--- Diff: library/pom.xml ---
@@ -35,6 +35,7 @@
<name>Apache Apex Malhar (incubating) Library</name>
<properties>
+ <checkstyle.console>false</checkstyle.console>
--- End diff --
Why this property if the setting is local and final for the module?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---