You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@zeppelin.apache.org by mo...@apache.org on 2019/09/27 16:20:29 UTC
[zeppelin] branch master updated: [ZEPPELIN-4280] [Followup] Add
comments
This is an automated email from the ASF dual-hosted git repository.
moon pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/zeppelin.git
The following commit(s) were added to refs/heads/master by this push:
new 7d74b92 [ZEPPELIN-4280] [Followup] Add comments
7d74b92 is described below
commit 7d74b922c20d66bf6610e18cd40ad04b5897956a
Author: Lee moon soo <mo...@apache.org>
AuthorDate: Wed Sep 25 12:19:42 2019 -0700
[ZEPPELIN-4280] [Followup] Add comments
### What is this PR for?
This is followup issue for ZEPPELIN-4280, to add some comments on the code.
### What type of PR is it?
Documentation
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-4280
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
Author: Lee moon soo <mo...@apache.org>
Closes #3461 from Leemoonsoo/ZEPPELIN-4280-followup and squashes the following commits:
75d4995ea [Lee moon soo] add comment
---
zeppelin-web/src/app/notebook/paragraph/result/result.controller.js | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/zeppelin-web/src/app/notebook/paragraph/result/result.controller.js b/zeppelin-web/src/app/notebook/paragraph/result/result.controller.js
index 97372e2..b5435ed 100644
--- a/zeppelin-web/src/app/notebook/paragraph/result/result.controller.js
+++ b/zeppelin-web/src/app/notebook/paragraph/result/result.controller.js
@@ -812,9 +812,13 @@ function ResultCtrl($scope, $rootScope, $route, $window, $routeParams, $location
newConfig.graph.values = newConfig.graph.commonSetting.pivot.values;
delete newConfig.graph.commonSetting.pivot;
}
+
+ // don't send commitParagraphResult when config is the same.
+ // see https://issues.apache.org/jira/browse/ZEPPELIN-4280.
if (angular.equals($scope.config, newConfig)) {
return;
}
+
console.debug('committVizConfig', newConfig);
let newParams = angular.copy(paragraph.settings.params);
commitParagraphResult(paragraph.title, paragraph.text, newConfig, newParams);