You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/09/30 15:24:30 UTC

[GitHub] [pulsar-client-python] merlimat commented on a diff in pull request #1: PIP-209: Compile Python client wrapper

merlimat commented on code in PR #1:
URL: https://github.com/apache/pulsar-client-python/pull/1#discussion_r984708426


##########
build-mac-wheels.sh:
##########
@@ -246,6 +247,43 @@ else
     echo "Using cached LibCurl"
 fi
 
+###############################################################################
+if [ ! -f apache-pulsar-${PULSAR_VERSION}-src/.done ]; then
+    echo "Building Pulsar C++ client - ${PULSAR_VERSION}"
+    curl -O -L  https://archive.apache.org/dist/pulsar/pulsar-${PULSAR_VERSION}/apache-pulsar-${PULSAR_VERSION}-src.tar.gz
+    rm -rf apache-pulsar-${PULSAR_VERSION}-src/pulsar-client-cpp
+    tar xfz apache-pulsar-${PULSAR_VERSION}-src.tar.gz
+    pushd apache-pulsar-${PULSAR_VERSION}-src
+      pushd pulsar-client-cpp
+          ARCHS='arm64;x86_64'
+
+          chmod +x build-support/merge_archives.sh
+          set -x
+          cmake . \
+                  -DCMAKE_OSX_ARCHITECTURES=${ARCHS} \
+                  -DCMAKE_OSX_DEPLOYMENT_TARGET=${MACOSX_DEPLOYMENT_TARGET} \
+                  -DCMAKE_INSTALL_PREFIX=$PREFIX \
+                  -DCMAKE_BUILD_TYPE=Release \
+                  -DCMAKE_PREFIX_PATH=$PREFIX \
+                  -DCMAKE_CXX_FLAGS=-I$PREFIX/include \
+                  -DBoost_INCLUDE_DIR=$CACHE_DIR/boost-py-$PYTHON_VERSION/include \
+                  -DBoost_LIBRARY_DIR=$CACHE_DIR/boost-py-$PYTHON_VERSION/lib \
+                  -DLINK_STATIC=OFF \
+                  -DBUILD_TESTS=OFF \
+                  -DBUILD_PYTHON_WRAPPER=OFF \
+                  -DBUILD_WIRESHARK=OFF \
+                  -DBUILD_DYNAMIC_LIB=OFF \
+                  -DBUILD_STATIC_LIB=ON \
+                  -DPROTOC_PATH=$PREFIX/bin/protoc
+
+          make -j16 install
+      popd

Review Comment:
   Yes, also right now it's broken because the Python wrapper is already using features that were not included in 2.10.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org