You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by jun aoki <ju...@gmail.com> on 2016/03/17 23:06:19 UTC
Review Request 44987: Editing tmp dir from single to multiple dir
doesn't trigger the backend change
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44987/
-----------------------------------------------------------
Review request for Ambari.
Bugs: AMBARI-15475
https://issues.apache.org/jira/browse/AMBARI-15475
Repository: ambari
Description
-------
Modified "HAWQ Segment Temp Directory” from one [/d1/tmp/hawqsegment] to many [/d1/tmp/hawqsegment,/d2/tmp/hawqsegment,/d3/tmp/hawqsegment,/d4/tmp/hawqsegment,/d5/tmp/hawqsegment]
and the change is not propagated to segments and the folders are not created.
Diffs
-----
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py d62332d
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqsegment.py 0a597b6
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/master_helper.py 9482b35
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/params.py 1bdc5aa
Diff: https://reviews.apache.org/r/44987/diff/
Testing
-------
manually tested.
Thanks,
jun aoki
Re: Review Request 44987: Editing tmp dir from single to multiple dir
doesn't trigger the backend change
Posted by jun aoki <ju...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44987/#review124267
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py (line 60)
<https://reviews.apache.org/r/44987/#comment186736>
Alex, I tried it but it dose not work.
It behaves differently betweetn Directory(no mode)+Execute and Directory(with mode) in terms of permission setting. I remember that there is a some logic in _ensure_metadata() in system.py. will keep it as is, and we can come back for clean up.
- jun aoki
On March 17, 2016, 10:37 p.m., jun aoki wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44987/
> -----------------------------------------------------------
>
> (Updated March 17, 2016, 10:37 p.m.)
>
>
> Review request for Ambari.
>
>
> Bugs: AMBARI-15475
> https://issues.apache.org/jira/browse/AMBARI-15475
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Modified "HAWQ Segment Temp Directory” from one [/d1/tmp/hawqsegment] to many [/d1/tmp/hawqsegment,/d2/tmp/hawqsegment,/d3/tmp/hawqsegment,/d4/tmp/hawqsegment,/d5/tmp/hawqsegment]
> and the change is not propagated to segments and the folders are not created.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py d62332d
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqsegment.py 0a597b6
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/master_helper.py 9482b35
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/params.py 1bdc5aa
> ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqmaster.py 14b5a5f
> ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqsegment.py 6ca83b7
> ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqstandby.py eaba496
>
> Diff: https://reviews.apache.org/r/44987/diff/
>
>
> Testing
> -------
>
> manually tested.
>
> test_configure_default (test_hawqsegment.TestHawqSegment) ... ok
> test_install_default (test_hawqsegment.TestHawqSegment) ... ok
> test_start_default (test_hawqsegment.TestHawqSegment) ... ok
> test_stop_default (test_hawqsegment.TestHawqSegment) ... ok
> test_hawq_master_critical (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_master_ok (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_segment_critical (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_segment_ok (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_standby_critical (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_standby_ok (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_missing_configs (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_configure_default (test_hawqstandby.TestHawqStandby) ... ok
> test_install_default (test_hawqstandby.TestHawqStandby) ... ok
> test_start_default (test_hawqstandby.TestHawqStandby) ... 2016-03-17 15:33:42,969 - Standby host c6401.ambari.apache.org initialized
> ok
> test_stop_default (test_hawqstandby.TestHawqStandby) ... ok
> test_configure_default (test_hawqmaster.TestHawqMaster) ... ok
> test_install_default (test_hawqmaster.TestHawqMaster) ... ok
> test_start_default (test_hawqmaster.TestHawqMaster) ... 2016-03-17 15:33:43,025 - Active master c6401.ambari.apache.org initialized
> ok
> test_start_localmaster (test_hawqmaster.TestHawqMaster) ... 2016-03-17 15:33:43,049 - Master c6401.ambari.apache.org started
> ok
> test_stop_default (test_hawqmaster.TestHawqMaster) ... ok
>
>
> Thanks,
>
> jun aoki
>
>
Re: Review Request 44987: Editing tmp dir from single to multiple dir
doesn't trigger the backend change
Posted by jun aoki <ju...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44987/#review124128
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py (line 60)
<https://reviews.apache.org/r/44987/#comment186521>
Good point. That will acutally help cleaning some code. Will fix it.
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py (line 66)
<https://reviews.apache.org/r/44987/#comment186511>
```
- for path in dir_paths.split(','):
- if path != "":
- utils.create_dir_as_hawq_user(path)
+# for path in dir_paths.split(','):
+# if path != "":
+# utils.create_dir_as_hawq_user(path)
+ utils.create_dir_as_hawq_user(dir_paths)
```
I tried the code above but it does not work as commented.
When I have "/tmp/hawq/segment2,/tmp/hawq/segment3" then "segment2," (with a comman) was created.(I know it is weird)
I'd stick with my original.
- jun aoki
On March 17, 2016, 10:37 p.m., jun aoki wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44987/
> -----------------------------------------------------------
>
> (Updated March 17, 2016, 10:37 p.m.)
>
>
> Review request for Ambari.
>
>
> Bugs: AMBARI-15475
> https://issues.apache.org/jira/browse/AMBARI-15475
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Modified "HAWQ Segment Temp Directory” from one [/d1/tmp/hawqsegment] to many [/d1/tmp/hawqsegment,/d2/tmp/hawqsegment,/d3/tmp/hawqsegment,/d4/tmp/hawqsegment,/d5/tmp/hawqsegment]
> and the change is not propagated to segments and the folders are not created.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py d62332d
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqsegment.py 0a597b6
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/master_helper.py 9482b35
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/params.py 1bdc5aa
> ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqmaster.py 14b5a5f
> ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqsegment.py 6ca83b7
> ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqstandby.py eaba496
>
> Diff: https://reviews.apache.org/r/44987/diff/
>
>
> Testing
> -------
>
> manually tested.
>
> test_configure_default (test_hawqsegment.TestHawqSegment) ... ok
> test_install_default (test_hawqsegment.TestHawqSegment) ... ok
> test_start_default (test_hawqsegment.TestHawqSegment) ... ok
> test_stop_default (test_hawqsegment.TestHawqSegment) ... ok
> test_hawq_master_critical (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_master_ok (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_segment_critical (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_segment_ok (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_standby_critical (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_standby_ok (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_missing_configs (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_configure_default (test_hawqstandby.TestHawqStandby) ... ok
> test_install_default (test_hawqstandby.TestHawqStandby) ... ok
> test_start_default (test_hawqstandby.TestHawqStandby) ... 2016-03-17 15:33:42,969 - Standby host c6401.ambari.apache.org initialized
> ok
> test_stop_default (test_hawqstandby.TestHawqStandby) ... ok
> test_configure_default (test_hawqmaster.TestHawqMaster) ... ok
> test_install_default (test_hawqmaster.TestHawqMaster) ... ok
> test_start_default (test_hawqmaster.TestHawqMaster) ... 2016-03-17 15:33:43,025 - Active master c6401.ambari.apache.org initialized
> ok
> test_start_localmaster (test_hawqmaster.TestHawqMaster) ... 2016-03-17 15:33:43,049 - Master c6401.ambari.apache.org started
> ok
> test_stop_default (test_hawqmaster.TestHawqMaster) ... ok
>
>
> Thanks,
>
> jun aoki
>
>
Re: Review Request 44987: Editing tmp dir from single to multiple dir
doesn't trigger the backend change
Posted by bhuvnesh chaudhary <bc...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44987/#review124306
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py (line 57)
<https://reviews.apache.org/r/44987/#comment186776>
with hawq you don't call master directory for segment hawq_segment_dir
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py (line 67)
<https://reviews.apache.org/r/44987/#comment186778>
probably should have stripped of spaces before creating the dir.
- bhuvnesh chaudhary
On March 18, 2016, 10:17 p.m., jun aoki wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44987/
> -----------------------------------------------------------
>
> (Updated March 18, 2016, 10:17 p.m.)
>
>
> Review request for Ambari.
>
>
> Bugs: AMBARI-15475
> https://issues.apache.org/jira/browse/AMBARI-15475
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Modified "HAWQ Segment Temp Directory” from one [/d1/tmp/hawqsegment] to many [/d1/tmp/hawqsegment,/d2/tmp/hawqsegment,/d3/tmp/hawqsegment,/d4/tmp/hawqsegment,/d5/tmp/hawqsegment]
> and the change is not propagated to segments and the folders are not created.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py d62332d
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqsegment.py 0a597b6
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/master_helper.py 9482b35
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/params.py 1bdc5aa
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/utils.py dc6c203
> ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqmaster.py 14b5a5f
> ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqsegment.py 6ca83b7
> ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqstandby.py eaba496
>
> Diff: https://reviews.apache.org/r/44987/diff/
>
>
> Testing
> -------
>
> manually tested.
>
> test_configure_default (test_hawqsegment.TestHawqSegment) ... ok
> test_install_default (test_hawqsegment.TestHawqSegment) ... ok
> test_start_default (test_hawqsegment.TestHawqSegment) ... ok
> test_stop_default (test_hawqsegment.TestHawqSegment) ... ok
> test_hawq_master_critical (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_master_ok (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_segment_critical (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_segment_ok (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_standby_critical (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_standby_ok (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_missing_configs (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_configure_default (test_hawqstandby.TestHawqStandby) ... ok
> test_install_default (test_hawqstandby.TestHawqStandby) ... ok
> test_start_default (test_hawqstandby.TestHawqStandby) ... 2016-03-17 15:33:42,969 - Standby host c6401.ambari.apache.org initialized
> ok
> test_stop_default (test_hawqstandby.TestHawqStandby) ... ok
> test_configure_default (test_hawqmaster.TestHawqMaster) ... ok
> test_install_default (test_hawqmaster.TestHawqMaster) ... ok
> test_start_default (test_hawqmaster.TestHawqMaster) ... 2016-03-17 15:33:43,025 - Active master c6401.ambari.apache.org initialized
> ok
> test_start_localmaster (test_hawqmaster.TestHawqMaster) ... 2016-03-17 15:33:43,049 - Master c6401.ambari.apache.org started
> ok
> test_stop_default (test_hawqmaster.TestHawqMaster) ... ok
>
>
> Thanks,
>
> jun aoki
>
>
Re: Review Request 44987: Editing tmp dir from single to multiple dir
doesn't trigger the backend change
Posted by bhuvnesh chaudhary <bc...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44987/#review124309
-----------------------------------------------------------
Ship it!
Ship It!
- bhuvnesh chaudhary
On March 18, 2016, 10:17 p.m., jun aoki wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44987/
> -----------------------------------------------------------
>
> (Updated March 18, 2016, 10:17 p.m.)
>
>
> Review request for Ambari.
>
>
> Bugs: AMBARI-15475
> https://issues.apache.org/jira/browse/AMBARI-15475
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Modified "HAWQ Segment Temp Directory” from one [/d1/tmp/hawqsegment] to many [/d1/tmp/hawqsegment,/d2/tmp/hawqsegment,/d3/tmp/hawqsegment,/d4/tmp/hawqsegment,/d5/tmp/hawqsegment]
> and the change is not propagated to segments and the folders are not created.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py d62332d
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqsegment.py 0a597b6
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/master_helper.py 9482b35
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/params.py 1bdc5aa
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/utils.py dc6c203
> ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqmaster.py 14b5a5f
> ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqsegment.py 6ca83b7
> ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqstandby.py eaba496
>
> Diff: https://reviews.apache.org/r/44987/diff/
>
>
> Testing
> -------
>
> manually tested.
>
> test_configure_default (test_hawqsegment.TestHawqSegment) ... ok
> test_install_default (test_hawqsegment.TestHawqSegment) ... ok
> test_start_default (test_hawqsegment.TestHawqSegment) ... ok
> test_stop_default (test_hawqsegment.TestHawqSegment) ... ok
> test_hawq_master_critical (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_master_ok (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_segment_critical (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_segment_ok (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_standby_critical (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_standby_ok (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_missing_configs (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_configure_default (test_hawqstandby.TestHawqStandby) ... ok
> test_install_default (test_hawqstandby.TestHawqStandby) ... ok
> test_start_default (test_hawqstandby.TestHawqStandby) ... 2016-03-17 15:33:42,969 - Standby host c6401.ambari.apache.org initialized
> ok
> test_stop_default (test_hawqstandby.TestHawqStandby) ... ok
> test_configure_default (test_hawqmaster.TestHawqMaster) ... ok
> test_install_default (test_hawqmaster.TestHawqMaster) ... ok
> test_start_default (test_hawqmaster.TestHawqMaster) ... 2016-03-17 15:33:43,025 - Active master c6401.ambari.apache.org initialized
> ok
> test_start_localmaster (test_hawqmaster.TestHawqMaster) ... 2016-03-17 15:33:43,049 - Master c6401.ambari.apache.org started
> ok
> test_stop_default (test_hawqmaster.TestHawqMaster) ... ok
>
>
> Thanks,
>
> jun aoki
>
>
Re: Review Request 44987: Editing tmp dir from single to multiple dir
doesn't trigger the backend change
Posted by jun aoki <ju...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44987/
-----------------------------------------------------------
(Updated March 18, 2016, 10:17 p.m.)
Review request for Ambari.
Bugs: AMBARI-15475
https://issues.apache.org/jira/browse/AMBARI-15475
Repository: ambari
Description
-------
Modified "HAWQ Segment Temp Directory” from one [/d1/tmp/hawqsegment] to many [/d1/tmp/hawqsegment,/d2/tmp/hawqsegment,/d3/tmp/hawqsegment,/d4/tmp/hawqsegment,/d5/tmp/hawqsegment]
and the change is not propagated to segments and the folders are not created.
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py d62332d
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqsegment.py 0a597b6
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/master_helper.py 9482b35
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/params.py 1bdc5aa
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/utils.py dc6c203
ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqmaster.py 14b5a5f
ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqsegment.py 6ca83b7
ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqstandby.py eaba496
Diff: https://reviews.apache.org/r/44987/diff/
Testing
-------
manually tested.
test_configure_default (test_hawqsegment.TestHawqSegment) ... ok
test_install_default (test_hawqsegment.TestHawqSegment) ... ok
test_start_default (test_hawqsegment.TestHawqSegment) ... ok
test_stop_default (test_hawqsegment.TestHawqSegment) ... ok
test_hawq_master_critical (test_alert_component_status.TestAlertComponentStatus) ... ok
test_hawq_master_ok (test_alert_component_status.TestAlertComponentStatus) ... ok
test_hawq_segment_critical (test_alert_component_status.TestAlertComponentStatus) ... ok
test_hawq_segment_ok (test_alert_component_status.TestAlertComponentStatus) ... ok
test_hawq_standby_critical (test_alert_component_status.TestAlertComponentStatus) ... ok
test_hawq_standby_ok (test_alert_component_status.TestAlertComponentStatus) ... ok
test_missing_configs (test_alert_component_status.TestAlertComponentStatus) ... ok
test_configure_default (test_hawqstandby.TestHawqStandby) ... ok
test_install_default (test_hawqstandby.TestHawqStandby) ... ok
test_start_default (test_hawqstandby.TestHawqStandby) ... 2016-03-17 15:33:42,969 - Standby host c6401.ambari.apache.org initialized
ok
test_stop_default (test_hawqstandby.TestHawqStandby) ... ok
test_configure_default (test_hawqmaster.TestHawqMaster) ... ok
test_install_default (test_hawqmaster.TestHawqMaster) ... ok
test_start_default (test_hawqmaster.TestHawqMaster) ... 2016-03-17 15:33:43,025 - Active master c6401.ambari.apache.org initialized
ok
test_start_localmaster (test_hawqmaster.TestHawqMaster) ... 2016-03-17 15:33:43,049 - Master c6401.ambari.apache.org started
ok
test_stop_default (test_hawqmaster.TestHawqMaster) ... ok
Thanks,
jun aoki
Re: Review Request 44987: Editing tmp dir from single to multiple dir
doesn't trigger the backend change
Posted by jun aoki <ju...@gmail.com>.
> On March 17, 2016, 11:10 p.m., Alexander Denissov wrote:
> > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqsegment.py, line 45
> > <https://reviews.apache.org/r/44987/diff/2/?file=1303610#file1303610line45>
> >
> > plural, so perhaps "..they should be.." instead of "..it should be.."
Good catch!
- jun
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44987/#review124115
-----------------------------------------------------------
On March 17, 2016, 10:37 p.m., jun aoki wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44987/
> -----------------------------------------------------------
>
> (Updated March 17, 2016, 10:37 p.m.)
>
>
> Review request for Ambari.
>
>
> Bugs: AMBARI-15475
> https://issues.apache.org/jira/browse/AMBARI-15475
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Modified "HAWQ Segment Temp Directory” from one [/d1/tmp/hawqsegment] to many [/d1/tmp/hawqsegment,/d2/tmp/hawqsegment,/d3/tmp/hawqsegment,/d4/tmp/hawqsegment,/d5/tmp/hawqsegment]
> and the change is not propagated to segments and the folders are not created.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py d62332d
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqsegment.py 0a597b6
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/master_helper.py 9482b35
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/params.py 1bdc5aa
> ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqmaster.py 14b5a5f
> ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqsegment.py 6ca83b7
> ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqstandby.py eaba496
>
> Diff: https://reviews.apache.org/r/44987/diff/
>
>
> Testing
> -------
>
> manually tested.
>
> test_configure_default (test_hawqsegment.TestHawqSegment) ... ok
> test_install_default (test_hawqsegment.TestHawqSegment) ... ok
> test_start_default (test_hawqsegment.TestHawqSegment) ... ok
> test_stop_default (test_hawqsegment.TestHawqSegment) ... ok
> test_hawq_master_critical (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_master_ok (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_segment_critical (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_segment_ok (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_standby_critical (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_standby_ok (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_missing_configs (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_configure_default (test_hawqstandby.TestHawqStandby) ... ok
> test_install_default (test_hawqstandby.TestHawqStandby) ... ok
> test_start_default (test_hawqstandby.TestHawqStandby) ... 2016-03-17 15:33:42,969 - Standby host c6401.ambari.apache.org initialized
> ok
> test_stop_default (test_hawqstandby.TestHawqStandby) ... ok
> test_configure_default (test_hawqmaster.TestHawqMaster) ... ok
> test_install_default (test_hawqmaster.TestHawqMaster) ... ok
> test_start_default (test_hawqmaster.TestHawqMaster) ... 2016-03-17 15:33:43,025 - Active master c6401.ambari.apache.org initialized
> ok
> test_start_localmaster (test_hawqmaster.TestHawqMaster) ... 2016-03-17 15:33:43,049 - Master c6401.ambari.apache.org started
> ok
> test_stop_default (test_hawqmaster.TestHawqMaster) ... ok
>
>
> Thanks,
>
> jun aoki
>
>
Re: Review Request 44987: Editing tmp dir from single to multiple dir
doesn't trigger the backend change
Posted by Alexander Denissov <ad...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44987/#review124115
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py (line 60)
<https://reviews.apache.org/r/44987/#comment186491>
maybe pass the mode into create_dir_as_hawq_user (default None) so it can be used with Directory(mode=xyz) resource and not via chmod ? Then there will be no need for this function at all.
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py (line 66)
<https://reviews.apache.org/r/44987/#comment186492>
I wonder if Ambari already supports creating a list of directories from a string with comma-separated values via Directory resource ?
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqsegment.py (line 45)
<https://reviews.apache.org/r/44987/#comment186493>
plural, so perhaps "..they should be.." instead of "..it should be.."
- Alexander Denissov
On March 17, 2016, 10:37 p.m., jun aoki wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44987/
> -----------------------------------------------------------
>
> (Updated March 17, 2016, 10:37 p.m.)
>
>
> Review request for Ambari.
>
>
> Bugs: AMBARI-15475
> https://issues.apache.org/jira/browse/AMBARI-15475
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Modified "HAWQ Segment Temp Directory” from one [/d1/tmp/hawqsegment] to many [/d1/tmp/hawqsegment,/d2/tmp/hawqsegment,/d3/tmp/hawqsegment,/d4/tmp/hawqsegment,/d5/tmp/hawqsegment]
> and the change is not propagated to segments and the folders are not created.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py d62332d
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqsegment.py 0a597b6
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/master_helper.py 9482b35
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/params.py 1bdc5aa
> ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqmaster.py 14b5a5f
> ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqsegment.py 6ca83b7
> ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqstandby.py eaba496
>
> Diff: https://reviews.apache.org/r/44987/diff/
>
>
> Testing
> -------
>
> manually tested.
>
> test_configure_default (test_hawqsegment.TestHawqSegment) ... ok
> test_install_default (test_hawqsegment.TestHawqSegment) ... ok
> test_start_default (test_hawqsegment.TestHawqSegment) ... ok
> test_stop_default (test_hawqsegment.TestHawqSegment) ... ok
> test_hawq_master_critical (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_master_ok (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_segment_critical (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_segment_ok (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_standby_critical (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_standby_ok (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_missing_configs (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_configure_default (test_hawqstandby.TestHawqStandby) ... ok
> test_install_default (test_hawqstandby.TestHawqStandby) ... ok
> test_start_default (test_hawqstandby.TestHawqStandby) ... 2016-03-17 15:33:42,969 - Standby host c6401.ambari.apache.org initialized
> ok
> test_stop_default (test_hawqstandby.TestHawqStandby) ... ok
> test_configure_default (test_hawqmaster.TestHawqMaster) ... ok
> test_install_default (test_hawqmaster.TestHawqMaster) ... ok
> test_start_default (test_hawqmaster.TestHawqMaster) ... 2016-03-17 15:33:43,025 - Active master c6401.ambari.apache.org initialized
> ok
> test_start_localmaster (test_hawqmaster.TestHawqMaster) ... 2016-03-17 15:33:43,049 - Master c6401.ambari.apache.org started
> ok
> test_stop_default (test_hawqmaster.TestHawqMaster) ... ok
>
>
> Thanks,
>
> jun aoki
>
>
Re: Review Request 44987: Editing tmp dir from single to multiple dir
doesn't trigger the backend change
Posted by jun aoki <ju...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44987/
-----------------------------------------------------------
(Updated March 17, 2016, 10:37 p.m.)
Review request for Ambari.
Bugs: AMBARI-15475
https://issues.apache.org/jira/browse/AMBARI-15475
Repository: ambari
Description
-------
Modified "HAWQ Segment Temp Directory” from one [/d1/tmp/hawqsegment] to many [/d1/tmp/hawqsegment,/d2/tmp/hawqsegment,/d3/tmp/hawqsegment,/d4/tmp/hawqsegment,/d5/tmp/hawqsegment]
and the change is not propagated to segments and the folders are not created.
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py d62332d
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqsegment.py 0a597b6
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/master_helper.py 9482b35
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/params.py 1bdc5aa
ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqmaster.py 14b5a5f
ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqsegment.py 6ca83b7
ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqstandby.py eaba496
Diff: https://reviews.apache.org/r/44987/diff/
Testing (updated)
-------
manually tested.
test_configure_default (test_hawqsegment.TestHawqSegment) ... ok
test_install_default (test_hawqsegment.TestHawqSegment) ... ok
test_start_default (test_hawqsegment.TestHawqSegment) ... ok
test_stop_default (test_hawqsegment.TestHawqSegment) ... ok
test_hawq_master_critical (test_alert_component_status.TestAlertComponentStatus) ... ok
test_hawq_master_ok (test_alert_component_status.TestAlertComponentStatus) ... ok
test_hawq_segment_critical (test_alert_component_status.TestAlertComponentStatus) ... ok
test_hawq_segment_ok (test_alert_component_status.TestAlertComponentStatus) ... ok
test_hawq_standby_critical (test_alert_component_status.TestAlertComponentStatus) ... ok
test_hawq_standby_ok (test_alert_component_status.TestAlertComponentStatus) ... ok
test_missing_configs (test_alert_component_status.TestAlertComponentStatus) ... ok
test_configure_default (test_hawqstandby.TestHawqStandby) ... ok
test_install_default (test_hawqstandby.TestHawqStandby) ... ok
test_start_default (test_hawqstandby.TestHawqStandby) ... 2016-03-17 15:33:42,969 - Standby host c6401.ambari.apache.org initialized
ok
test_stop_default (test_hawqstandby.TestHawqStandby) ... ok
test_configure_default (test_hawqmaster.TestHawqMaster) ... ok
test_install_default (test_hawqmaster.TestHawqMaster) ... ok
test_start_default (test_hawqmaster.TestHawqMaster) ... 2016-03-17 15:33:43,025 - Active master c6401.ambari.apache.org initialized
ok
test_start_localmaster (test_hawqmaster.TestHawqMaster) ... 2016-03-17 15:33:43,049 - Master c6401.ambari.apache.org started
ok
test_stop_default (test_hawqmaster.TestHawqMaster) ... ok
Thanks,
jun aoki