You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cassandra.apache.org by "Shaurya Gupta (JIRA)" <ji...@apache.org> on 2019/01/28 03:51:00 UTC

[jira] [Commented] (CASSANDRA-14996) Incremental backups can fill up the disk if they are not being uploaded

    [ https://issues.apache.org/jira/browse/CASSANDRA-14996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16753678#comment-16753678 ] 

Shaurya Gupta commented on CASSANDRA-14996:
-------------------------------------------

I have attached a patch which gives the basic idea of what I am suggesting. If you find it broadly fine then I can work further on this issue.

> Incremental backups can fill up the disk if they are not being uploaded
> -----------------------------------------------------------------------
>
>                 Key: CASSANDRA-14996
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-14996
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Shaurya Gupta
>            Priority: Major
>         Attachments: patch_CASSANDRA-14996
>
>
> This creates a major problem if the script which uploads the snapshots is triggered via some API and the application triggering it is somehow down and is not able to hit the API. This affects Cassandra and slowly one or more Cassandra nodes go down.
> There could be a check in Cassandra that before creating a snapshot it checks that the disk has some sufficient (configurable via cassandra.yaml and jmx) disk space.
> This could be achieved by making change in 
> public void maybeIncrementallyBackup(final Iterable<SSTableReader> sstables)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org