You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Ross Gardler (JIRA)" <ji...@apache.org> on 2008/09/07 21:54:44 UTC
[jira] Created: (WICKET-1822) Wicket snapshot causes break in my
application test code
Wicket snapshot causes break in my application test code
--------------------------------------------------------
Key: WICKET-1822
URL: https://issues.apache.org/jira/browse/WICKET-1822
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 1.4-M4
Reporter: Ross Gardler
This may not be a bug in Wicket 1.4-SNAPSHOT, it may be intended behaviour. However, I don't see anything in the migrating wiki site [1], nor do I see any recent SVN log messages that make me think it's deliberate (not that I understand the nuances of your HEAD work) . Therefore I'm flagging it here for you folk can decide if it's a bug.
If I use 1.4-m3 all my tests pass, if I use 1.4-SNAPSHOT a couple of fail (details follow). The change happened between 07-Sep-2008 07:07:25 EST [3] and 08-Sep-2008 00:22:04 EST [4] (I can be very narrow on dates as our CI server flagged the problem, the first failing build is at [2]).
The failing tests both give the similar errors (full errors at [5] and [6]:
org.apache.wicket.WicketRuntimeException: Method onFormSubmitted of interface org.apache.wicket.markup.html.form.IFormSubmitListener targeted at component [MarkupContainer [Component id = uploadForm, page = uk.ac.osswatch.simal.wicket.doap.DoapFormPage, path = 0:uploadForm.DoapFormPage$FileUploadForm, isVisible = true, isVersioned = true]] threw an exception
at org.apache.wicket.RequestListenerInterface.invoke(RequestListenerInterface.java:193)
at org.apache.wicket.request.target.component.listener.ListenerInterfaceRequestTarget.processEvents(ListenerInterfaceRequestTarget.java:73)
at org.apache.wicket.request.AbstractRequestCycleProcessor.processEvents(AbstractRequestCycleProcessor.java:91)
at org.apache.wicket.RequestCycle.processEventsAndRespond(RequestCycle.java:1169)
....
Caused by: java.lang.reflect.InvocationTargetException
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
...
Caused by: java.lang.IllegalStateException: Attempt to set model object on null model of component: uploadForm:fileInput
at org.apache.wicket.Component.setDefaultModelObject(Component.java:2969)
at org.apache.wicket.markup.html.form.FormComponent.updateModel(FormComponent.java:1086)
at org.apache.wicket.markup.html.form.Form$20.validate(Form.java:1883)
So, first question. Is this an intentional change in the way models for forms are handled. If so, what do I need to do to make my code work. If it is unintentional but you have no idea what is going on then let me know and I'll submit some test code to this issue.
Ross
[1] http://cwiki.apache.org/WICKET/migrate-14.html
[2] http://16degrees.com.au/hudson/job/SimalWebappSVN/956/
[3] http://www.timeanddate.com/worldclock/fixedtime.html?day=7&month=9&year=2008&hour=7&min=7&sec=25&p1=57
[4] http://www.timeanddate.com/worldclock/fixedtime.html?day=8&month=9&year=2008&hour=0&min=22&sec=04&p1=57
[5] http://16degrees.com.au/hudson/job/SimalWebappSVN/uk.ac.osswatch$simal-webapp/956/testReport/uk.ac.osswatch.simal.wicket.doap/TestDoapFormPage/testAddByUpload/
[6] http://16degrees.com.au/hudson/job/SimalWebappSVN/uk.ac.osswatch$simal-webapp/956/testReport/uk.ac.osswatch.simal.wicket.doap/TestDoapFormPage/testUploadedFile/
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1822) Wicket snapshot causes break in my
application test code
Posted by "Ross Gardler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12629005#action_12629005 ]
Ross Gardler commented on WICKET-1822:
--------------------------------------
To be clear, the tests I refer to are not Wicket tests, but tests in my application using Wicket.
> Wicket snapshot causes break in my application test code
> --------------------------------------------------------
>
> Key: WICKET-1822
> URL: https://issues.apache.org/jira/browse/WICKET-1822
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4-M4
> Reporter: Ross Gardler
>
> This may not be a bug in Wicket 1.4-SNAPSHOT, it may be intended behaviour. However, I don't see anything in the migrating wiki site [1], nor do I see any recent SVN log messages that make me think it's deliberate (not that I understand the nuances of your HEAD work) . Therefore I'm flagging it here for you folk can decide if it's a bug.
> If I use 1.4-m3 all my tests pass, if I use 1.4-SNAPSHOT a couple of fail (details follow). The change happened between 07-Sep-2008 07:07:25 EST [3] and 08-Sep-2008 00:22:04 EST [4] (I can be very narrow on dates as our CI server flagged the problem, the first failing build is at [2]).
> The failing tests both give the similar errors (full errors at [5] and [6]:
> org.apache.wicket.WicketRuntimeException: Method onFormSubmitted of interface org.apache.wicket.markup.html.form.IFormSubmitListener targeted at component [MarkupContainer [Component id = uploadForm, page = uk.ac.osswatch.simal.wicket.doap.DoapFormPage, path = 0:uploadForm.DoapFormPage$FileUploadForm, isVisible = true, isVersioned = true]] threw an exception
> at org.apache.wicket.RequestListenerInterface.invoke(RequestListenerInterface.java:193)
> at org.apache.wicket.request.target.component.listener.ListenerInterfaceRequestTarget.processEvents(ListenerInterfaceRequestTarget.java:73)
> at org.apache.wicket.request.AbstractRequestCycleProcessor.processEvents(AbstractRequestCycleProcessor.java:91)
> at org.apache.wicket.RequestCycle.processEventsAndRespond(RequestCycle.java:1169)
> ....
> Caused by: java.lang.reflect.InvocationTargetException
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> ...
> Caused by: java.lang.IllegalStateException: Attempt to set model object on null model of component: uploadForm:fileInput
> at org.apache.wicket.Component.setDefaultModelObject(Component.java:2969)
> at org.apache.wicket.markup.html.form.FormComponent.updateModel(FormComponent.java:1086)
> at org.apache.wicket.markup.html.form.Form$20.validate(Form.java:1883)
> So, first question. Is this an intentional change in the way models for forms are handled. If so, what do I need to do to make my code work. If it is unintentional but you have no idea what is going on then let me know and I'll submit some test code to this issue.
> Ross
> [1] http://cwiki.apache.org/WICKET/migrate-14.html
> [2] http://16degrees.com.au/hudson/job/SimalWebappSVN/956/
> [3] http://www.timeanddate.com/worldclock/fixedtime.html?day=7&month=9&year=2008&hour=7&min=7&sec=25&p1=57
> [4] http://www.timeanddate.com/worldclock/fixedtime.html?day=8&month=9&year=2008&hour=0&min=22&sec=04&p1=57
> [5] http://16degrees.com.au/hudson/job/SimalWebappSVN/uk.ac.osswatch$simal-webapp/956/testReport/uk.ac.osswatch.simal.wicket.doap/TestDoapFormPage/testAddByUpload/
> [6] http://16degrees.com.au/hudson/job/SimalWebappSVN/uk.ac.osswatch$simal-webapp/956/testReport/uk.ac.osswatch.simal.wicket.doap/TestDoapFormPage/testUploadedFile/
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-1822) Wicket snapshot causes break in my
application test code
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg resolved WICKET-1822.
-----------------------------------
Resolution: Invalid
Assignee: Igor Vaynberg
this change is intentional as it aligns the fileuploadfield componments with the rest of wicket components - eg they always use their model by default. if you want to go to the old-style and not use the model then you have to call sethasexplicitmodel(false).
> Wicket snapshot causes break in my application test code
> --------------------------------------------------------
>
> Key: WICKET-1822
> URL: https://issues.apache.org/jira/browse/WICKET-1822
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4-M4
> Reporter: Ross Gardler
> Assignee: Igor Vaynberg
>
> This may not be a bug in Wicket 1.4-SNAPSHOT, it may be intended behaviour. However, I don't see anything in the migrating wiki site [1], nor do I see any recent SVN log messages that make me think it's deliberate (not that I understand the nuances of your HEAD work) . Therefore I'm flagging it here for you folk can decide if it's a bug.
> If I use 1.4-m3 all my tests pass, if I use 1.4-SNAPSHOT a couple of fail (details follow). The change happened between 07-Sep-2008 07:07:25 EST [3] and 08-Sep-2008 00:22:04 EST [4] (I can be very narrow on dates as our CI server flagged the problem, the first failing build is at [2]).
> The failing tests both give the similar errors (full errors at [5] and [6]:
> org.apache.wicket.WicketRuntimeException: Method onFormSubmitted of interface org.apache.wicket.markup.html.form.IFormSubmitListener targeted at component [MarkupContainer [Component id = uploadForm, page = uk.ac.osswatch.simal.wicket.doap.DoapFormPage, path = 0:uploadForm.DoapFormPage$FileUploadForm, isVisible = true, isVersioned = true]] threw an exception
> at org.apache.wicket.RequestListenerInterface.invoke(RequestListenerInterface.java:193)
> at org.apache.wicket.request.target.component.listener.ListenerInterfaceRequestTarget.processEvents(ListenerInterfaceRequestTarget.java:73)
> at org.apache.wicket.request.AbstractRequestCycleProcessor.processEvents(AbstractRequestCycleProcessor.java:91)
> at org.apache.wicket.RequestCycle.processEventsAndRespond(RequestCycle.java:1169)
> ....
> Caused by: java.lang.reflect.InvocationTargetException
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> ...
> Caused by: java.lang.IllegalStateException: Attempt to set model object on null model of component: uploadForm:fileInput
> at org.apache.wicket.Component.setDefaultModelObject(Component.java:2969)
> at org.apache.wicket.markup.html.form.FormComponent.updateModel(FormComponent.java:1086)
> at org.apache.wicket.markup.html.form.Form$20.validate(Form.java:1883)
> So, first question. Is this an intentional change in the way models for forms are handled. If so, what do I need to do to make my code work. If it is unintentional but you have no idea what is going on then let me know and I'll submit some test code to this issue.
> Ross
> [1] http://cwiki.apache.org/WICKET/migrate-14.html
> [2] http://16degrees.com.au/hudson/job/SimalWebappSVN/956/
> [3] http://www.timeanddate.com/worldclock/fixedtime.html?day=7&month=9&year=2008&hour=7&min=7&sec=25&p1=57
> [4] http://www.timeanddate.com/worldclock/fixedtime.html?day=8&month=9&year=2008&hour=0&min=22&sec=04&p1=57
> [5] http://16degrees.com.au/hudson/job/SimalWebappSVN/uk.ac.osswatch$simal-webapp/956/testReport/uk.ac.osswatch.simal.wicket.doap/TestDoapFormPage/testAddByUpload/
> [6] http://16degrees.com.au/hudson/job/SimalWebappSVN/uk.ac.osswatch$simal-webapp/956/testReport/uk.ac.osswatch.simal.wicket.doap/TestDoapFormPage/testUploadedFile/
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.