[PATCH] improved bash completion v5

[Fabien COELHO <fa...@coelho.net>]

Yet another submission. I like to complete what I start...

It addresses Julian comments on v4.

Difference with v4 :
  - SVN_ -> SVN_BASH_ env variable.
  - remove "ugly" completion messages, put simple beeps instead.
  - remove misinterpreted diff subcommand number of arguments.
  - fix number of arguments in swith without relocate option (was just a typo).
  - suggest revision completion also after -r, not only --revision.

Julian, if you don't like the two beeps/spaces, just remove the offending 
line so that it defaults to ordinary file completion. I may look later to 
your suggestion about removing the default completion from "complete" and 
then add it back later when appropriate with "compgen".

[[[
Improve bash auto-completion for the 'svn' command:
  - there is a "real" parser to check for what is available
    and deduce what can be suggested further.
  - although it is not a good practice, mixed options and arguments
    is supported by the completion as it is by the svn command.
  - the completion works in the middle of a line.
  - property names are completed: see comments about issues related to handling
    ":" within property names although it is a word completion separator...
  - user-defined file and revision properties can be added with
    environment variables SVN_BASH_FILE_PROPS and SVN_BASH_REV_PROPS.
  - unknown properties are assumed to be simple file properties.
  - --revprop and --revision options are forced to revision properties
    as they are mandatory in this case.
  - argument values are suggested to some other options, eg directory names
    for --config-dir.
  - values suggested to some options can be extended with environment variables,
    so as to keep the default completion list short.

* tools/client-side/bash_completion
   add shell-intelligence to _svn completion function
]]]

-- 
Fabien

Re: [PATCH] improved bash completion v5

[Fabien COELHO <fa...@coelho.net>]

> I have committed this version 5 (with cosmetic tweaks to 
> comments and white space) in r17458.

Ok. Thanks for all the debugging.

-- 
Fabien.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] improved bash completion v5

[Julian Foad <ju...@btopenworld.com>]

Fabien COELHO wrote:
> 
> Yet another submission. I like to complete what I start...
> 
> It addresses Julian comments on v4.

OK, thanks.  I have committed this version 5 (with cosmetic tweaks to comments 
and white space) in r17458.

> Julian, if you don't like the two beeps/spaces, just remove the 
> offending line so that it defaults to ordinary file completion. I may 

I don't like it, but as you prefer it that way and you are more interested in 
using this than I am, I have left it that way.

> look later to your suggestion about removing the default completion from 
> "complete" and then add it back later when appropriate with "compgen".


> [[[
> Improve bash auto-completion for the 'svn' command:
>  - there is a "real" parser to check for what is available
>    and deduce what can be suggested further.
>  - although it is not a good practice, mixed options and arguments
>    is supported by the completion as it is by the svn command.
>  - the completion works in the middle of a line.
>  - property names are completed: see comments about issues related to 
> handling
>    ":" within property names although it is a word completion separator...
>  - user-defined file and revision properties can be added with
>    environment variables SVN_BASH_FILE_PROPS and SVN_BASH_REV_PROPS.
>  - unknown properties are assumed to be simple file properties.
>  - --revprop and --revision options are forced to revision properties
>    as they are mandatory in this case.
>  - argument values are suggested to some other options, eg directory names
>    for --config-dir.
>  - values suggested to some options can be extended with environment 
> variables,
>    so as to keep the default completion list short.
> 
> * tools/client-side/bash_completion
>   add shell-intelligence to _svn completion function
> ]]]

I moved the comments about what it does into the file, and left in the log 
message only a brief summary of what was changed.

I hope this is OK.  Thanks for your patience.

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org