You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2019/09/18 20:05:00 UTC
[jira] [Work logged] (BEAM-7629) Improve DoFn method validation in
core/graph/fn.go
[ https://issues.apache.org/jira/browse/BEAM-7629?focusedWorklogId=314616&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-314616 ]
ASF GitHub Bot logged work on BEAM-7629:
----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Sep/19 20:04
Start Date: 18/Sep/19 20:04
Worklog Time Spent: 10m
Work Description: youngoli commented on issue #9609: [BEAM-7629] Go SDK: Refactoring fn order validation (INCOMPLETE)
URL: https://github.com/apache/beam/pull/9609#issuecomment-532844383
Note: This PR is not complete yet. Still needs some unit testing done and to have all the commits squashed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 314616)
Time Spent: 1h 10m (was: 1h)
> Improve DoFn method validation in core/graph/fn.go
> --------------------------------------------------
>
> Key: BEAM-7629
> URL: https://issues.apache.org/jira/browse/BEAM-7629
> Project: Beam
> Issue Type: Improvement
> Components: sdk-go
> Reporter: Daniel Oliveira
> Assignee: Daniel Oliveira
> Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Various improvements can be made to validating the signatures and type usages in DoFns. Some things that should probably be checked:
> * Check that StartBundle and FinishBundle contain any emit parameters and side inputs present in ProcessElement
> * Check that any side inputs/emits have correctly matching types between Start/FinishBundle and ProcessElement
> * Check that parameters and return values for the various methods are valid (for ex. Teardown/Setup should have no params)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)