You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@zookeeper.apache.org by "Chen Zhi (Jira)" <ji...@apache.org> on 2020/09/22 17:25:00 UTC

[jira] [Commented] (ZOOKEEPER-3942) move traceMask calculation logic into the trace log guard

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-3942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17200255#comment-17200255 ] 

Chen Zhi commented on ZOOKEEPER-3942:
-------------------------------------

Issue resolved by pull request 1464, please review it

https://github.com/apache/zookeeper/pull/1464

> move traceMask calculation logic into the trace log guard
> ---------------------------------------------------------
>
>                 Key: ZOOKEEPER-3942
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3942
>             Project: ZooKeeper
>          Issue Type: Improvement
>            Reporter: Chen Zhi
>            Priority: Minor
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Similar to ZOOKEEPER-3708 and ZOOKEEPER-3728 in Learner,  I found four cases where traceMask calculation logic are out of trace log guard in LearnerHandler, PrepRequestProcessor, and ReadOnlyRequestProcessor. The traceMask only matters if trace is enabled, so move the associated code into the logging guard. The fix is simple and I will create a PR later.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)