You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2022/01/13 18:25:56 UTC

[GitHub] [zeppelin] woowahan-jaehoon opened a new pull request #4287: [ZEPPELIN-5631] block notebook listed when user didn't have owner/reader/admin

woowahan-jaehoon opened a new pull request #4287:
URL: https://github.com/apache/zeppelin/pull/4287


   ### What is this PR for?
   Block notebook listed when user didn't have owner/reader/admin.
   
   When I upgraded zeppelin 0.7 to 0.9, all notebooks are listed all users even if public option was disabled.
   
   `Runner` permission is added after 0.7 so when upgrade 0.7 to 0.9, runner permission is set blank(all user allowed). user who has runner permission is allowed to read notebook, current logic.
   
   
   ### What type of PR is it?
   [Bug Fix]
   
   ### Todos
   * Nothing
   
   ### What is the Jira issue?
   * https://issues.apache.org/jira/browse/ZEPPELIN-5631
   
   ### How should this be tested?
   * Set black to runner permission in notebook
   
   ### Screenshots (if appropriate)
   
   ### Questions:
   * Does the licenses files need update?
   ** No
   * Is there breaking changes for older versions?
   ** No
   * Does this needs documentation?
   ** No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zeppelin] zjffdu commented on pull request #4287: [ZEPPELIN-5631] block notebook listed when user didn't have owner/reader/admin

Posted by GitBox <gi...@apache.org>.
zjffdu commented on pull request #4287:
URL: https://github.com/apache/zeppelin/pull/4287#issuecomment-1022815886


   Should we fix it in the upgrading tool via setting the runner as the reader?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zeppelin] woowahan-jaehoon commented on pull request #4287: [ZEPPELIN-5631] block notebook listed when user didn't have owner/reader/admin

Posted by GitBox <gi...@apache.org>.
woowahan-jaehoon commented on pull request #4287:
URL: https://github.com/apache/zeppelin/pull/4287#issuecomment-1055108873


   > 
   
   I think that it is not enough that only apply upgrading tool because user can remove runner permission.
   
   Possible to read notebook for runner without read permission is allowed?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org