You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@samza.apache.org by Jagadish Venkatraman <ja...@gmail.com> on 2016/05/21 01:39:21 UTC
Re: Review Request 47687: Merged patch 44920
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47687/
-----------------------------------------------------------
(Updated May 21, 2016, 1:39 a.m.)
Review request for samza, Yi Pan (Data Infrastructure) and Navina Ramesh.
Repository: samza
Description
-------
This is a merged patch of RB:44920. This is created because I lost the local branch of RB:44920.
Diffs (updated)
-----
checkstyle/import-control.xml fad7b55a540a2f9886a3bfdf7631d9661b602d29
samza-core/src/main/java/org/apache/samza/clustermanager/AbstractContainerAllocator.java PRE-CREATION
samza-core/src/main/java/org/apache/samza/clustermanager/ClusterBasedJobCoordinator.java PRE-CREATION
samza-core/src/main/java/org/apache/samza/clustermanager/ClusterResourceManager.java PRE-CREATION
samza-core/src/main/java/org/apache/samza/clustermanager/ContainerAllocator.java PRE-CREATION
samza-core/src/main/java/org/apache/samza/clustermanager/ContainerProcessManager.java PRE-CREATION
samza-core/src/main/java/org/apache/samza/clustermanager/HostAwareContainerAllocator.java PRE-CREATION
samza-core/src/main/java/org/apache/samza/clustermanager/ResourceFailure.java PRE-CREATION
samza-core/src/main/java/org/apache/samza/clustermanager/ResourceManagerFactory.java PRE-CREATION
samza-core/src/main/java/org/apache/samza/clustermanager/ResourceRequestState.java PRE-CREATION
samza-core/src/main/java/org/apache/samza/clustermanager/SamzaApplicationState.java PRE-CREATION
samza-core/src/main/java/org/apache/samza/clustermanager/SamzaContainerLaunchException.java PRE-CREATION
samza-core/src/main/java/org/apache/samza/clustermanager/SamzaResource.java PRE-CREATION
samza-core/src/main/java/org/apache/samza/clustermanager/SamzaResourceRequest.java PRE-CREATION
samza-core/src/main/java/org/apache/samza/clustermanager/SamzaResourceStatus.java PRE-CREATION
samza-core/src/main/java/org/apache/samza/config/ClusterManagerConfig.java PRE-CREATION
samza-core/src/main/java/org/apache/samza/container/LocalityManager.java a3281c2c5f481a78cc4ae791c77d0e9805202477
samza-core/src/main/java/org/apache/samza/container/grouper/task/TaskAssignmentManager.java 0cbdec8ac050de18c2fea191e3ef38273f1dbab1
samza-core/src/main/java/org/apache/samza/storage/StorageRecovery.java 0324e90a20c2fd31d1b7c6a0707aa3685a1cec20
samza-core/src/main/scala/org/apache/samza/checkpoint/CheckpointTool.scala 31b208f47b12a4e9ef1134b1c0bfe532f6c07a80
samza-core/src/main/scala/org/apache/samza/coordinator/JobCoordinator.scala 03f48db7f42b2617995b14cf51248b82b6cc2636
samza-core/src/main/scala/org/apache/samza/job/local/ProcessJob.scala 95d01dd15d369dcb2255154163bc2cd50d7b84e0
samza-core/src/main/scala/org/apache/samza/job/local/ProcessJobFactory.scala 81ef59a8e2fd2745aa37a65074400b64c406bc28
samza-core/src/main/scala/org/apache/samza/job/local/ThreadJobFactory.scala 5acfe875d3a3d9842497e646f0f04ea2861ae950
samza-core/src/main/scala/org/apache/samza/metrics/ContainerProcessManagerMetrics.scala PRE-CREATION
samza-core/src/test/java/org/apache/samza/clustermanager/MockClusterResourceManager.java PRE-CREATION
samza-core/src/test/java/org/apache/samza/clustermanager/MockClusterResourceManagerCallback.java PRE-CREATION
samza-core/src/test/java/org/apache/samza/clustermanager/MockContainerAllocator.java PRE-CREATION
samza-core/src/test/java/org/apache/samza/clustermanager/MockContainerListener.java PRE-CREATION
samza-core/src/test/java/org/apache/samza/clustermanager/MockContainerRequestState.java PRE-CREATION
samza-core/src/test/java/org/apache/samza/clustermanager/MockHttpServer.java PRE-CREATION
samza-core/src/test/java/org/apache/samza/clustermanager/TestContainerAllocator.java PRE-CREATION
samza-core/src/test/java/org/apache/samza/clustermanager/TestContainerProcessManager.java PRE-CREATION
samza-core/src/test/java/org/apache/samza/clustermanager/TestContainerRequestState.java PRE-CREATION
samza-core/src/test/java/org/apache/samza/clustermanager/TestHostAwareContainerAllocator.java PRE-CREATION
samza-core/src/test/scala/org/apache/samza/container/TestSamzaContainer.scala 9df12d2974c686c07457b29d873fd3e9dab72e21
samza-core/src/test/scala/org/apache/samza/coordinator/TestJobCoordinator.scala 110c3a910aa0bae77dfe5eebbf82286b56dc4654
samza-core/src/test/scala/org/apache/samza/job/local/TestProcessJob.scala 3a710a82f6104dcbdcfcb9f166fe05003074c4b0
samza-log4j/src/main/java/org/apache/samza/logging/log4j/StreamAppender.java 0c6329ede9b3df4dc05125729b5b44ba2c98803a
samza-shell/src/main/bash/run-am.sh 9545a96953baaff17ad14962e02bc12aadbb1101
samza-shell/src/main/bash/run-jc.sh PRE-CREATION
samza-yarn/src/main/java/org/apache/samza/job/yarn/SamzaAppState.java 77280bab8aeb242b34b5b780c84e6deab1a45f51
samza-yarn/src/main/java/org/apache/samza/job/yarn/SamzaTaskManager.java caee6e6c182d3cf86bd4fe193f8b1797605b2480
samza-yarn/src/main/java/org/apache/samza/job/yarn/YarnAppState.java PRE-CREATION
samza-yarn/src/main/java/org/apache/samza/job/yarn/YarnClusterResourceManager.java PRE-CREATION
samza-yarn/src/main/java/org/apache/samza/job/yarn/YarnContainerRunner.java PRE-CREATION
samza-yarn/src/main/java/org/apache/samza/job/yarn/YarnResourceManagerFactory.java PRE-CREATION
samza-yarn/src/main/java/org/apache/samza/validation/YarnJobValidationTool.java 70f1e4f7663560e61b7aaa757946adbe03d2bd76
samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMaster.scala 80deb3b18c094d83af67535f9d0156f18ae3f5e4
samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaYarnAppMasterLifecycle.scala PRE-CREATION
samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaYarnAppMasterService.scala PRE-CREATION
samza-yarn/src/test/java/org/apache/samza/job/yarn/TestContainerAllocatorCommon.java 5badd29af601ce0a046ef7dce4739e31514c4e63
samza-yarn/src/test/java/org/apache/samza/job/yarn/TestSamzaTaskManager.java faa697db49ec1c11d76c88d919a356a5ae409a15
samza-yarn/src/test/scala/org/apache/samza/job/yarn/TestSamzaAppMasterLifecycle.scala 30cf34fe1fd3f74537d16e8a51b467cd50835357
samza-yarn/src/test/scala/org/apache/samza/job/yarn/TestSamzaAppMasterService.scala 7f5d9f4af088589d4287c26737bae25567c157d7
Diff: https://reviews.apache.org/r/47687/diff/
Testing
-------
Thanks,
Jagadish Venkatraman
Re: Review Request 47687: Merged patch 44920
Posted by "Yi Pan (Data Infrastructure)" <yi...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47687/#review135346
-----------------------------------------------------------
Ship it!
Ship It!
- Yi Pan (Data Infrastructure)
On May 23, 2016, 6:34 p.m., Jagadish Venkatraman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47687/
> -----------------------------------------------------------
>
> (Updated May 23, 2016, 6:34 p.m.)
>
>
> Review request for samza, Yi Pan (Data Infrastructure) and Navina Ramesh.
>
>
> Repository: samza
>
>
> Description
> -------
>
> This is a merged patch of RB:44920. This is created because I lost the local branch of RB:44920.
>
>
> Diffs
> -----
>
> checkstyle/import-control.xml fad7b55a540a2f9886a3bfdf7631d9661b602d29
> samza-core/src/main/java/org/apache/samza/clustermanager/AbstractContainerAllocator.java PRE-CREATION
> samza-core/src/main/java/org/apache/samza/clustermanager/ClusterBasedJobCoordinator.java PRE-CREATION
> samza-core/src/main/java/org/apache/samza/clustermanager/ClusterResourceManager.java PRE-CREATION
> samza-core/src/main/java/org/apache/samza/clustermanager/ContainerAllocator.java PRE-CREATION
> samza-core/src/main/java/org/apache/samza/clustermanager/ContainerProcessManager.java PRE-CREATION
> samza-core/src/main/java/org/apache/samza/clustermanager/HostAwareContainerAllocator.java PRE-CREATION
> samza-core/src/main/java/org/apache/samza/clustermanager/ResourceFailure.java PRE-CREATION
> samza-core/src/main/java/org/apache/samza/clustermanager/ResourceManagerFactory.java PRE-CREATION
> samza-core/src/main/java/org/apache/samza/clustermanager/ResourceRequestState.java PRE-CREATION
> samza-core/src/main/java/org/apache/samza/clustermanager/SamzaApplicationState.java PRE-CREATION
> samza-core/src/main/java/org/apache/samza/clustermanager/SamzaContainerLaunchException.java PRE-CREATION
> samza-core/src/main/java/org/apache/samza/clustermanager/SamzaResource.java PRE-CREATION
> samza-core/src/main/java/org/apache/samza/clustermanager/SamzaResourceRequest.java PRE-CREATION
> samza-core/src/main/java/org/apache/samza/clustermanager/SamzaResourceStatus.java PRE-CREATION
> samza-core/src/main/java/org/apache/samza/config/ClusterManagerConfig.java PRE-CREATION
> samza-core/src/main/java/org/apache/samza/container/LocalityManager.java a3281c2c5f481a78cc4ae791c77d0e9805202477
> samza-core/src/main/java/org/apache/samza/container/grouper/task/TaskAssignmentManager.java 6473dfba294094a2408d167faa72640281503114
> samza-core/src/main/java/org/apache/samza/storage/StorageRecovery.java 0324e90a20c2fd31d1b7c6a0707aa3685a1cec20
> samza-core/src/main/scala/org/apache/samza/checkpoint/CheckpointTool.scala 31b208f47b12a4e9ef1134b1c0bfe532f6c07a80
> samza-core/src/main/scala/org/apache/samza/coordinator/JobCoordinator.scala bd7f3f59eec62e9a0a0d6b0c3e4a4297f3cef7fa
> samza-core/src/main/scala/org/apache/samza/job/local/ProcessJob.scala 95d01dd15d369dcb2255154163bc2cd50d7b84e0
> samza-core/src/main/scala/org/apache/samza/job/local/ProcessJobFactory.scala 81ef59a8e2fd2745aa37a65074400b64c406bc28
> samza-core/src/main/scala/org/apache/samza/job/local/ThreadJobFactory.scala 5acfe875d3a3d9842497e646f0f04ea2861ae950
> samza-core/src/main/scala/org/apache/samza/metrics/ContainerProcessManagerMetrics.scala PRE-CREATION
> samza-core/src/test/java/org/apache/samza/clustermanager/MockClusterResourceManager.java PRE-CREATION
> samza-core/src/test/java/org/apache/samza/clustermanager/MockClusterResourceManagerCallback.java PRE-CREATION
> samza-core/src/test/java/org/apache/samza/clustermanager/MockContainerAllocator.java PRE-CREATION
> samza-core/src/test/java/org/apache/samza/clustermanager/MockContainerListener.java PRE-CREATION
> samza-core/src/test/java/org/apache/samza/clustermanager/MockContainerRequestState.java PRE-CREATION
> samza-core/src/test/java/org/apache/samza/clustermanager/MockHttpServer.java PRE-CREATION
> samza-core/src/test/java/org/apache/samza/clustermanager/TestContainerAllocator.java PRE-CREATION
> samza-core/src/test/java/org/apache/samza/clustermanager/TestContainerProcessManager.java PRE-CREATION
> samza-core/src/test/java/org/apache/samza/clustermanager/TestContainerRequestState.java PRE-CREATION
> samza-core/src/test/java/org/apache/samza/clustermanager/TestHostAwareContainerAllocator.java PRE-CREATION
> samza-core/src/test/scala/org/apache/samza/container/TestSamzaContainer.scala 9df12d2974c686c07457b29d873fd3e9dab72e21
> samza-core/src/test/scala/org/apache/samza/coordinator/TestJobCoordinator.scala 110c3a910aa0bae77dfe5eebbf82286b56dc4654
> samza-core/src/test/scala/org/apache/samza/job/local/TestProcessJob.scala 3a710a82f6104dcbdcfcb9f166fe05003074c4b0
> samza-log4j/src/main/java/org/apache/samza/logging/log4j/StreamAppender.java 0c6329ede9b3df4dc05125729b5b44ba2c98803a
> samza-shell/src/main/bash/run-am.sh 9545a96953baaff17ad14962e02bc12aadbb1101
> samza-shell/src/main/bash/run-jc.sh PRE-CREATION
> samza-yarn/src/main/java/org/apache/samza/job/yarn/SamzaAppState.java 77280bab8aeb242b34b5b780c84e6deab1a45f51
> samza-yarn/src/main/java/org/apache/samza/job/yarn/SamzaTaskManager.java caee6e6c182d3cf86bd4fe193f8b1797605b2480
> samza-yarn/src/main/java/org/apache/samza/job/yarn/YarnAppState.java PRE-CREATION
> samza-yarn/src/main/java/org/apache/samza/job/yarn/YarnClusterResourceManager.java PRE-CREATION
> samza-yarn/src/main/java/org/apache/samza/job/yarn/YarnContainerRunner.java PRE-CREATION
> samza-yarn/src/main/java/org/apache/samza/job/yarn/YarnResourceManagerFactory.java PRE-CREATION
> samza-yarn/src/main/java/org/apache/samza/validation/YarnJobValidationTool.java 70f1e4f7663560e61b7aaa757946adbe03d2bd76
> samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMaster.scala 80deb3b18c094d83af67535f9d0156f18ae3f5e4
> samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaYarnAppMasterLifecycle.scala PRE-CREATION
> samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaYarnAppMasterService.scala PRE-CREATION
> samza-yarn/src/test/java/org/apache/samza/job/yarn/TestContainerAllocatorCommon.java 5badd29af601ce0a046ef7dce4739e31514c4e63
> samza-yarn/src/test/java/org/apache/samza/job/yarn/TestSamzaTaskManager.java faa697db49ec1c11d76c88d919a356a5ae409a15
> samza-yarn/src/test/scala/org/apache/samza/job/yarn/TestSamzaAppMasterLifecycle.scala 30cf34fe1fd3f74537d16e8a51b467cd50835357
> samza-yarn/src/test/scala/org/apache/samza/job/yarn/TestSamzaAppMasterService.scala 7f5d9f4af088589d4287c26737bae25567c157d7
>
> Diff: https://reviews.apache.org/r/47687/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jagadish Venkatraman
>
>
Re: Review Request 47687: Merged patch 44920
Posted by Jagadish Venkatraman <ja...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47687/
-----------------------------------------------------------
(Updated May 23, 2016, 6:34 p.m.)
Review request for samza, Yi Pan (Data Infrastructure) and Navina Ramesh.
Changes
-------
rebase until current master . sigh.
Repository: samza
Description
-------
This is a merged patch of RB:44920. This is created because I lost the local branch of RB:44920.
Diffs (updated)
-----
checkstyle/import-control.xml fad7b55a540a2f9886a3bfdf7631d9661b602d29
samza-core/src/main/java/org/apache/samza/clustermanager/AbstractContainerAllocator.java PRE-CREATION
samza-core/src/main/java/org/apache/samza/clustermanager/ClusterBasedJobCoordinator.java PRE-CREATION
samza-core/src/main/java/org/apache/samza/clustermanager/ClusterResourceManager.java PRE-CREATION
samza-core/src/main/java/org/apache/samza/clustermanager/ContainerAllocator.java PRE-CREATION
samza-core/src/main/java/org/apache/samza/clustermanager/ContainerProcessManager.java PRE-CREATION
samza-core/src/main/java/org/apache/samza/clustermanager/HostAwareContainerAllocator.java PRE-CREATION
samza-core/src/main/java/org/apache/samza/clustermanager/ResourceFailure.java PRE-CREATION
samza-core/src/main/java/org/apache/samza/clustermanager/ResourceManagerFactory.java PRE-CREATION
samza-core/src/main/java/org/apache/samza/clustermanager/ResourceRequestState.java PRE-CREATION
samza-core/src/main/java/org/apache/samza/clustermanager/SamzaApplicationState.java PRE-CREATION
samza-core/src/main/java/org/apache/samza/clustermanager/SamzaContainerLaunchException.java PRE-CREATION
samza-core/src/main/java/org/apache/samza/clustermanager/SamzaResource.java PRE-CREATION
samza-core/src/main/java/org/apache/samza/clustermanager/SamzaResourceRequest.java PRE-CREATION
samza-core/src/main/java/org/apache/samza/clustermanager/SamzaResourceStatus.java PRE-CREATION
samza-core/src/main/java/org/apache/samza/config/ClusterManagerConfig.java PRE-CREATION
samza-core/src/main/java/org/apache/samza/container/LocalityManager.java a3281c2c5f481a78cc4ae791c77d0e9805202477
samza-core/src/main/java/org/apache/samza/container/grouper/task/TaskAssignmentManager.java 6473dfba294094a2408d167faa72640281503114
samza-core/src/main/java/org/apache/samza/storage/StorageRecovery.java 0324e90a20c2fd31d1b7c6a0707aa3685a1cec20
samza-core/src/main/scala/org/apache/samza/checkpoint/CheckpointTool.scala 31b208f47b12a4e9ef1134b1c0bfe532f6c07a80
samza-core/src/main/scala/org/apache/samza/coordinator/JobCoordinator.scala bd7f3f59eec62e9a0a0d6b0c3e4a4297f3cef7fa
samza-core/src/main/scala/org/apache/samza/job/local/ProcessJob.scala 95d01dd15d369dcb2255154163bc2cd50d7b84e0
samza-core/src/main/scala/org/apache/samza/job/local/ProcessJobFactory.scala 81ef59a8e2fd2745aa37a65074400b64c406bc28
samza-core/src/main/scala/org/apache/samza/job/local/ThreadJobFactory.scala 5acfe875d3a3d9842497e646f0f04ea2861ae950
samza-core/src/main/scala/org/apache/samza/metrics/ContainerProcessManagerMetrics.scala PRE-CREATION
samza-core/src/test/java/org/apache/samza/clustermanager/MockClusterResourceManager.java PRE-CREATION
samza-core/src/test/java/org/apache/samza/clustermanager/MockClusterResourceManagerCallback.java PRE-CREATION
samza-core/src/test/java/org/apache/samza/clustermanager/MockContainerAllocator.java PRE-CREATION
samza-core/src/test/java/org/apache/samza/clustermanager/MockContainerListener.java PRE-CREATION
samza-core/src/test/java/org/apache/samza/clustermanager/MockContainerRequestState.java PRE-CREATION
samza-core/src/test/java/org/apache/samza/clustermanager/MockHttpServer.java PRE-CREATION
samza-core/src/test/java/org/apache/samza/clustermanager/TestContainerAllocator.java PRE-CREATION
samza-core/src/test/java/org/apache/samza/clustermanager/TestContainerProcessManager.java PRE-CREATION
samza-core/src/test/java/org/apache/samza/clustermanager/TestContainerRequestState.java PRE-CREATION
samza-core/src/test/java/org/apache/samza/clustermanager/TestHostAwareContainerAllocator.java PRE-CREATION
samza-core/src/test/scala/org/apache/samza/container/TestSamzaContainer.scala 9df12d2974c686c07457b29d873fd3e9dab72e21
samza-core/src/test/scala/org/apache/samza/coordinator/TestJobCoordinator.scala 110c3a910aa0bae77dfe5eebbf82286b56dc4654
samza-core/src/test/scala/org/apache/samza/job/local/TestProcessJob.scala 3a710a82f6104dcbdcfcb9f166fe05003074c4b0
samza-log4j/src/main/java/org/apache/samza/logging/log4j/StreamAppender.java 0c6329ede9b3df4dc05125729b5b44ba2c98803a
samza-shell/src/main/bash/run-am.sh 9545a96953baaff17ad14962e02bc12aadbb1101
samza-shell/src/main/bash/run-jc.sh PRE-CREATION
samza-yarn/src/main/java/org/apache/samza/job/yarn/SamzaAppState.java 77280bab8aeb242b34b5b780c84e6deab1a45f51
samza-yarn/src/main/java/org/apache/samza/job/yarn/SamzaTaskManager.java caee6e6c182d3cf86bd4fe193f8b1797605b2480
samza-yarn/src/main/java/org/apache/samza/job/yarn/YarnAppState.java PRE-CREATION
samza-yarn/src/main/java/org/apache/samza/job/yarn/YarnClusterResourceManager.java PRE-CREATION
samza-yarn/src/main/java/org/apache/samza/job/yarn/YarnContainerRunner.java PRE-CREATION
samza-yarn/src/main/java/org/apache/samza/job/yarn/YarnResourceManagerFactory.java PRE-CREATION
samza-yarn/src/main/java/org/apache/samza/validation/YarnJobValidationTool.java 70f1e4f7663560e61b7aaa757946adbe03d2bd76
samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMaster.scala 80deb3b18c094d83af67535f9d0156f18ae3f5e4
samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaYarnAppMasterLifecycle.scala PRE-CREATION
samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaYarnAppMasterService.scala PRE-CREATION
samza-yarn/src/test/java/org/apache/samza/job/yarn/TestContainerAllocatorCommon.java 5badd29af601ce0a046ef7dce4739e31514c4e63
samza-yarn/src/test/java/org/apache/samza/job/yarn/TestSamzaTaskManager.java faa697db49ec1c11d76c88d919a356a5ae409a15
samza-yarn/src/test/scala/org/apache/samza/job/yarn/TestSamzaAppMasterLifecycle.scala 30cf34fe1fd3f74537d16e8a51b467cd50835357
samza-yarn/src/test/scala/org/apache/samza/job/yarn/TestSamzaAppMasterService.scala 7f5d9f4af088589d4287c26737bae25567c157d7
Diff: https://reviews.apache.org/r/47687/diff/
Testing
-------
Thanks,
Jagadish Venkatraman