[GitHub] [flink] wangyang0918 commented on a diff in pull request #20056: [FLINK-28142][runtime] Enrich TaskManagerLocation with node information

[GitBox <gi...@apache.org>]

wangyang0918 commented on code in PR #20056:
URL: https://github.com/apache/flink/pull/20056#discussion_r909164865


##########
flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/decorators/InitTaskManagerDecorator.java:
##########
@@ -149,7 +153,16 @@ private Container decorateMainContainer(Container container) {
                 .withResources(resourceRequirements);
 
         // Merge fields
-        mainContainerBuilder.addAllToPorts(getContainerPorts()).addAllToEnv(getCustomizedEnvs());
+        mainContainerBuilder
+                .addAllToPorts(getContainerPorts())
+                .addAllToEnv(getCustomizedEnvs())
+                .addNewEnv()
+                .withName(ENV_FLINK_POD_NODE_ID)
+                .withValueFrom(

Review Comment:
   I would like to suggest also setting the `ENV_FLINK_POD_NODE_ID` in standalone on K8s.
   
   https://nightlies.apache.org/flink/flink-docs-release-1.15/docs/deployment/resource-providers/standalone/kubernetes/



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org