You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@streampipes.apache.org by GitBox <gi...@apache.org> on 2022/11/18 15:06:53 UTC
[GitHub] [streampipes] dominikriemer opened a new pull request, #145: [STREAMPIPES-637] Remove incubating references from source code
dominikriemer opened a new pull request, #145:
URL: https://github.com/apache/streampipes/pull/145
<!--
~ Licensed to the Apache Software Foundation (ASF) under one or more
~ contributor license agreements. See the NOTICE file distributed with
~ this work for additional information regarding copyright ownership.
~ The ASF licenses this file to You under the Apache License, Version 2.0
~ (the "License"); you may not use this file except in compliance with
~ the License. You may obtain a copy of the License at
~
~ http://www.apache.org/licenses/LICENSE-2.0
~
~ Unless required by applicable law or agreed to in writing, software
~ distributed under the License is distributed on an "AS IS" BASIS,
~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
~ See the License for the specific language governing permissions and
~ limitations under the License.
~
-->
<!--
Thanks for contributing! Here are some tips you can follow to help us incorporate your contribution quickly and easily:
1. If this is your first time, please read our contributor guidelines:
- https://streampipes.apache.org/getinvolved.html
- https://cwiki.apache.org/confluence/display/STREAMPIPES/Getting+Started
2. Make sure the PR title is formatted like: `[STREAMPIPES-<Jira issue #>] PR title ...`
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., `[WIP][STREAMPIPES-<Jira issue #>] PR title ...`.
4. Please write your PR title to summarize what this PR proposes/fixes.
5. Be sure to keep the PR description updated to reflect all changes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. Make sure tests pass via `mvn clean install`.
8. (Optional) If the contribution is large, please file an Apache ICLA
- http://apache.org/licenses/icla.pdf
-->
### Purpose
<!--
Please clarify what changes you are proposing and describe how those changes will address the issue.
-->
This PR removes all references to the incubator phase:
* DISCLAIMER removed
* pom files updated
* README files updated
### Approach
<!--
Describe how you are implementing the solutions along with the design details.
-->
### Samples
<!--
Provide high-level details about the samples related to this feature.
-->
### Remarks
<!--
List related issues/PRs, link to discussions in the mailing list, todo items, or any other notes related to the PR.
-->
Fixes: <Jira issue link>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [streampipes] dominikriemer merged pull request #145: [STREAMPIPES-637] Remove incubating references from source code
Posted by GitBox <gi...@apache.org>.
dominikriemer merged PR #145:
URL: https://github.com/apache/streampipes/pull/145
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [streampipes] dominikriemer commented on a diff in pull request #145: [STREAMPIPES-637] Remove incubating references from source code
Posted by GitBox <gi...@apache.org>.
dominikriemer commented on code in PR #145:
URL: https://github.com/apache/streampipes/pull/145#discussion_r1026816926
##########
pom.xml:
##########
@@ -1848,10 +1848,10 @@ IoT data streams.
</build>
<scm>
- <developerConnection>scm:git:ssh://git@github.com/apache/incubator-streampipes.git</developerConnection>
- <connection>scm:git:ssh://git@github.com/apache/incubator-streampipes.git</connection>
- <url>https://github.com/apache/incubator-streampipes</url>
- <tag>rel/0.70.0</tag>
Review Comment:
I think that occurred during the first release attempt where we had some strange behaviour after doing the revert - so currently I wouldn't see a need for modification but let's check if it occurs again in the next release...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [streampipes] bossenti commented on a diff in pull request #145: [STREAMPIPES-637] Remove incubating references from source code
Posted by GitBox <gi...@apache.org>.
bossenti commented on code in PR #145:
URL: https://github.com/apache/streampipes/pull/145#discussion_r1026640684
##########
pom.xml:
##########
@@ -1848,10 +1848,10 @@ IoT data streams.
</build>
<scm>
- <developerConnection>scm:git:ssh://git@github.com/apache/incubator-streampipes.git</developerConnection>
- <connection>scm:git:ssh://git@github.com/apache/incubator-streampipes.git</connection>
- <url>https://github.com/apache/incubator-streampipes</url>
- <tag>rel/0.70.0</tag>
Review Comment:
@dominikriemer Did we miss to adapt this or is there a need to adapt/improve some of our scripts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org