You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/12/30 13:11:31 UTC
[GitHub] [cloudstack] stephankruggg opened a new pull request, #7037: Fix volume snapshot in a VM with an ISO attached
stephankruggg opened a new pull request, #7037:
URL: https://github.com/apache/cloudstack/pull/7037
### Description
When taking a snapshot of a volume in a VM with an ISO attached, ACS attempts to define the label of the target associated with the ISO by its ID. However, this ID may not be correctly mapped to the label, which causes the snapshot to fail.
This PR fixes this by using the defined label, instead of defining it during the snapshot process by its ID.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [X] Minor
- [ ] Trivial
### How Has This Been Tested?
In a local lab, I created 3 VMs with ISOs attached: VM1, VM2 and VM3. VM1 had 1 volume, VM2 had 2 volumes, and VM3 had 3 volumes. The label of the target associated to the ISO was `hdc` for all of them.
When taking a snapshot for the volume in VM1, the label was incorrectly generated as `hdb`, which caused the snapshot to fail.
When taking snapshots for the volumes in VM2, the label was correctly generated as `hdc`, and the snapshots succeeded.
When taking snapshots for the volumes in VM3, the label was incorrectly generated as `hdd`, which caused the snapshots to fail.
After applying the changes, I took snapshots for every volume of the VMs. In all of them the label was correctly passed as `hdc`, and all snapshots succeeded.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7037: Fix volume snapshot in a VM with an ISO attached
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #7037:
URL: https://github.com/apache/cloudstack/pull/7037#issuecomment-1369395532
<b>Trillian test result (tid-5733)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42466 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7037-t5733-kvm-centos7.zip
Smoke tests completed. 105 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_08_upgrade_kubernetes_ha_cluster | `Failure` | 566.97 | test_kubernetes_clusters.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7037: Fix volume snapshot in a VM with an ISO attached
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #7037:
URL: https://github.com/apache/cloudstack/pull/7037#issuecomment-1369088434
@weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #7037: Fix volume snapshot in a VM with an ISO attached
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on PR #7037:
URL: https://github.com/apache/cloudstack/pull/7037#issuecomment-1369087952
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7037: Fix volume snapshot in a VM with an ISO attached
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #7037:
URL: https://github.com/apache/cloudstack/pull/7037#issuecomment-1367941478
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=7037)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7037&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7037&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7037&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7037&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7037&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7037&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7037&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7037&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7037&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7037&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7037&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7037&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7037&metric=new_coverage&view=list) [36.4% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7037&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7037&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7037&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland merged pull request #7037: Fix volume snapshot in a VM with an ISO attached
Posted by GitBox <gi...@apache.org>.
DaanHoogland merged PR #7037:
URL: https://github.com/apache/cloudstack/pull/7037
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #7037: Fix volume snapshot in a VM with an ISO attached
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on PR #7037:
URL: https://github.com/apache/cloudstack/pull/7037#issuecomment-1369041168
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] codecov[bot] commented on pull request #7037: Fix volume snapshot in a VM with an ISO attached
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #7037:
URL: https://github.com/apache/cloudstack/pull/7037#issuecomment-1367937628
# [Codecov](https://codecov.io/gh/apache/cloudstack/pull/7037?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7037](https://codecov.io/gh/apache/cloudstack/pull/7037?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (13a85a2) into [main](https://codecov.io/gh/apache/cloudstack/commit/dc40ea130fc4fdbc0ac87bdf516293de8b995c84?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (dc40ea1) will **increase** coverage by `0.22%`.
> The diff coverage is `56.25%`.
```diff
@@ Coverage Diff @@
## main #7037 +/- ##
============================================
+ Coverage 11.31% 11.53% +0.22%
- Complexity 7332 7519 +187
============================================
Files 2494 2494
Lines 246787 246795 +8
Branches 38533 38534 +1
============================================
+ Hits 27929 28478 +549
+ Misses 215260 214636 -624
- Partials 3598 3681 +83
```
| [Impacted Files](https://codecov.io/gh/apache/cloudstack/pull/7037?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...om/cloud/hypervisor/kvm/resource/LibvirtVMDef.java](https://codecov.io/gh/apache/cloudstack/pull/7037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9oeXBlcnZpc29ycy9rdm0vc3JjL21haW4vamF2YS9jb20vY2xvdWQvaHlwZXJ2aXNvci9rdm0vcmVzb3VyY2UvTGlidmlydFZNRGVmLmphdmE=) | `66.69% <53.33%> (-0.63%)` | :arrow_down: |
| [...ypervisor/kvm/resource/LibvirtDomainXMLParser.java](https://codecov.io/gh/apache/cloudstack/pull/7037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9oeXBlcnZpc29ycy9rdm0vc3JjL21haW4vamF2YS9jb20vY2xvdWQvaHlwZXJ2aXNvci9rdm0vcmVzb3VyY2UvTGlidmlydERvbWFpblhNTFBhcnNlci5qYXZh) | `50.61% <100.00%> (ø)` | |
| [...n/java/com/cloud/storage/VolumeApiServiceImpl.java](https://codecov.io/gh/apache/cloudstack/pull/7037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL3N0b3JhZ2UvVm9sdW1lQXBpU2VydmljZUltcGwuamF2YQ==) | `13.01% <0.00%> (+0.13%)` | :arrow_up: |
| [.../engine/datacenter/entity/api/db/EngineHostVO.java](https://codecov.io/gh/apache/cloudstack/pull/7037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL29yY2hlc3RyYXRpb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Nsb3Vkc3RhY2svZW5naW5lL2RhdGFjZW50ZXIvZW50aXR5L2FwaS9kYi9FbmdpbmVIb3N0Vk8uamF2YQ==) | `0.48% <0.00%> (+0.48%)` | :arrow_up: |
| [...e/datacenter/entity/api/db/EngineDataCenterVO.java](https://codecov.io/gh/apache/cloudstack/pull/7037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL29yY2hlc3RyYXRpb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Nsb3Vkc3RhY2svZW5naW5lL2RhdGFjZW50ZXIvZW50aXR5L2FwaS9kYi9FbmdpbmVEYXRhQ2VudGVyVk8uamF2YQ==) | `0.65% <0.00%> (+0.65%)` | :arrow_up: |
| [...gine/schema/src/main/java/com/cloud/dc/VlanVO.java](https://codecov.io/gh/apache/cloudstack/pull/7037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL3NjaGVtYS9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC9kYy9WbGFuVk8uamF2YQ==) | `29.16% <0.00%> (+2.77%)` | :arrow_up: |
| [...c/main/java/com/cloud/network/dao/IPAddressVO.java](https://codecov.io/gh/apache/cloudstack/pull/7037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL3NjaGVtYS9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC9uZXR3b3JrL2Rhby9JUEFkZHJlc3NWTy5qYXZh) | `39.42% <0.00%> (+2.88%)` | :arrow_up: |
| [.../java/com/cloud/network/dao/PhysicalNetworkVO.java](https://codecov.io/gh/apache/cloudstack/pull/7037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL3NjaGVtYS9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC9uZXR3b3JrL2Rhby9QaHlzaWNhbE5ldHdvcmtWTy5qYXZh) | `53.03% <0.00%> (+3.03%)` | :arrow_up: |
| [...java/com/cloud/agent/manager/AgentManagerImpl.java](https://codecov.io/gh/apache/cloudstack/pull/7037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL29yY2hlc3RyYXRpb24vc3JjL21haW4vamF2YS9jb20vY2xvdWQvYWdlbnQvbWFuYWdlci9BZ2VudE1hbmFnZXJJbXBsLmphdmE=) | `4.94% <0.00%> (+4.94%)` | :arrow_up: |
| ... and [13 more](https://codecov.io/gh/apache/cloudstack/pull/7037/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7037: Fix volume snapshot in a VM with an ISO attached
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #7037:
URL: https://github.com/apache/cloudstack/pull/7037#issuecomment-1369041367
@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7037: Fix volume snapshot in a VM with an ISO attached
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #7037:
URL: https://github.com/apache/cloudstack/pull/7037#issuecomment-1369074584
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5155
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org