You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "romsharon98 (via GitHub)" <gi...@apache.org> on 2023/12/04 13:18:26 UTC

[PR] bugfix clean-logs, avoid crushed container when folder not found [airflow]

romsharon98 opened a new pull request, #36050:
URL: https://github.com/apache/airflow/pull/36050

   Follow up: #33162 
   
   In my case I have high available scheduler (2 schedulers).
   
   When I upload the chart on kubernetes I got exception inside the container scheduler-log-groomer:
   `
   find: ׳/opt/airflow/logs/dag_id=example/run_id=example׳: No such file or directory
   find: ׳/opt/airflow/logs/dag_id=example/run_id=example1׳: No such file or directory
   `
   
   I think it's a race condition when more then 1 scheduler runs log-grommer container and try to delete the same directory.
   
   
   <!--
    Licensed to the Apache Software Foundation (ASF) under one
    or more contributor license agreements.  See the NOTICE file
    distributed with this work for additional information
    regarding copyright ownership.  The ASF licenses this file
    to you under the Apache License, Version 2.0 (the
    "License"); you may not use this file except in compliance
    with the License.  You may obtain a copy of the License at
   
      http://www.apache.org/licenses/LICENSE-2.0
   
    Unless required by applicable law or agreed to in writing,
    software distributed under the License is distributed on an
    "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    KIND, either express or implied.  See the License for the
    specific language governing permissions and limitations
    under the License.
    -->
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of an existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   
   
   <!-- Please keep an empty line above the dashes. -->
   ---
   **^ Add meaningful description above**
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] bugfix clean-logs, avoid crushed container when folder not found [airflow]

Posted by "uranusjr (via GitHub)" <gi...@apache.org>.
uranusjr merged PR #36050:
URL: https://github.com/apache/airflow/pull/36050


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] bugfix clean-logs, avoid crushed container when folder not found [airflow]

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #36050:
URL: https://github.com/apache/airflow/pull/36050#discussion_r1414463596


##########
scripts/docker/clean-logs.sh:
##########
@@ -35,7 +35,7 @@ while true; do
     -type f -mtime +"${RETENTION}" -name '*.log' -print0 | \
     xargs -0 rm -f
 
-  find "${DIRECTORY}"/logs -type d -empty -delete
+  trap find "${DIRECTORY}"/logs -type d -empty -delete ERR

Review Comment:
   Why not just `find "${DIRECTORY}"/logs -type d -empty -delete || true` ? That will ignore any errors. I think it should be pretty enough.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] bugfix clean-logs, avoid crushed container when folder not found [airflow]

Posted by "romsharon98 (via GitHub)" <gi...@apache.org>.
romsharon98 commented on code in PR #36050:
URL: https://github.com/apache/airflow/pull/36050#discussion_r1413867730


##########
scripts/docker/clean-logs.sh:
##########
@@ -35,7 +35,7 @@ while true; do
     -type f -mtime +"${RETENTION}" -name '*.log' -print0 | \
     xargs -0 rm -f
 
-  find "${DIRECTORY}"/logs -type d -empty -delete
+  trap find "${DIRECTORY}"/logs -type d -empty -delete ERR

Review Comment:
   This fix is simple and works but the disadvantage of it that every ERR is except here.
   There is other solution that will except the specific file not found exception:
   
   ```bash
   error_file=$(mktemp)
   find "${DIRECTORY}"/logs -type d -empty -delete
   
   if grep -q "No such file or directory" "$error_file"; then
       cat "$error_file"
       echo "Info: if you run with hight available scheduler probably the other scheduler already delete it"
   fi
   
   rm "$error_file"
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] bugfix clean-logs, avoid crushed container when folder not found [airflow]

Posted by "romsharon98 (via GitHub)" <gi...@apache.org>.
romsharon98 commented on code in PR #36050:
URL: https://github.com/apache/airflow/pull/36050#discussion_r1414515395


##########
scripts/docker/clean-logs.sh:
##########
@@ -35,7 +35,7 @@ while true; do
     -type f -mtime +"${RETENTION}" -name '*.log' -print0 | \
     xargs -0 rm -f
 
-  find "${DIRECTORY}"/logs -type d -empty -delete
+  trap find "${DIRECTORY}"/logs -type d -empty -delete ERR

Review Comment:
   Yep. you are right. :) 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org