You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by gengliangwang <gi...@git.apache.org> on 2018/10/16 10:10:03 UTC
[GitHub] spark pull request #22744: [SPARK-25741][WebUI] Long URLs are not rendered p...
GitHub user gengliangwang opened a pull request:
https://github.com/apache/spark/pull/22744
[SPARK-25741][WebUI] Long URLs are not rendered properly in web UI
## What changes were proposed in this pull request?
When the URL for description column in the table of job/stage page is long, WebUI doesn't render it properly.
Both job and stage page are using the class `name-link` for the description URL, so change the style of `a.name-link` to fix it.
## How was this patch tested?
Manual test on my local:
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gengliangwang/spark fixUILink
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/22744.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #22744
----
commit 9967c02770e0dd528476092a00e05f83c936f424
Author: Gengliang Wang <ge...@...>
Date: 2018-10-16T09:59:42Z
use break-word for a.name-link
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22744: [SPARK-25741][WebUI] Long URLs are not rendered properly...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22744
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97449/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22744: [SPARK-25741][WebUI] Long URLs are not rendered properly...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22744
**[Test build #97449 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97449/testReport)** for PR 22744 at commit [`9967c02`](https://github.com/apache/spark/commit/9967c02770e0dd528476092a00e05f83c936f424).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22744: [SPARK-25741][WebUI] Long URLs are not rendered properly...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22744
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22744: [SPARK-25741][WebUI] Long URLs are not rendered properly...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22744
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22744: [SPARK-25741][WebUI] Long URLs are not rendered properly...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22744
**[Test build #97449 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97449/testReport)** for PR 22744 at commit [`9967c02`](https://github.com/apache/spark/commit/9967c02770e0dd528476092a00e05f83c936f424).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22744: [SPARK-25741][WebUI] Long URLs are not rendered properly...
Posted by gengliangwang <gi...@git.apache.org>.
Github user gengliangwang commented on the issue:
https://github.com/apache/spark/pull/22744
@srowen @vanzin
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22744: [SPARK-25741][WebUI] Long URLs are not rendered properly...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22744
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4030/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22744: [SPARK-25741][WebUI] Long URLs are not rendered properly...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22744
Merged to master/2.4
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org