[GitHub] [incubator-mxnet] arcadiaphy commented on a change in pull request #14352: Optimize NMS part 2

[GitBox <gi...@apache.org>]

arcadiaphy commented on a change in pull request #14352: Optimize NMS part 2
URL: https://github.com/apache/incubator-mxnet/pull/14352#discussion_r263249161
 
 

 ##########
 File path: src/operator/contrib/bounding_box-inl.cuh
 ##########
 @@ -280,6 +280,45 @@ void NMSApply(mshadow::Stream<gpu> *s,
   }
 }
 
+__launch_bounds__(512)
+__global__ void nms_calculate_batch_start_kernel(int32_t * batch_start,
+                                                 int32_t * valid_batch_id,
+                                                 size_t N,
+                                                 int num_batch) {
+  size_t tid = blockIdx.x * blockDim.x + threadIdx.x;
+  if (tid < N) {
+    const int32_t previous = tid > 0 ? __ldg(valid_batch_id + tid - 1) : -1;
 
 Review comment:
   Using __ldg intrinsics will fail to compile on some earlier cuda archetectures.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services